Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp946516pxb;
        Wed, 3 Mar 2021 22:05:47 -0800 (PST)
X-Google-Smtp-Source: ABdhPJybSSpT9rOSLttAw/yOJrBej0Kl5KcIDVj9F72cwc4j+Q0fv0acHksVI42N7UngqEeTCyqa
X-Received: by 2002:a05:6402:22b5:: with SMTP id cx21mr2605052edb.27.1614837947792;
        Wed, 03 Mar 2021 22:05:47 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1614837947; cv=none;
        d=google.com; s=arc-20160816;
        b=J4mEbttSKgF1esPOB/nFc7pbs0TwdvUlKzSRESqYG/e6iw0KyCTc6vMg8xAeV06Pax
         uxNa/Fzo7dSaCThpaL4pz2P+RieJiTaAfrpCGCUKuop/NdkGEuHoP+llCxqssWqGMZUN
         rMrhKwUkC92qEJ4LTQwk482opiS7K4NxTe1wXsYqSOaZsULOqyRYKOG/lhp3SIsIDU/a
         3AtwFxkuRoNBZmCg/NSLZFVENNv84se14z3g33uKIKmzzAwkUBkQ0UTet5DXgKNaokT7
         6hjbhSPyT7N20giPf2MBToqbBTDLfDJv8RY3z8y+x5vuXMhB+kFLzHRON67ZNycV94mq
         Geuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-transfer-encoding
         :mime-version:references:in-reply-to:message-id:date:subject:cc:to
         :from;
        bh=FeQHtfi4mCSWbQH0/aD7Oy3q/R8JrFmF5liDHR+wnLk=;
        b=cRYUt7L2GWDmtyOvZCWrJAjaTFn6so2FAG64j/vc95UN3blJ4xmgfLw3kPZHAG0Dvo
         lEkEvTm4pkAiZYV4AISA17DINjkTnFyNAuKvvadf0vC3PaR/fB3l3RfLVAHrZML6qBgs
         aytWDg2sklUBVoyeyVSNXsjM+ZzBAKDWQhLKELnLagAfVAKT674MGoePEGoA6U2gTFXw
         EulI1kvRpSVB0e/7DSvP9+2Po5wX4+2pqKLxz7NnXSYzLsbAw5y5sAtFw7zq04gWyLkm
         59pN9ebP3s7CNPia0GDzC8APIUcgjcQQ7xLyur5YEEvnhAmLXFilJcCa/XcojBNDRijt
         ppiw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=HEiZZh4D;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id dk18si8774426edb.178.2021.03.03.22.05.25;
        Wed, 03 Mar 2021 22:05:47 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=HEiZZh4D;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1379081AbhCBJjV (ORCPT <rfc822;luke.ovalle@gmail.com>
        + 99 others); Tue, 2 Mar 2021 04:39:21 -0500
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:11982 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1837925AbhCBJNK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 Mar 2021 04:13:10 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B603e017d0000>; Tue, 02 Mar 2021 01:12:29 -0800
Received: from nvdebian.localnet (172.20.145.6) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 2 Mar
 2021 09:12:26 +0000
From:   Alistair Popple <apopple@nvidia.com>
To:     Ralph Campbell <rcampbell@nvidia.com>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
        "bskeggs@redhat.com" <bskeggs@redhat.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "John Hubbard" <jhubbard@nvidia.com>,
        "jglisse@redhat.com" <jglisse@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        "hch@infradead.org" <hch@infradead.org>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>
Subject: Re: [PATCH v3 6/8] mm: Selftests for exclusive device memory
Date:   Tue, 2 Mar 2021 20:12:24 +1100
Message-ID: <4866160.ulnvbvOQiP@nvdebian>
In-Reply-To: <MN2PR12MB43440D6E37E35DAF962F556EC29A9@MN2PR12MB4344.namprd12.prod.outlook.com>
References: <20210226071832.31547-1-apopple@nvidia.com> <20210226071832.31547-7-apopple@nvidia.com> <MN2PR12MB43440D6E37E35DAF962F556EC29A9@MN2PR12MB4344.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Originating-IP: [172.20.145.6]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1614676349; bh=FeQHtfi4mCSWbQH0/aD7Oy3q/R8JrFmF5liDHR+wnLk=;
        h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:
         MIME-Version:Content-Transfer-Encoding:Content-Type:
         X-Originating-IP:X-ClientProxiedBy;
        b=HEiZZh4DK3KNf5gTFX02zJnM2b4ou/jDcSzCQDNZpPUD1j+uXhbse5auYqfmiU7Ec
         YXvVqk1kNu+9JT6l7F02Id1OMF+U0wEmNbvQu+/A3fXdEze7YxM7ab4F6YYYKwV/Fg
         Dm4znbewQozpm7A3c+OLIY1ia2ne7u3sRgRh+vejOiSB6QgLd6BMQm44HQa9cMzZFo
         k5ZNYwLJtxHXK1Cy2RXvbbUDWH1IntCrq79+XEho9Uqe5MtS3waXVyOSNZ7GIWALM8
         B+++XLu/MiXh8eoRa+xCczpfPLRtfclfNcVGwwZ6yWPMbfL6KvN2XP1foQfzlXEZuJ
         iqBU0ylYO9AMQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, 2 March 2021 10:14:56 AM AEDT Ralph Campbell wrote:
> > From: Alistair Popple <apopple@nvidia.com>
> > Sent: Thursday, February 25, 2021 11:19 PM
> > To: linux-mm@kvack.org; nouveau@lists.freedesktop.org;
> > bskeggs@redhat.com; akpm@linux-foundation.org
> > Cc: linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; dri-
> > devel@lists.freedesktop.org; John Hubbard <jhubbard@nvidia.com>; Ralph
> > Campbell <rcampbell@nvidia.com>; jglisse@redhat.com; Jason Gunthorpe
> > <jgg@nvidia.com>; hch@infradead.org; daniel@ffwll.ch; Alistair Popple
> > <apopple@nvidia.com>
> > Subject: [PATCH v3 6/8] mm: Selftests for exclusive device memory
> > 
> > Adds some selftests for exclusive device memory.
> > 
> > Signed-off-by: Alistair Popple <apopple@nvidia.com>
> 
> One minor nit below, but you can add

Thanks Ralph. Will fix that.

> Tested-by: Ralph Campbell <rcampbell@nvidia.com>
> Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
> 
> > +static int dmirror_exclusive(struct dmirror *dmirror,
> > +			     struct hmm_dmirror_cmd *cmd)
> > +{
> > +	unsigned long start, end, addr;
> > +	unsigned long size = cmd->npages << PAGE_SHIFT;
> > +	struct mm_struct *mm = dmirror->notifier.mm;
> > +	struct page *pages[64];
> > +	struct dmirror_bounce bounce;
> > +	unsigned long next;
> > +	int ret;
> > +
> > +	start = cmd->addr;
> > +	end = start + size;
> > +	if (end < start)
> > +		return -EINVAL;
> > +
> > +	/* Since the mm is for the mirrored process, get a reference first. */
> > +	if (!mmget_not_zero(mm))
> > +		return -EINVAL;
> > +
> > +	mmap_read_lock(mm);
> > +	for (addr = start; addr < end; addr = next) {
> > +		int i, mapped;
> > +
> > +		if (end < addr + (64 << PAGE_SHIFT))
> > +			next = end;
> > +		else
> > +			next = addr + (64 << PAGE_SHIFT);
> 
> I suggest using ARRAY_SIZE(pages) instead of '64' to make the meaning clear.
> 
>