Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CGME20210222081517epcas1p37fef998684dc9eae0bcd2764a3f82fb1@epcas1p3.samsung.com>
 <20210222083156.19158-1-sh043.lee@samsung.com>
In-Reply-To: <20210222083156.19158-1-sh043.lee@samsung.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Tue, 2 Mar 2021 11:39:04 +0100
Message-ID: <CAPDyKFqtB3WLD5A+5SesyOArbbVaZROdeu23FwFDy667h0M6eQ@mail.gmail.com>
Subject: Re: [PATCH] mmc: core: set read only with permanent write protect
To:     Seunghui Lee <sh043.lee@samsung.com>
Cc:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
        Yue Hu <huyue2@yulong.com>, Tian Tao <tiantao6@hisilicon.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        grant.jung@samsung.com, jt77.jang@samsung.com,
        DooHyun Hwang <dh0421.hwang@samsung.com>,
        junwoo80.lee@samsung.com, jangsub.yi@samsung.com,
        Chanwoo Lee <cw9316.lee@samsung.com>, sh8267.baek@samsung.com,
        wkon.kim@samsung.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 22 Feb 2021 at 09:15, Seunghui Lee <sh043.lee@samsung.com> wrote:
>
> Some of SD cards sets permanent write protection
> due to lifespan or internal problem.
> Host can find out it's protected permanantly during initialization.
> Once set read only during initialization,
> it could prevent unnecessary write operation in it.
>
> Signed-off-by: Seunghui Lee <sh043.lee@samsung.com>

Applied for next and by adding a stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/core/sd.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index 6fa51a6ed058..2c48d6504101 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -135,6 +135,9 @@ static int mmc_decode_csd(struct mmc_card *card)
>                         csd->erase_size = UNSTUFF_BITS(resp, 39, 7) + 1;
>                         csd->erase_size <<= csd->write_blkbits - 9;
>                 }
> +
> +               if (UNSTUFF_BITS(resp, 13, 1))
> +                       mmc_card_set_readonly(card);
>                 break;
>         case 1:
>                 /*
> @@ -169,6 +172,9 @@ static int mmc_decode_csd(struct mmc_card *card)
>                 csd->write_blkbits = 9;
>                 csd->write_partial = 0;
>                 csd->erase_size = 1;
> +
> +               if (UNSTUFF_BITS(resp, 13, 1))
> +                       mmc_card_set_readonly(card);
>                 break;
>         default:
>                 pr_err("%s: unrecognised CSD structure version %d\n",
> --
> 2.29.0
>