Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp956098pxb; Wed, 3 Mar 2021 22:26:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJzNdKYtT6X8iw2poCkSwY65aSFSMjKaT6VzVPjuACGaR+gEd8fgEJf+ADSn8w+KTx3qHlyj X-Received: by 2002:a17:906:a44:: with SMTP id x4mr2499369ejf.101.1614839195830; Wed, 03 Mar 2021 22:26:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614839195; cv=none; d=google.com; s=arc-20160816; b=UtFTxG7wFJyTYqKcbJxf9G+Qhj98ACD3xMY9wUgO3udqLMCtWaLkr+2jKzo7V2IUo0 jU+1Jesv995RuEnF/RR40+kh/2dWB/ibNtwQcVjzzgZosufFueGqVNqpSIXxJUjgPD0Q cMEH6KA5dn4Bsamj1Pjy3QnJGDmtIchLyETzJ4HuB/v7TBUSsQMSKydKSPqXv25iZSLU 4sYoQ/UZUrqDFp0rrcrhkLqkSVStTZQqsITTt+sxNs17pa7iCx/DjPdeh4mfO9OyT7eE gedsFS9fc2f5eH6MjWCAwkF7Gdb9CijoIICsL0MFStB1L9re4v+TRlbaKa3jWNs5GjW+ vsGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=iytCnS3/Fqm59AJCTx4Td5YHfFiyyY8XF5Iqi/De8P4=; b=crG3Zc1GBa3gvL7lEGrP2VMPiwAC+lh/MwOwGvE5b8iN6NS+o2hujhJD537rcutzir Z6X3FzuXZoy6mf9qDok33h5l2Gw48i0oJPJ05YPmu836LLFiNHryAhAjbQczzq8LNrQ4 rr6FHcKKMREoESJ51UzIQvCqIoMqVlJOGh7kACAplUo582jb511xFClFJujpbryUq+gc 8i04SdI6HOm4DEW7KCyVOAyUaktoq2gMeCH8BLt0TabG25Ua/0OG8Yg1/6umjJOb/Ykx wlbJPicAFrjFgjWIDSfXUy97/qbMATvtRe9WE5SaLiVyEcOCsNnQ4kGN/1gX46vnKhtr TmRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JvfE4cxh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id by3si13298362edb.496.2021.03.03.22.26.13; Wed, 03 Mar 2021 22:26:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JvfE4cxh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1449023AbhCBQDd (ORCPT + 99 others); Tue, 2 Mar 2021 11:03:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:36436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351142AbhCBNcc (ORCPT ); Tue, 2 Mar 2021 08:32:32 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1D9CB64F12; Tue, 2 Mar 2021 13:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614691310; bh=iytCnS3/Fqm59AJCTx4Td5YHfFiyyY8XF5Iqi/De8P4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JvfE4cxhrvhQNG1uiT0poBGzhekrWpbOlIxK5VePyKISfBBW0lWl+QjPPnYMDsQxj aLVRYCTHbYDFDa2i6U5CLy2RDtw++OtYk4lMJGB3yevFI4N1u4lDm47+L3H2JvSsTe d7CIVghk8hBQXjor5pOtpUj70VWid0EEzCgnKx1sgW7t6Seh0kCpSNYNGWstspbKEg jS7hl04Q9dvcbiRQrPgAn7j1ZCP04AllSdxWPUzB2w1W3EAbHoz8BN2VGepEoV0IHj 1zFWHOJPzbnVV/lKcKtt8XuUeX/J4s21r4JRqXFQWr75enJiCzOKUdrnPgGIfUJtz0 HLYJf/BOR4FQA== Date: Tue, 2 Mar 2021 13:20:43 +0000 From: Mark Brown To: tangbin Cc: Paul Cercueil , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: codec: Omit superfluous error message injz4760_codec_probe() Message-ID: <20210302132043.GF4522@sirena.org.uk> References: <20210302121148.28328-1-tangbin@cmss.chinamobile.com> <76c87931-094e-0804-9405-ad4841fae2d3@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+jhVVhN62yS6hEJ8" Content-Disposition: inline In-Reply-To: <76c87931-094e-0804-9405-ad4841fae2d3@cmss.chinamobile.com> X-Cookie: Friction is a drag. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+jhVVhN62yS6hEJ8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 02, 2021 at 08:55:25PM +0800, tangbin wrote: > Yes, I would have written it in your ways, but considered the variable > "ret", I gave up, and just deleted dev_err(). If it's not used any more it can just be removed. --+jhVVhN62yS6hEJ8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmA+O6sACgkQJNaLcl1U h9D3Qgf8DCZVmc6ugbe3U+nU/APz1o3uNlnfvCBUw0+J0EN+fkVj0Aoj493A0viD IuXCy7XCPmam3JE4yIYbnA/FzmIs+PJ36/CnKNOH22e63WxWd5zdFk1S4dW6LA1m 1ucckj2XD3+y6xGscd7FIdgX7EPoGYvKC2zB6QYBypL4mkNk09S7bjStYApaZKNK q+3wIjc/HoGFrKwG+L5v/wDeoMA6NX+x526O+3BDCv46JClza20O0OtHg8iSE8hL oKJxwBcluivy3SW/McFFmCIHnS8t+6B/UZ72PsSKjFkyKSqB8lgLNE5Dez/F10K8 VFuCsAchxsyOWBiVzHCjrZsDDKze1g== =uM7f -----END PGP SIGNATURE----- --+jhVVhN62yS6hEJ8--