Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 02 Mar 2021 15:06:54 +0100
Message-ID: <s5hsg5dfy4h.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Werner Sembach <wse@tuxedocomputers.com>
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
In-Reply-To: <c7a394b1-edd3-a692-0981-45086da82aac@tuxedocomputers.com>
References: <c7a394b1-edd3-a692-0981-45086da82aac@tuxedocomputers.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 02 Mar 2021 12:19:03 +0100,
Werner Sembach wrote:
> 
> From: Eckhart Mohr <e.mohr@tuxedocomputers.com>
> 
> ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
> 
> This applies a SND_PCI_QUIRK(...) to the Clevo NH55RZQ barebone. This
> fixes the issue of the device not recognizing a pluged in microphone.
> 
> The device has both, a microphone only jack, and a speaker + microphone
> combo jack. The combo jack already works. The microphone-only jack does
> not recognize when a device is pluged in without this patch.
> 
> Signed-off-by: Eckhart Mohr <e.mohr@tuxedocomputers.com>
> Co-developed-by: Werner Sembach <wse@tuxedocomputers.com>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> Hi,
> this is my first ever submitted kernel patch, feel free to criticise me if I made an error or missed a best practise bullet point.

The patch isn't cleanly applicable.  Could you try to submit via
git-send-email instead?

> Also: I'm unsure if this would fit the requirements for stable@vger.kernel.org and/or trivial@kernel.org, but I think not (correct me if I'm wrong).

Cc to stable is worthwhile.  You can simply add
  Cc: <stable@vger.kernel.org>

around your signed-off-by lines in the patch.


thanks,

Takashi