Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp957936pxb; Wed, 3 Mar 2021 22:30:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRQXvKse7tWvz4ccix9zCUF/1SsnrJIwVYU4ZN+PuR4/FsN0RxbELRhGEtwxNSAmqPj5P3 X-Received: by 2002:a50:9dc9:: with SMTP id l9mr2611320edk.377.1614839448635; Wed, 03 Mar 2021 22:30:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614839448; cv=none; d=google.com; s=arc-20160816; b=1BRRFiN2KrTI3PaXR8bOJ6XCoOnavOMsEEMIblSAIS6ZflSJ0Z24bIcfPorJuAJmAP Dp51Pk0rIWwaQ2+CLXWPHH+kGyNUSFuALLFUS5rThgRO9C/IpaC5iIJzAXuUB7AE7BdF OboUYcwGZC1LqFjUwD3Hhuty4VpfJruU4Z6fjnALq1FDs+AeiJ0TELVuhj7ik9gcmdxi izycqHOcq0VBC+UAo5m3Shl0IxyNBncWs1Psm/73KWPCqnZC38+bCkQE42XfLMlFdWoB rAjsPoWMJ8oVCW1s7zBtXnDqqL7z8Vok0rggxK6jdNY8WVZadcMoUX65/N+PD7KDvsmI 0yYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=qFijmaekPHJD3kPmF9bTJVj9xnCE84kNcgWrH8uZtcY=; b=MhGG/aXfx0fJvATPFjG/mmq7MayJYvhLnUIVvruu+bBz+cmAMdOErefXqd5OXPt0uQ SSJvFlMs5T76DT8rUpVmop0mNjKdyhrd912t3a7Lt7wENR9537fLWduxe1Lc9U1kYLiY kNFEPUSD2Plyo1s3O/W7eQXe0h5gBw/C56aqD67hXF7sa6ZeNS9WdlBZ7NA7l25Q9uUf rkA7wqPh2n80Bad+CFrx2XeELklJStVDXSg13g35nvogQpIEqhlqtRdBnRIk0hYZyJ6T /XGsWiDinrIhwHonwBDuQ9ilnfl/kc6A/Ja8t9kZLFXZzSU3T7iEGaOUCQO4YQo9tC5M rbtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q18si16458860ejt.469.2021.03.03.22.30.26; Wed, 03 Mar 2021 22:30:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1572969AbhCBQ3Y (ORCPT + 99 others); Tue, 2 Mar 2021 11:29:24 -0500 Received: from mga03.intel.com ([134.134.136.65]:45327 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1578312AbhCBOJr (ORCPT ); Tue, 2 Mar 2021 09:09:47 -0500 IronPort-SDR: K7r4vHo9ApudH4zEEukB3puIxRhuMGy+5khM0RgdYivdrpbst9iGbjwVtAAHFQaTWJVUqLUUic Gw5sPbEqWRkA== X-IronPort-AV: E=McAfee;i="6000,8403,9910"; a="186875224" X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="186875224" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2021 05:56:32 -0800 IronPort-SDR: OJGfYUaLDyye6fn3rzxWDc8ycT00Vhy7np5QGWGX4X3uDEpklkU5+TEz28MGEMKjl7QzcJ2Pz9 N7/rqB4Wl97g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="406065322" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 02 Mar 2021 05:56:30 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 8209DF4; Tue, 2 Mar 2021 15:56:30 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 2/5] mfd: intel_quark_i2c_gpio: Unregister resources in reversed order Date: Tue, 2 Mar 2021 15:56:17 +0200 Message-Id: <20210302135620.89958-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210302135620.89958-1-andriy.shevchenko@linux.intel.com> References: <20210302135620.89958-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In ->remove() unregister resources in reversed order, i.e. MFD devices first followed by I²C clock. Signed-off-by: Andy Shevchenko --- drivers/mfd/intel_quark_i2c_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c index 124c0ee84169..db756b74195a 100644 --- a/drivers/mfd/intel_quark_i2c_gpio.c +++ b/drivers/mfd/intel_quark_i2c_gpio.c @@ -269,8 +269,8 @@ static int intel_quark_mfd_probe(struct pci_dev *pdev, static void intel_quark_mfd_remove(struct pci_dev *pdev) { - intel_quark_unregister_i2c_clk(&pdev->dev); mfd_remove_devices(&pdev->dev); + intel_quark_unregister_i2c_clk(&pdev->dev); } static struct pci_driver intel_quark_mfd_driver = { -- 2.30.1