Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CANgQ54cmG4mCx42i1ErXMJpv=2OmOGjjEgv=8oy90CpKcwkpZg@mail.gmail.com>
In-Reply-To: <CANgQ54cmG4mCx42i1ErXMJpv=2OmOGjjEgv=8oy90CpKcwkpZg@mail.gmail.com>
From:   =?UTF-8?B?6YKx5ZCN56Kp?= <ccchiu77@gmail.com>
Date:   Tue, 2 Mar 2021 23:07:50 +0800
Message-ID: <CANgQ54fSYJDoyoE-9064cyHybMN88Gxt3ZmsfWbVaDVO_sM6bw@mail.gmail.com>
Subject: Re: Questions for TX power get/set implementation of realtek WiFi
To:     pkshih@realtek.com, tehuang@realtek.com, Larry.Finger@lwfinger.net
Cc:     Reto Schneider <reto.schneider@husqvarnagroup.com>,
        kvalo@codeaurora.org, kuba@kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

=E9=82=B1=E5=90=8D=E7=A2=A9 <ccchiu77@gmail.com> =E6=96=BC 2021=E5=B9=B43=
=E6=9C=882=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=886:21=E5=AF=AB=E9=
=81=93=EF=BC=9A
>
> Hi guys,
>     I'm planning to implement the get_txpower hook function of the
> struct ieee80211_ops and handle the IEEE80211_CONF_CHANGE_POWER for
> rtl8xxxu driver. So that users can get the information of the current
> tx power limit and set a new limit value with iw commands.
>
>     I found there's phy_txpwr_idx_to_dbm() of each driver in
> realtek/rtlwifi to translate the tx power index parsed from efuse to
> tx power level in dBm. Does the power level translated represent the
> current tx power limit in dBm? In my RTL8188CUS module, the power
> index of CCK/OFDM from efuse for each channel is basically 36/38, thus
> the translated txpower level is 11dBm. Is this the expected value for
> the default txpower limit value? Or do I need some other formula to
> compute?
>
>     And for the handler of IEEE80211_CONF_CHANGE_POWER, can I
> translate the hw->conf.power_level with the phy_dbm_to_txpwr_idx
> functions I found in some rtlwifi family drivers, then directly set
> the txpower index with phy_set_txpower_index functions which write
> power index to bbreg for different rates (CCK and OFDM)? Are there
> some invalid values I should take care of because the TCP RX
> performance seems to be extremely low when I write the power index
> value translated from 20dBm to bbreg. Any suggestions for what I
> should handle before writing the bbreg?
>
> Chris

Sorry for confusion. I'm removing and correcting the invalid mail address h=
ere.