Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp958591pxb; Wed, 3 Mar 2021 22:32:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJyMhznxLI4yHD5Fin2dDmoJtKAZdOCK46+DyNelQ7Qtbnqt2rzbfzhLSCj/HGQC+kPYofP3 X-Received: by 2002:a17:906:d0c3:: with SMTP id bq3mr2483859ejb.424.1614839530178; Wed, 03 Mar 2021 22:32:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614839530; cv=none; d=google.com; s=arc-20160816; b=t5LvntdbxaIe/JRloTLk5Nj9CjkqlpyEmtCVAMigzfdCicy34x8PbmzK0ABRqQ13rl PtU8UJUDH8OxIegD6snksvIvlpBlfs/ybroRSvzBULOcyJMUl4GlIJehs0s4zsc/llJy x9xJx70/fF8bSo3SCHZVqQhhFyQK5zusTrH2wP8nOAUYBWKCTikQfrTgvY5BDrBi/RIz B03xmkkc/tKi47dg8sNBl6JjXV8gaK+n4XLBQcp8BIWeIsCsq9Fwu7ZFzphomT+oXNcs h/0YJl1BvdWLwuqkwDhINsB9brM8rCB3I4gNsSmamxMeHKPIPtXlNI9XB3i7O+sKWrEa YCkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=Y78dtO3V2JoUb8OGC/cxjAjsmQoOlCEgTczsk7syBMY=; b=JxswHJk/IGDIrjaWUP90HL7kALhyX1/Spn1jWyk8toHY/GQFXj3PQYNVTabOvI2LTV U0hOFnTuoCE8lm2/sy5bDEHHOZTe7e93oLI8Xm345JFK0ya0nRQxPR8gmzDFjnLY3y9b SVeztbCr61keblB98dCq0UfJqULyYCk1HQJ7iNR6ebo4pxBGXAADGnix/mz+YzQsmw7K 32eY9on2YTSysZtmmYkxDwUQK1pBKP4NrlUUYI10wiU3S9WqzT91VRATlxVA7VOON6Cz 8jK3t3miCjOFc1U19ihRY1LjC5VgRnAVeuqS9ZxSf8hbUeGTKY3Fv2mHw8hUWFUfoFOm WFkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p11si14399442ejg.105.2021.03.03.22.31.47; Wed, 03 Mar 2021 22:32:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1580388AbhCBSCj (ORCPT + 99 others); Tue, 2 Mar 2021 13:02:39 -0500 Received: from mga07.intel.com ([134.134.136.100]:2413 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1575654AbhCBPYQ (ORCPT ); Tue, 2 Mar 2021 10:24:16 -0500 IronPort-SDR: tGSC/RbeZnFav9QCKAOs5qn9iNXSPXtO3EI37PFcoyyF4YMPUf7b8Cl1aIwd4JTc58fJ+rXr3c erP0UOO0MKog== X-IronPort-AV: E=McAfee;i="6000,8403,9911"; a="250893647" X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="250893647" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2021 07:21:25 -0800 IronPort-SDR: SfmgQ+HsK7TbX7TCF729/nx9mUGp32CqL5L/NzQNT0qBl/taPvBd/q3+zKAYoCyKk0dq5eYNr8 e8cUndjyEBRw== X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="399062802" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2021 07:21:23 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lH6pp-009PqC-Px; Tue, 02 Mar 2021 17:21:17 +0200 Date: Tue, 2 Mar 2021 17:21:17 +0200 From: Andy Shevchenko To: Mika Westerberg Cc: Linus Walleij , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , ACPI Devel Maling List , "Rafael J. Wysocki" , Len Brown Subject: Re: [PATCH v1 1/3] gpiolib: acpi: Add ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER quirk Message-ID: References: <20210225163320.71267-1-andriy.shevchenko@linux.intel.com> <20210225163320.71267-2-andriy.shevchenko@linux.intel.com> <20210302151430.GY2542@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210302151430.GY2542@lahna.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 02, 2021 at 05:14:30PM +0200, Mika Westerberg wrote: > On Tue, Mar 02, 2021 at 05:09:24PM +0200, Andy Shevchenko wrote: > > On Tue, Mar 02, 2021 at 03:48:43PM +0100, Linus Walleij wrote: > > > On Thu, Feb 25, 2021 at 5:33 PM Andy Shevchenko > > > wrote: > > > > > > > On some systems the ACPI tables has wrong pin number and instead of > > > > having a relative one it provides an absolute one in the global GPIO > > > > number space. > > > > > > > > Add ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER quirk to cope with such cases. > > > > > > > > Fixes: ba8c90c61847 ("gpio: pca953x: Override IRQ for one of the expanders on Galileo Gen 2") > > > > Depends-on: 0ea683931adb ("gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip") > > > > Signed-off-by: Andy Shevchenko > > > > > > OH THE HORROR! > > > However, we discussed it before. It is as it is. > > > > Unfortunately :-( (And recently it seems MS does something really "creative" on > > ARM ACPI platform) > > > > > It's the right place to fix the problem, so: > > > Acked-by: Linus Walleij > > > > I am waiting for Mika, but if he keeps silent let's say to the end of the day, > > I will submit it as is to the v5.12-rcX fixes. > > Sorry for the delay - I somehow missed this. Feel free to add my ACK too. Thanks, Mika! -- With Best Regards, Andy Shevchenko