Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210214161348.369023-1-timur@kernel.org> <20210214161348.369023-4-timur@kernel.org>
 <CAMuHMdULKZCJevVJcp7TxzLdWLjsQPhE8hqxhnztNi9bjT_cEw@mail.gmail.com>
 <CANpmjNNm-4s16_KQ1_NqFN4XOESJh4_=33LHQzt+p4V0Cy=Xzw@mail.gmail.com>
 <CAMuHMdWWsZ-vTGZCeLtcwLTuBYpeP0STfhrK37wiwmyfsQ798A@mail.gmail.com>
 <YD49x/UGUq6MSE39@alley> <8893ff08-1e50-316c-f632-cd37be1690d5@suse.cz>
 <CAMuHMdUB4DZxHo=j1+EsSsoGCdWmDO9mBo0cUtAH4OYHy3sBzw@mail.gmail.com>
 <20210302090811.620ae7d0@gandalf.local.home> <YD5LKqtSz5r1Xp7B@elver.google.com>
 <20210302143516.GY2723601@casper.infradead.org> <CANpmjNNMFtJvkVBhjpp=YqFb3ck8Q4Ak8nGtB21XMd9ds_APFA@mail.gmail.com>
 <CAMuHMdXAH9tVX9Fz2X3L4+e9DkdFoy1qhmEocY69DKJXBQjexQ@mail.gmail.com>
In-Reply-To: <CAMuHMdXAH9tVX9Fz2X3L4+e9DkdFoy1qhmEocY69DKJXBQjexQ@mail.gmail.com>
From:   Marco Elver <elver@google.com>
Date:   Tue, 2 Mar 2021 15:57:01 +0100
Message-ID: <CANpmjNP2Z7O-2GhsjiHtTFzHGEryQPGdjHN6EeGweLWZHq-u2Q@mail.gmail.com>
Subject: Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all
 addresses as unhashed
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Matthew Wilcox <willy@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Petr Mladek <pmladek@suse.com>, Timur Tabi <timur@kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        roman.fietze@magna.com, Kees Cook <keescook@chromium.org>,
        John Ogness <john.ogness@linutronix.de>,
        Akinobu Mita <akinobu.mita@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        Andrey Konovalov <andreyknvl@google.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Pavel Machek <pavel@ucw.cz>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux MM <linux-mm@kvack.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 2 Mar 2021 at 15:55, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Marco,
>
> On Tue, Mar 2, 2021 at 3:40 PM Marco Elver <elver@google.com> wrote:
> > On Tue, 2 Mar 2021 at 15:35, Matthew Wilcox <willy@infradead.org> wrote:
> > > On Tue, Mar 02, 2021 at 03:26:50PM +0100, Marco Elver wrote:
> > > > +static const char no_hash_pointers_warning[9][55] __initconst = {
> > > > +     "******************************************************",
> > > > +     "   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   ",
> > > > +     "                                                      ",
> > > > +     " This system shows unhashed kernel memory addresses   ",
> > > > +     " via the console, logs, and other interfaces. This    ",
> > > > +     " might reduce the security of your system.            ",
> > > > +     " If you see this message and you are not debugging    ",
> > > > +     " the kernel, report this immediately to your system   ",
> > > > +     " administrator!                                       ",
> > > > +};
> > > > +
> > > >  static int __init no_hash_pointers_enable(char *str)
> > > >  {
> > > > +     const int lines[] = { 0, 1, 2, 3, 4, 5, 2, 6, 7, 8, 2, 1, 0 };
> > > > +     int i;
> > > > +
> > > >       no_hash_pointers = true;
> > > >
> > > > -     pr_warn("**********************************************************\n");
> > > > -     pr_warn("**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n");
> > > > -     pr_warn("**                                                      **\n");
> > > > -     pr_warn("** This system shows unhashed kernel memory addresses   **\n");
> > > > -     pr_warn("** via the console, logs, and other interfaces. This    **\n");
> > > > -     pr_warn("** might reduce the security of your system.            **\n");
> > > > -     pr_warn("**                                                      **\n");
> > > > -     pr_warn("** If you see this message and you are not debugging    **\n");
> > > > -     pr_warn("** the kernel, report this immediately to your system   **\n");
> > > > -     pr_warn("** administrator!                                       **\n");
> > > > -     pr_warn("**                                                      **\n");
> > > > -     pr_warn("**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n");
> > > > -     pr_warn("**********************************************************\n");
> > > > +     for (i = 0; i < ARRAY_SIZE(lines); i++)
> > > > +             pr_warn("**%s**\n", no_hash_pointers_warning[lines[i]]);
> > >
> > > +       for (i = 0; i < 3; i++)
> > > +               pr_warn("**%s**\n", no_hash_pointers_warning[lines[2 - i]]);
> >
> > Yeah, I had that before, but then wanted to deal with the blank line
> > in the middle of the thing. So I just went with the lines array above,
> > which seemed cleanest for dealing with the middle blank line and
> > footer. Or maybe there's something even nicer I missed? :-)
>
> Gcc deduplicates the identical strings, so you don't have to go through
> a double indirection at all?

In this case I think we do, because we're asking the compiler to
create a giant array char[9][55]. If we had char*[9], then you're
right, but in that case we would not benefit from __initconst for the
majority of the data.

Thanks,
-- Marco