Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp960367pxb; Wed, 3 Mar 2021 22:35:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJwk1voZeLBs6Q8rNSCjLHFUXD7OQdMbYln3usxDA9y8oEaPbI8azj6vOCl8rRnYHu6peb/U X-Received: by 2002:a50:f9c8:: with SMTP id a8mr2722051edq.270.1614839755930; Wed, 03 Mar 2021 22:35:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614839755; cv=none; d=google.com; s=arc-20160816; b=A8KDJPdCo8mhTS7QW0Z7I6tp59ItK+/3RhcydjauWz1XICuKXrjjTyXP6tfoGxkxHd Xs9aCJZ9TQH17jZcT7cBlus+rofBOeXkODVH2CyFzr3z4GznWo0akrenlEbceXZD3lV4 ES6ocUHW/vMZvuRV7lYsXBtpbTd0cBSZcCz4TAVdk6exEiTcTJt8HkZo9mXKBDqX5exz sbdfbUbIVJ+7M6j0rkhBB93VIdMCNC9rDyXcP5mc5+j+oggK9J/TeDAw5joD5PyjExjO 6h6pLppGpnxzifEexcmqbjtr7RsU5GBxt53nfTxuNb1E74iTvn0AYrmLGV7z8bY9fTxN euqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=4oqm/8q5NM5LJ2woJXWQzlpCOA85F8dPXYwlBYkvDfo=; b=Hfhd3WF1H3ifWapTmTxV2vqYcZz9XYvhGm/ty2iJaVBwr+Qwk/8ZyYaO3tbKaCoM5Z zh5BY5G+6D8c0XMhO50++Zu7xq0jeNXI2K9vXJyNa3dN6rl+0/G327C/gZ8EONoN9aiQ Mha+7b2Tf42E7Y5s92uBJhL1hJPri6FRDb3gnZMmoGDiOdRTXSd7QWVuRRDkhM9desyo XbWa1YVJ8FBREG0AttXs+rQNUdAwyen4ItIbB4bRDMu/yaLOjbUWFRB+tdNyZmSN6gv9 HNE9XKbD6aBzcI2+vf0d0zwLHoaJnnAt/qLlm8TcU74Pfrkm8WNx6bD1oM7PcYkfN6Ue UXcg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb8si18607084edb.6.2021.03.03.22.35.33; Wed, 03 Mar 2021 22:35:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1835554AbhCBTRq (ORCPT + 99 others); Tue, 2 Mar 2021 14:17:46 -0500 Received: from mslow2.mail.gandi.net ([217.70.178.242]:46179 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1839621AbhCBQhe (ORCPT ); Tue, 2 Mar 2021 11:37:34 -0500 Received: from relay8-d.mail.gandi.net (unknown [217.70.183.201]) by mslow2.mail.gandi.net (Postfix) with ESMTP id CE2EA3B470D for ; Tue, 2 Mar 2021 16:34:41 +0000 (UTC) X-Originating-IP: 86.206.8.148 Received: from xps13.stephanxp.local (lfbn-tou-1-491-148.w86-206.abo.wanadoo.fr [86.206.8.148]) (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 94CF71BF208; Tue, 2 Mar 2021 16:32:13 +0000 (UTC) From: Miquel Raynal To: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= , f.fainelli@gmail.com, Brian Norris , Kamal Dasu , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] nand: brcmnand: fix OOB R/W with Hamming ECC Date: Tue, 2 Mar 2021 17:32:12 +0100 Message-Id: <20210302163212.23060-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210224080210.23686-1-noltari@gmail.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: 095b4dabff2a929cefd330110c5c578956213188 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2021-02-24 at 08:02:10 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > Hamming ECC doesn't cover the OOB data, so reading or writing OOB shall > always be done without ECC enabled. > This is a problem when adding JFFS2 cleanmarkers to erased blocks. If JFFS2 > clenmarkers are added to the OOB with ECC enabled, OOB bytes will be changed > from ff ff ff to 00 00 00, reporting incorrect ECC errors. > > Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller") > Signed-off-by: Álvaro Fernández Rojas > Acked-by: Brian Norris Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel