Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp960557pxb; Wed, 3 Mar 2021 22:36:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJwgxSpSXfWUIdYkdejNNzzPfH81pNZt6cwvs5gAQ+g8grdklQBughAGdizHye4A9cKzlaUt X-Received: by 2002:a17:906:311a:: with SMTP id 26mr2560148ejx.395.1614839779594; Wed, 03 Mar 2021 22:36:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614839779; cv=none; d=google.com; s=arc-20160816; b=NPkj9Ap0vBuh9eMn5PZj2+hvNb7a7fTXTPks92bGvAoJfEKicVCvL482tUJilijtxB frYs6YVBmsCw3X/efDlPZVyn6XRtx8nZC/nan0TUNtMR6WtgXrsoAaPQbs+46MfVtmis Jj0enPwKa3rWmoH/laqioC8P7qAGFB/AXGueEyCYevdjig3zmzi0faR7GLwWRheEG8i/ GQmTZodzgqWuRmVYW8uFdXRXzPXdVvawRgBUZa4owHNuOgfP0hDPHAEwWv7OnufQ0kJs vUYBhDRQGONDVAOrt+ot+6ruSyY1DS6+p01hvcVhsm8Z/hMl2Y9DbivE6qF8imLWIeu4 72Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=AGJOP12tupXeQzv6wdlSO3ZQYDh1j4tIYt4tuTAcn/U=; b=NYi2NIk0Yfiiug50J8mJ5JpBuFQU16bxKRwVJlv2cGA32cLTg6tK+CBzPGGgDbCZce KlvrPkqJ91K2lSk5I3Bbq8REydulWVLqErPRMqhKDYB/J9uFX6Ig6PQZZ+gaTipiZU33 nvqWqWp36wqRQ9UltrczVfiPU3wm4Yp8w5K6Ox/sDbmsquQh37m34RE8l2ZppG8BCVOJ EfSsRlaocmilCt0edTikWFrHNuh/txojJZoeigk6aYWt3AdSKN046zLG6BaxZibQqQkA RL1gusrfpdbhDQR3MX55xw50/e+XdOBrSoTNMZE29IsZvMRq+WfyoYkvDDgLHLiBdKtH saZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MkX36Ffr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gy11si3026520ejb.175.2021.03.03.22.35.56; Wed, 03 Mar 2021 22:36:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MkX36Ffr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1581193AbhCBSlH (ORCPT + 99 others); Tue, 2 Mar 2021 13:41:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240296AbhCBPpr (ORCPT ); Tue, 2 Mar 2021 10:45:47 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41B3CC061224 for ; Tue, 2 Mar 2021 07:45:23 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id n16so15049052lfb.4 for ; Tue, 02 Mar 2021 07:45:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AGJOP12tupXeQzv6wdlSO3ZQYDh1j4tIYt4tuTAcn/U=; b=MkX36FfrOg4u+MTeophtlKAX8UbmwTTdKjjFTorOoqGJtS+RrsUp/xOsSbzYKfT6J0 lpd/tM1pY1pKQ4ADeALiVtm7GQvcWENljUipa1UUjgYKEWe72q33io2NKiwFF4yd/G4A 0MUdf7of7eXnBDcf0W1ABzX6XzTtFruFrjKUOUTnjv0VfRuGE8HYt7lrXqEZ5dLtXthh TJunfeoVzeMHsaucK6DSGgwsCKunaF6prF7AjoMXnCQ4ciuSfedXkFdRfJFHTaMVLFwn 5Y/Q5j3yVdjbA+PaSIXQVlhBYeEBkqNw80IBz80d06KoulG79yzyIDIKLsqIKsybU/ZK j7WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AGJOP12tupXeQzv6wdlSO3ZQYDh1j4tIYt4tuTAcn/U=; b=kJxqlsBR3Z+n4DDzH5jglRUAA3XIjahWRRBH/xv4M5kfPw9TFxSRKCUnkKAXD86ZIr /jLalts25uF38rvpAb5QFnzOq82OellgTwEPquBMra+pUj/6dX19Mp3d4w3fjS3dnPDq MhbkdttjENQoYIPLzNGhchBN36LNDQnT4w8+fKJSBk4Vio87xbJnugcrXMZup+4j2zDd rlmWvC3qkUiDq5Pt9rb4LGIEOckBpmu7SV1Df4drWCr0Zv3wWCecn9NixRnDhCusnEIg zB1W4GnasgqGH81L4/rwOyMC64dRyaq4YLkqYNQfRprz05xUcCbkkA6AZ/MNXs9CP3Sq 0Qyg== X-Gm-Message-State: AOAM531NVFjQt5BGdfLvMr1xAX1pg1+2nKm2M3LNZgzUFNSEDqyeuQxM mKQtpm1W+qdj+k5IxOsYrXEcPjfP6/0DqsrIsCFYFw== X-Received: by 2002:a19:6b13:: with SMTP id d19mr12421144lfa.291.1614699921790; Tue, 02 Mar 2021 07:45:21 -0800 (PST) MIME-Version: 1.0 References: <20210301080421.13436-1-dinghao.liu@zju.edu.cn> In-Reply-To: <20210301080421.13436-1-dinghao.liu@zju.edu.cn> From: Linus Walleij Date: Tue, 2 Mar 2021 16:45:10 +0100 Message-ID: Subject: Re: [PATCH] iio: gyro: mpu3050: Fix error handling in mpu3050_trigger_handler To: Dinghao Liu Cc: Kangjie Lu , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 1, 2021 at 9:04 AM Dinghao Liu wrote: > There is one regmap_bulk_read() call in mpu3050_trigger_handler > that we have caught its return value bug lack further handling. > Check and terminate the execution flow just like the other three > regmap_bulk_read() calls in this function. > > Signed-off-by: Dinghao Liu OK that makes sense. Reviewed-by: Linus Walleij Yours, Linus Walleij