Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161054AbWI2P6J (ORCPT ); Fri, 29 Sep 2006 11:58:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932311AbWI2P6J (ORCPT ); Fri, 29 Sep 2006 11:58:09 -0400 Received: from graphe.net ([209.204.138.32]:39066 "EHLO graphe.net") by vger.kernel.org with ESMTP id S932305AbWI2P6H (ORCPT ); Fri, 29 Sep 2006 11:58:07 -0400 Date: Fri, 29 Sep 2006 08:58:02 -0700 (PDT) From: Christoph Lameter X-X-Sender: christoph@graphe.net To: Pekka J Enberg cc: akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] slab: reduce numa text size In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Score: -2.4 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 573 Lines: 16 On Fri, 29 Sep 2006, Pekka J Enberg wrote: > This patch reduces NUMA text size of mm/slab.o a little on x86 by using > a local variable to store the result of numa_node_id(). Looks okay. The convention for this local variable is to use simply "node" not "thisnode". See other optimizations like that in the slab allocator. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/