Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nitin Gupta <nigupta@nvidia.com>
To:     Pintu Kumar <pintu@codeaurora.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
        "sh_def@163.com" <sh_def@163.com>,
        "mateusznosek0@gmail.com" <mateusznosek0@gmail.com>,
        "bhe@redhat.com" <bhe@redhat.com>,
        "vbabka@suse.cz" <vbabka@suse.cz>,
        "yzaikin@google.com" <yzaikin@google.com>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "mcgrof@kernel.org" <mcgrof@kernel.org>,
        "mgorman@techsingularity.net" <mgorman@techsingularity.net>
CC:     "pintu.ping@gmail.com" <pintu.ping@gmail.com>
Subject: RE: [PATCH] mm/compaction: remove unused variable
 sysctl_compact_memory
Thread-Topic: [PATCH] mm/compaction: remove unused variable
 sysctl_compact_memory
Thread-Index: AQHXD411mHVMaaygcESwzSP7eEOUu6pxIlMg
Date:   Tue, 2 Mar 2021 20:18:01 +0000
Message-ID: <BYAPR12MB3416C9FD5D10AFB930E1C023D8999@BYAPR12MB3416.namprd12.prod.outlook.com>
References: <1614707773-10725-1-git-send-email-pintu@codeaurora.org>
In-Reply-To: <1614707773-10725-1-git-send-email-pintu@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e8d5048-0c24-4ce8-f3da-08d8ddb847bb
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2021 20:18:01.9306
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SMz9dUP0xP2lKWr44FUTraD4Ap+7yvjO+DlCw3E0x4Gjv2pLUWN/KYJRaZ8ppck3ZwuySSQ5F2THyNUeew5uRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4323
X-OriginatorOrg: Nvidia.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1614716283; bh=fRKWLWO157z6pwj7FpiXPV7XIhe0xiseYJqYfaznWo8=;
        h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:
         CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:
         In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach:
         X-MS-TNEF-Correlator:authentication-results:x-originating-ip:
         x-ms-publictraffictype:x-ms-office365-filtering-correlation-id:
         x-ms-traffictypediagnostic:x-microsoft-antispam-prvs:x-header:
         x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck:
         x-microsoft-antispam:x-microsoft-antispam-message-info:
         x-forefront-antispam-report:x-ms-exchange-antispam-messagedata:
         x-ms-exchange-transport-forked:Content-Type:
         Content-Transfer-Encoding:MIME-Version:
         X-MS-Exchange-CrossTenant-AuthAs:
         X-MS-Exchange-CrossTenant-AuthSource:
         X-MS-Exchange-CrossTenant-Network-Message-Id:
         X-MS-Exchange-CrossTenant-originalarrivaltime:
         X-MS-Exchange-CrossTenant-fromentityheader:
         X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
         X-MS-Exchange-CrossTenant-userprincipalname:
         X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg;
        b=Nx7tfkfMZ9BAO0iRZfpUaha0UIbMqZQsjNocFpj5092aoMFP1EMg/TGlR74UryI05
         DmIQLtWeCz8gS1Q/wmNoT/6XHt6Nk3he0Iip7kO5QIXiMJK1uC5LFt5Rgq+L3MJQYm
         sfm01MWawlbsr4CWy/trE+8je5Dr9MR0V7IDk6DuNxW3pC3W0+sAfzC9rpm2eW3PX5
         GlJlAy8PnXx8y7KOJi8kpzc7xiKZl9FBvs5L76gIWIB3Ain+JnAc/If1MggwkaElYA
         /6ZHyXsPfk1XMp/1YFV6bJnF5dV+coI+KTSnoi95xN5F+IuB25qFg5923p/sDxrlAv
         j4UlyeC5cAfhw==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: pintu=3Dcodeaurora.org@mg.codeaurora.org
> <pintu=3Dcodeaurora.org@mg.codeaurora.org> On Behalf Of Pintu Kumar
> Sent: Tuesday, March 2, 2021 9:56 AM
> To: linux-kernel@vger.kernel.org; akpm@linux-foundation.org; linux-
> mm@kvack.org; linux-fsdevel@vger.kernel.org; pintu@codeaurora.org;
> iamjoonsoo.kim@lge.com; sh_def@163.com; mateusznosek0@gmail.com;
> bhe@redhat.com; Nitin Gupta <nigupta@nvidia.com>; vbabka@suse.cz;
> yzaikin@google.com; keescook@chromium.org; mcgrof@kernel.org;
> mgorman@techsingularity.net
> Cc: pintu.ping@gmail.com
> Subject: [PATCH] mm/compaction: remove unused variable
> sysctl_compact_memory
>=20
> External email: Use caution opening links or attachments
>=20
>=20
> The sysctl_compact_memory is mostly unsed in mm/compaction.c It just acts
> as a place holder for sysctl.
>=20
> Thus we can remove it from here and move the declaration directly in
> kernel/sysctl.c itself.
> This will also eliminate the extern declaration from header file.


I prefer keeping the existing pattern of listing all compaction related tun=
ables
together in compaction.h:

	extern int sysctl_compact_memory;
	extern unsigned int sysctl_compaction_proactiveness;
	extern int sysctl_extfrag_threshold;
	extern int sysctl_compact_unevictable_allowed;


> No functionality is broken or changed this way.
>=20
> Signed-off-by: Pintu Kumar <pintu@codeaurora.org>
> Signed-off-by: Pintu Agarwal <pintu.ping@gmail.com>
> ---
>  include/linux/compaction.h | 1 -
>  kernel/sysctl.c            | 1 +
>  mm/compaction.c            | 3 ---
>  3 files changed, 1 insertion(+), 4 deletions(-)
>=20
> diff --git a/include/linux/compaction.h b/include/linux/compaction.h inde=
x
> ed4070e..4221888 100644
> --- a/include/linux/compaction.h
> +++ b/include/linux/compaction.h
> @@ -81,7 +81,6 @@ static inline unsigned long compact_gap(unsigned int
> order)  }
>=20
>  #ifdef CONFIG_COMPACTION
> -extern int sysctl_compact_memory;
>  extern unsigned int sysctl_compaction_proactiveness;  extern int
> sysctl_compaction_handler(struct ctl_table *table, int write,
>                         void *buffer, size_t *length, loff_t *ppos); diff=
 --git
> a/kernel/sysctl.c b/kernel/sysctl.c index c9fbdd8..66aff21 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -198,6 +198,7 @@ static int max_sched_tunable_scaling =3D
> SCHED_TUNABLESCALING_END-1;  #ifdef CONFIG_COMPACTION  static int
> min_extfrag_threshold;  static int max_extfrag_threshold =3D 1000;
> +static int sysctl_compact_memory;
>  #endif
>=20
>  #endif /* CONFIG_SYSCTL */
> diff --git a/mm/compaction.c b/mm/compaction.c index 190ccda..ede2886
> 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -2650,9 +2650,6 @@ static void compact_nodes(void)
>                 compact_node(nid);
>  }
>=20
> -/* The written value is actually unused, all memory is compacted */ -int
> sysctl_compact_memory;
> -


Please retain this comment for the tunable.

-Nitin