Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161821AbWI2RHO (ORCPT ); Fri, 29 Sep 2006 13:07:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161824AbWI2RHM (ORCPT ); Fri, 29 Sep 2006 13:07:12 -0400 Received: from emailer.gwdg.de ([134.76.10.24]:17812 "EHLO emailer.gwdg.de") by vger.kernel.org with ESMTP id S1161529AbWI2RHJ (ORCPT ); Fri, 29 Sep 2006 13:07:09 -0400 Date: Fri, 29 Sep 2006 19:06:21 +0200 (MEST) From: Jan Engelhardt To: girish cc: linux-kernel@vger.kernel.org, William Pitcock Subject: Re: [PATCH] include children count, in Threads: field present in /proc//status (take-1) In-Reply-To: Message-ID: References: <0635847A-C149-412C-92B1-A974230381F8@dts.local>

MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Report: Content analysis: 0.0 points, 6.0 required _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 740 Lines: 22 >> > >> > - buffer += sprintf(buffer, "Threads:\t%d\n", num_threads); >> > + buffer += sprintf(buffer, "Threads:\t%d\n", num_threads + >> > num_children); >> >> Personally, I'd prefer the children count to be separate, something like: >> >> buffer += sprintf(buffer, "Threads:\t%d (%d children, %d total)", >> num_threads, num_children, num_threads + num_children); >> >> That would be rather nice, indeed. And I would suggest three separate lines to keep it parseable! Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/