Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp982426pxb; Wed, 3 Mar 2021 23:25:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxDB4tlGi6Df2FvklMyGHLErmqro3Xe7q3r4cpO7iO9a8WpvfxT9wW4YdZWX3cuK3mgO7AN X-Received: by 2002:aa7:d0c2:: with SMTP id u2mr854055edo.158.1614842747613; Wed, 03 Mar 2021 23:25:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614842747; cv=none; d=google.com; s=arc-20160816; b=CPBotXWOM6TsjMHdvmWNJuA/OjdajAa5vAS7lOGfyl1EUviw+qufoTi68bArISABsF HEboKDd7TCI0XO9mPrc0YOkC0yzogdvw0hZgQrtL2VNy+njel/FOVZUgsOYswknasxlv K2Txxt3lMj7rLyH12NagYHQVuRzD31lpCb6a/kL5D7QuU6jTB9ORsLX2JDVjSbcDp+T9 56W9CRS/HPJmh0G0r2efHLeRf5b9i4/hNRL7YhnjFURFgazpdihsdklVRnfzgsUuAQhA m1DTPHfpNWQ0oDq3y7AQgsYAnJDqO8XQOtDT4CU8DTSQKJV8MEti5tEURcl0usAuW2t4 OnSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:bimi-selector :from:references:cc:to:subject:dkim-signature:dkim-filter; bh=+MVoVMUVm8capWlNcUWJStxtBvOtui4ewlEULmYwlXE=; b=BDwA9kzFOJQedTmtyZ9UWJt8Gxf6oPiFa9oiCPnrXBPyRiddk/TgfWdtAmci7c1f3B FrgJokghsvFMTNO6knI8k58NX66EppDxx5POPLkBQAE/tMUAR/rkcrgRw2DzscxEqz82 CZB88AfzKsoF73Y6OedQtdbUv2GnOQsmHndZHOwbOqUnxx1p1DVBRmCzamVhRPNfi6CB S9+CcaJHXVNeUS1luGLfkSxZUGD4ReLSQDYR/50GcsbNbUKzbWSHlN/xjP6gt5bR283S nuG+A0Zdh4sJRZSanKUSn2CJ6hSZzzyBuJNqEjgZHc2RUPucC4xq/XTeOTt97fs9j5EU 0K+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@petrovitsch.priv.at header.s=default header.b=fS0wk1Xm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=petrovitsch.priv.at Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si8238788edp.540.2021.03.03.23.25.25; Wed, 03 Mar 2021 23:25:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@petrovitsch.priv.at header.s=default header.b=fS0wk1Xm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=petrovitsch.priv.at Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2360972AbhCBXIi (ORCPT + 99 others); Tue, 2 Mar 2021 18:08:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1575621AbhCBWrv (ORCPT ); Tue, 2 Mar 2021 17:47:51 -0500 X-Greylist: delayed 1686 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 02 Mar 2021 14:47:09 PST Received: from esgaroth.petrovitsch.at (unknown [IPv6:2a01:4f8:120:527b:6876:2a4f:a044:62ad]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFB1CC061756; Tue, 2 Mar 2021 14:47:09 -0800 (PST) Received: from thorin.petrovitsch.priv.at (80-110-91-187.cgn.dynamic.surfer.at [80.110.91.187]) (authenticated bits=0) by esgaroth.petrovitsch.at (8.16.1/8.16.1) with ESMTPSA id 122MIGmL914592 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT); Tue, 2 Mar 2021 23:18:16 +0100 DKIM-Filter: OpenDKIM Filter v2.11.0 esgaroth.petrovitsch.at 122MIGmL914592 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petrovitsch.priv.at; s=default; t=1614723497; bh=+MVoVMUVm8capWlNcUWJStxtBvOtui4ewlEULmYwlXE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=fS0wk1Xm132rltWm/1oyGznxEdWPToAqz2hoNZC11FcfHkqVTyx9yXdHBtk/KQgYu CUW9zFrgfDiXTM+mo+IlrHMlPPr9NFHKgyMAaMTebilLaUnd2681oIcofQtw1oWtZW WSq3taGbZHYFOVrfZvd+8Y37Sy4pPgxmVrownKX4= X-Info-sendmail: I was here Subject: Re: linux-kernel janitorial RFP: Mark static arrays as const To: Joe Perches Cc: LKML , kernelnewbies , kernel-janitors , cocci References: <053b06c47f08631675c295b5c893b90be4248347.camel@perches.com> From: Bernd Petrovitsch Bimi-Selector: v=BIMI1; s=default Message-ID: <22d22edd-4213-0f57-d801-1c570f04ec05@petrovitsch.priv.at> Date: Tue, 2 Mar 2021 23:18:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <053b06c47f08631675c295b5c893b90be4248347.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-DCC-x.dcc-servers-Metrics: esgaroth.petrovitsch.priv.at 104; Body=5 Fuz1=5 Fuz2=5 X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from * author's domain * -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from * envelope-from domain * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.0 NICE_REPLY_A Looks like a legit reply (A) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on esgaroth.petrovitsch.priv.at Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all! On 02/03/2021 18:42, Joe Perches wrote: [...] > ------------- For instance: (head -10 of the git grep for file statics) > > drivers/accessibility/speakup/keyhelp.c:18:static u_short masks[] = { 32, 16, 8, 4, 2, 1 }; > drivers/accessibility/speakup/keyhelp.c:26:static u_char funcvals[] = { > drivers/accessibility/speakup/main.c:2059:static spkup_hand spkup_handler[] = { > drivers/accessibility/speakup/speakup_acntpc.c:35:static unsigned int synth_portlist[] = { 0x2a8, 0 }; > drivers/accessibility/speakup/speakup_decpc.c:133:static int synth_portlist[] = { 0x340, 0x350, 0x240, 0x250, 0 }; > drivers/accessibility/speakup/speakup_dectlk.c:110:static int ap_defaults[] = {122, 89, 155, 110, 208, 240, 200, 106, 306}; > drivers/accessibility/speakup/speakup_dectlk.c:111:static int g5_defaults[] = {86, 81, 86, 84, 81, 80, 83, 83, 73}; > drivers/accessibility/speakup/speakup_dtlk.c:34:static unsigned int synth_portlist[] = { > drivers/accessibility/speakup/speakup_keypc.c:34:static unsigned int synth_portlist[] = { 0x2a8, 0 }; > drivers/acpi/ac.c:137:static enum power_supply_property ac_props[] = { > > For drivers/accessibility/speakup/keyhelp.c:18:static u_short masks[] = { 32, 16, 8, 4, 2, 1 }; Looking at the examples: Just s/^static /static const / in the lines reported by the grep's above and see if it compiles (and save space)? MfG, Bernd -- Bernd Petrovitsch Email : bernd@petrovitsch.priv.at There is NO CLOUD, just other people's computers. - FSFE LUGA : http://www.luga.at