Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp990243pxb; Wed, 3 Mar 2021 23:43:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJwUiu1MujoEXa+rCS+x1maaeIfgd1W2wKtyCzcGl9Cw9nkWAaOIriTUh2PtBQ80OBLfEK2a X-Received: by 2002:a17:906:3acc:: with SMTP id z12mr2879854ejd.494.1614843838462; Wed, 03 Mar 2021 23:43:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614843838; cv=none; d=google.com; s=arc-20160816; b=whFQD423xrxZP/gV7hqCK6rsj54Regv4MsTyeqINmAXzRZZa1rxXdrVkBL4wGx+gD6 VuuF1yQEs9m6UNP4X3+hG6U6OTzTQ4k7FadEh6ZH3+VBr6qAfKbc7eNjGl6tegBpaP4y dMwjuCujgsCufoI6RQHfWxkh92oLRNJ16uMaU9tnhmiULO2evLuyPMjzLNyzHCg6jHTY QidsNqryX1JYIHuJNR0y9Qi2TzuR/yyKu4osMmx4X10Q96OHwcAARbkTCe+mA+PCN8Ti J0gqDjniZtRa22JeY86rtHVXUk2IzckJgL5IOsWQcQhClpehsgr263t3fl/NQqNsptqM KkPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LS4d4uUxDq7yhtpjLQE7kDOpsO4KYhMcEce+00T9U+s=; b=nDvHDl4jRhXqMFUdPNYP6XoZw1PtlCjHSQt8ZZBytCuc4rJptEDnUkyah81iW9mVu6 Gtj1D5RjDAM2IEyCHiu9cd+vKNClCf5jZpfanOHwXedh2j6VWTbXtmZPgEueuotMChaU 5oKUkbVnDukI8aReOwRKSk+gSF+JIPYufVKpHvR2JBecGqlrGLhQ49LkxyMesJBE7ph4 d1AntlNuSlnLpUHNp7M/TIuvmWt5E5igeBi1A28CAWP+LEdQSrAlPtnzHQ5KKyOUC0V3 tiRpL/qmYXthjSA5gt7rGzCcHumSqig7ROOuebWrVbfR4xsEx3jMbJShRvReuc8xvBZx y2Sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=b2YvmtWc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a20si16200096ejg.257.2021.03.03.23.43.36; Wed, 03 Mar 2021 23:43:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=b2YvmtWc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357381AbhCCKti (ORCPT + 99 others); Wed, 3 Mar 2021 05:49:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234085AbhCBX4L (ORCPT ); Tue, 2 Mar 2021 18:56:11 -0500 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5ED5C061788 for ; Tue, 2 Mar 2021 15:47:16 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id u4so26278491ljh.6 for ; Tue, 02 Mar 2021 15:47:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LS4d4uUxDq7yhtpjLQE7kDOpsO4KYhMcEce+00T9U+s=; b=b2YvmtWceuUdn6lRyC69kZzsj1GrBVdKv/s37uBMpqnrZeFSFFX3v7i6xMxDXM0DR1 3S5dN2pEfvAef3sPnfgVkmEU3K7V/vJq9ZpXQW43ps/9hu1KxRmJiYKJ3P1wDPufQdln b482GFvnPEz8YRgub0ODGDSMeNZWts5Z1KBKxazzoxwhkFFIIEr49PX7KisrzY4L8d29 2DF1zgd6B1P/twHqi/XfuHR3dUcQjsFZdjpD7PTqTJty0smvB+kLU1cs4/8RagQVII2S lJGjneBExfZnY4mmoqynG7aZlywjm/znyxLx4Ppbl/Pkv8lbwfth9qPpS4zT1fvo0/eU bkVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LS4d4uUxDq7yhtpjLQE7kDOpsO4KYhMcEce+00T9U+s=; b=Jl4pMd1T0yLvMY68VvRMQoek5+CGgBfRvH48kagZ5mPX4x3jyqzzh8V75Hk+U8jOf9 9mAFR6ZsN7//Y3q7nKaI0tbH8ofk7d7gCDPY/f7Xv6tUeeNktwUP54a1AJTU+9+uez0q idobO9NX1cevpQlm65XUR3/W23TgjuBk6vC8sArkKpl7kxDKWctfY/kKB3VVv6RoP+3v flrCk4C7PpC+OTi8lKln3HUpE0ianLbyYHGsnQkBMVB5FekXhO3hvFqbsv3y/NNeTL5E hcPshXQNAl6qB2Zk0ugjNcLlT3947r2hhEjwOA5AiEE+t8KMmcAjsy0XLFqSy9WY04qs xIzQ== X-Gm-Message-State: AOAM533qDrJOZdpxNdkXEDTB5e4kzIbASWoTrnHfi6UgMnPKuXgXzqc8 4LV0Fh3Tx7ZVaEQROBaXzIE= X-Received: by 2002:a2e:3c13:: with SMTP id j19mr13431079lja.130.1614728835186; Tue, 02 Mar 2021 15:47:15 -0800 (PST) Received: from localhost.localdomain (h-98-128-229-129.NA.cust.bahnhof.se. [98.128.229.129]) by smtp.gmail.com with ESMTPSA id j15sm1974359lfm.138.2021.03.02.15.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 15:47:14 -0800 (PST) From: Rikard Falkeborn To: Lee Jones Cc: Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rikard Falkeborn , Andy Shevchenko Subject: [PATCH] mfd: stmpe: Revert "Constify static struct resource" Date: Wed, 3 Mar 2021 00:47:10 +0100 Message-Id: <20210302234710.74455-1-rikard.falkeborn@gmail.com> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy noted that constification of some static resource structs in intel_quark_i2c_gpio.c were incorrect. It turns out there is another change from the same series that is also incorrect in stmpe.c. These structures are modified at init and can not be made const. This reverts commit 8d7b3a6dac4eae22c58b0853696cbd256966741b. Fixes: 8d7b3a6dac4e ("mfd: stmpe: Constify static struct resource") Cc: Andy Shevchenko Signed-off-by: Rikard Falkeborn --- I went through the series and this was the only additional issue I found. Sorry about that. drivers/mfd/stmpe.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c index 90f3292230c9..1aee3b3253fc 100644 --- a/drivers/mfd/stmpe.c +++ b/drivers/mfd/stmpe.c @@ -312,7 +312,7 @@ EXPORT_SYMBOL_GPL(stmpe_set_altfunc); * GPIO (all variants) */ -static const struct resource stmpe_gpio_resources[] = { +static struct resource stmpe_gpio_resources[] = { /* Start and end filled dynamically */ { .flags = IORESOURCE_IRQ, @@ -336,7 +336,7 @@ static const struct mfd_cell stmpe_gpio_cell_noirq = { * Keypad (1601, 2401, 2403) */ -static const struct resource stmpe_keypad_resources[] = { +static struct resource stmpe_keypad_resources[] = { { .name = "KEYPAD", .flags = IORESOURCE_IRQ, @@ -357,7 +357,7 @@ static const struct mfd_cell stmpe_keypad_cell = { /* * PWM (1601, 2401, 2403) */ -static const struct resource stmpe_pwm_resources[] = { +static struct resource stmpe_pwm_resources[] = { { .name = "PWM0", .flags = IORESOURCE_IRQ, @@ -445,7 +445,7 @@ static struct stmpe_variant_info stmpe801_noirq = { * Touchscreen (STMPE811 or STMPE610) */ -static const struct resource stmpe_ts_resources[] = { +static struct resource stmpe_ts_resources[] = { { .name = "TOUCH_DET", .flags = IORESOURCE_IRQ, @@ -467,7 +467,7 @@ static const struct mfd_cell stmpe_ts_cell = { * ADC (STMPE811) */ -static const struct resource stmpe_adc_resources[] = { +static struct resource stmpe_adc_resources[] = { { .name = "STMPE_TEMP_SENS", .flags = IORESOURCE_IRQ, -- 2.30.1