Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp993711pxb;
        Wed, 3 Mar 2021 23:52:14 -0800 (PST)
X-Google-Smtp-Source: ABdhPJw0cGfqN0+DxS+JYLPeP2hjBcpkPNlpwTPCS38Nn2temRiw9wJohhoP10KGfpT4cilr68vj
X-Received: by 2002:a17:906:874f:: with SMTP id hj15mr2806412ejb.404.1614844334441;
        Wed, 03 Mar 2021 23:52:14 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1614844334; cv=none;
        d=google.com; s=arc-20160816;
        b=PiTD+MTKaqrMYvhalvm7LmwBI9dgMnwtca+6Kuzb2dA/q9P8xNKM0XOO6s/+Jt9GlT
         tW0CMhblIwCnRXq2VeymAAz1zQLKWCHzt8GX0ehcsHyMAluxuYMZd2+cObtXDe2VWMCN
         d6t8ilq/qb4hIZyqx9ECHeItqnsHqqIoW4CldJ26mlmjQTdhwG65hUgtiak5GlvZK3HL
         6kIZstx/UYbQa55dkJqZhk01RG+8XRs3oendJRsTtFuX0nEQ0+PMs1UZbC5Kv1EcO0QS
         6nUz4GxpcA/aeqg5d7OAddHCP/apKcw1hF/UeLH80ChcygKIPInJX7okdWR80lfaGs8N
         hr7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=BDh207ZAqrr3mS94Pdy26gF2+LAmCf2Xc5f+sP/CPsk=;
        b=N3hvZRTdDw4oz7n53pYvDLXNt3fU53vnci2FUVZQcYyKssVAJtnkXiJ9D4kkuiRHGx
         msuUdPXmxxvVt1CljTTSAx5lV6UOFDcB6gRsNQ+GTHVt+E+RFqfzhvS2WtEVn+4Xyo7v
         baJhdACDaQhAKgKY48uoESofl63Gzi57AW5/46Ei41b5DJLd8dQKIyMqkUqJHsHTwpZs
         jDLsAGpYiObkVAQyvQjkd26KYJdQIHJ9pAy4SM9z2gBgT+FDimaGL6Dy1XynlBJS0UJk
         Ut11fUus8lGguOVJLPXGnLEyyjoQTckQAsTcgIHCHaoP2TRJR5UDQk8f3P1L2T/Lcmlz
         DleQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linux-foundation.org header.s=korg header.b=j1eg14xJ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id ks7si8846312ejb.682.2021.03.03.23.51.52;
        Wed, 03 Mar 2021 23:52:14 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linux-foundation.org header.s=korg header.b=j1eg14xJ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1344883AbhCCK6E (ORCPT <rfc822;luxiaolong211@gmail.com>
        + 99 others); Wed, 3 Mar 2021 05:58:04 -0500
Received: from mail.kernel.org ([198.145.29.99]:45940 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S239582AbhCCAf2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 Mar 2021 19:35:28 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id E634F64FB0;
        Wed,  3 Mar 2021 00:34:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
        s=korg; t=1614731681;
        bh=BDh207ZAqrr3mS94Pdy26gF2+LAmCf2Xc5f+sP/CPsk=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=j1eg14xJMPcr8O/WYQ/yKD3+Rm3DwE7O8/dSYN6YQs68j0we6d4KL/3jEX4QoupBq
         kq9odd0NYYrqCJJtZiuSiYKODHPMMpUuOOtFwqCJm0mFiD09QJBcrvtf6O159+C35Z
         Luj7zSyFN5V5FBprfgoOEdPL0hqz7+otOXhVHVH8=
Date:   Tue, 2 Mar 2021 16:34:40 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Phillip Lougher <phillip@squashfs.org.uk>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Squashfs: fix xattr id and id lookup sanity checks
Message-Id: <20210302163440.730a51442f9ce87d728c9ffd@linux-foundation.org>
In-Reply-To: <2069685113.2081245.1614583677427@webmail.123-reg.co.uk>
References: <2069685113.2081245.1614583677427@webmail.123-reg.co.uk>
X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 1 Mar 2021 07:27:57 +0000 (GMT) Phillip Lougher <phillip@squashfs.org.uk> wrote:

> The checks for maximum metadata block size is
> missing SQUASHFS_BLOCK_OFFSET (the two byte length
> count).

What are the user visible consequences of this bug?

> Cc: stable@vger.kernel.org
> Signed-off-by: Phillip Lougher <phillip@squashfs.org.uk>

Fixes: f37aa4c7366e23f ("squashfs: add more sanity checks in id lookup")

yes?