Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Mar 2021 00:58:38 +0000 (GMT)
From:   Phillip Lougher <phillip@squashfs.org.uk>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Message-ID: <2145953354.2456187.1614733122707@webmail.123-reg.co.uk>
In-Reply-To: <20210302163440.730a51442f9ce87d728c9ffd@linux-foundation.org>
References: <2069685113.2081245.1614583677427@webmail.123-reg.co.uk>
 <20210302163440.730a51442f9ce87d728c9ffd@linux-foundation.org>
Subject: Re: [PATCH] Squashfs: fix xattr id and id lookup sanity checks
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Importance: Normal
Precedence: bulk


> On 03/03/2021 00:34 Andrew Morton <akpm@linux-foundation.org> wrote:
> 
>  
> On Mon, 1 Mar 2021 07:27:57 +0000 (GMT) Phillip Lougher <phillip@squashfs.org.uk> wrote:
> 
> > The checks for maximum metadata block size is
> > missing SQUASHFS_BLOCK_OFFSET (the two byte length
> > count).
> 
> What are the user visible consequences of this bug?

The user will be unable to mount the filesystem, because it will
fail the sanity check.


> 
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Phillip Lougher <phillip@squashfs.org.uk>
> 
> Fixes: f37aa4c7366e23f ("squashfs: add more sanity checks in id lookup")
> 
> yes?

Yes.

Phillip