Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1008579pxb; Thu, 4 Mar 2021 00:20:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJx/5iWA1h8t9YkYTKs/MfVz4w6tJrqz004znuh6/ooSzCW9FL/frKqY8elovPMylnC429Jp X-Received: by 2002:a17:906:3750:: with SMTP id e16mr2959198ejc.75.1614846057790; Thu, 04 Mar 2021 00:20:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614846057; cv=none; d=google.com; s=arc-20160816; b=eMcEdX11J1onGimdBjwfrs1nvOOGuAIDXuHxuYUxpZNZ2dapzEt35DZBuqY2jc2nuG MBj23dAF100lw8BVzQvxDFQ//GYQG8GJr6z8ODze1/3j1t7auL6yCs6EAf2nutH/4qPO 2IVz1XgVCJOXQ5h+DtpApmGPAYA2nKGdPARUvjoqd1wl7zynPps4Ku/urlQ3NlHCuN6X qLTEkRT1WUpRLhnuM8mmKC/+ySL46dbIP5G2YVUUzJym6RUj8jx2KCUSgBhI7cZ76PCK xPYz6qPNvQtcl69E+D7EcO/sHOOOQs7gP3VV5yaCZixh1l/Ria192BmPDb1vh+mWUfte PoNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=zFGuXX+NGfo/hcO8VwfJOyvFpsBk413U+O9FZyo7Z5c=; b=GCuchxft9wQ2B2dpvfaYodKVThVbi9DnWUSiTSSXzKrzBYXBLRl6A/O8iqhTb9kiQM QAjGNNEJqjawEE2M86Ntjj/MlvT7fDcZbgAXZ4iLXlH1oEKeRfwkFST5R2MsMjnOYgUw UJA4L8j5QRd8CK2JCgA+VZuJbt9R2LrNcVXpRPg3FfPFl4EnFERdPJTrCscwQBdcJN5l vPAJy9SZfhLPXQkVMT5cUcVk/YJX8f3kdrET+9IUbswufa28qVaS1HHoJjlzRQzabJ2n 8dGkvvgr1yo3XpmrvzZ3SBa4shFzCWXYzfBhhsFsHP0NmmQfwHEPKdw4+5oJYMUZSaYA Cbfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nic.cz Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e11si5125173edj.230.2021.03.04.00.20.34; Thu, 04 Mar 2021 00:20:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nic.cz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350128AbhCCLtz (ORCPT + 99 others); Wed, 3 Mar 2021 06:49:55 -0500 Received: from mail.nic.cz ([217.31.204.67]:42870 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1840788AbhCCEc5 (ORCPT ); Tue, 2 Mar 2021 23:32:57 -0500 Received: from localhost (unknown [IPv6:2a0e:b107:ae1:0:3e97:eff:fe61:c680]) by mail.nic.cz (Postfix) with ESMTPSA id 44A0613FFCC; Wed, 3 Mar 2021 05:32:15 +0100 (CET) Date: Wed, 3 Mar 2021 05:32:14 +0100 From: Marek Behun To: Antoni Przybylik Cc: pavel@ucw.cz, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Leds: made enum led_brightness into typedef Message-ID: <20210303053214.7a3fbaeb@nic.cz> In-Reply-To: <20210302230459.523410-1-antoni.przybylik@wp.pl> References: <20210302230459.523410-1-antoni.przybylik@wp.pl> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-100.0 required=5.9 tests=SHORTCIRCUIT, USER_IN_WELCOMELIST,USER_IN_WHITELIST shortcircuit=ham autolearn=disabled version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.nic.cz X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch touches only code in drivers/leds and include/linux/leds.h. Meanwhile enum led_brightness is used in many other parts of kernel as well, just try git grep "enum led_brightness" Also changing it probably to a simple int would be better. But if we wanted a typedef anyway, it should be called led_brightness_t. Marek