Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1161348AbWI2SNa@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161348AbWI2SNa (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 29 Sep 2006 14:13:30 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161323AbWI2SNa
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 29 Sep 2006 14:13:30 -0400
Received: from emailer.gwdg.de ([134.76.10.24]:34226 "EHLO emailer.gwdg.de")
	by vger.kernel.org with ESMTP id S1161348AbWI2SN3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Sep 2006 14:13:29 -0400
Date: Fri, 29 Sep 2006 20:12:02 +0200 (MEST)
From: Jan Engelhardt <jengelh@linux01.gwdg.de>
To: girish <girishvg@gmail.com>
cc: linux-kernel@vger.kernel.org, William Pitcock <nenolod@atheme.org>
Subject: Re: [PATCH] include children count, in Threads: field present in
 /proc/<pid>/status (take-1)
In-Reply-To: <CF74CE5D-42A1-4FF9-8C9B-682C5D6DEAE1@gmail.com>
Message-ID: <Pine.LNX.4.61.0609292011190.634@yvahk01.tjqt.qr>
References: <0635847A-C149-412C-92B1-A974230381F8@dts.local>
 <F2F2C98F-6AFB-4E19-BEE9-D32652E2F478@atheme.org> <EE7C757E-E2CE-4617-A1D4-3B8F5E3E8240@gmail.com>
 <Pine.LNX.4.61.0609291905550.27518@yvahk01.tjqt.qr>
 <CF74CE5D-42A1-4FF9-8C9B-682C5D6DEAE1@gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Spam-Report: Content analysis: 0.0 points, 6.0 required
	_SUMMARY_
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 788
Lines: 27

>
> How about this?
>
> buffer += sprintf(buffer, "Threads:\t%d", num_threads);
> if (num_children)
>                buffer += sprintf(buffer, " Children: %d Total: %d",
> num_children, num_threads + num_children);
> buffer += sprintf(buffer, "\n");
>

No, this:

> if (num_children)                                                             
>                buffer += sprintf(buffer, "\nChildren: %d\nTotal: %d",

the newlines are essential because then you get _one_ field of 
information for _each_ call of fgets().



Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/