Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] net/mlx5: use kvfree() for memory allocated with
 kvzalloc()
To:     angkery <angkery@163.com>, <saeedm@nvidia.com>, <leon@kernel.org>,
        <davem@davemloft.net>, <kuba@kernel.org>, <vladbu@nvidia.com>,
        <dlinkin@nvidia.com>, <dan.carpenter@oracle.com>
CC:     <netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Junlin Yang <yangjunlin@yulong.com>
References: <20210303024019.2245-1-angkery@163.com>
From:   Roi Dayan <roid@nvidia.com>
Message-ID: <0c195a3a-53cc-dbd2-f656-54a92e5a569b@nvidia.com>
Date:   Wed, 3 Mar 2021 09:54:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210303024019.2245-1-angkery@163.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021-03-03 4:40 AM, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
> 
> It is allocated with kvzalloc(), the corresponding release function
> should not be kfree(), use kvfree() instead.
> 
> Generated by: scripts/coccinelle/api/kfree_mismatch.cocci
> 
> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> index 6f6772b..3da7bec 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> @@ -248,7 +248,7 @@ static int mlx5_esw_indir_table_rule_get(struct mlx5_eswitch *esw,
>   err_ethertype:
>   	kfree(rule);
>   out:
> -	kfree(rule_spec);
> +	kvfree(rule_spec);
>   	return err;
>   }
>   
> @@ -328,7 +328,7 @@ static int mlx5_create_indir_recirc_group(struct mlx5_eswitch *esw,
>   	e->recirc_cnt = 0;
>   
>   out:
> -	kfree(in);
> +	kvfree(in);
>   	return err;
>   }
>   
> @@ -347,7 +347,7 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw,
>   
>   	spec = kvzalloc(sizeof(*spec), GFP_KERNEL);
>   	if (!spec) {
> -		kfree(in);
> +		kvfree(in);
>   		return -ENOMEM;
>   	}
>   
> @@ -371,8 +371,8 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw,
>   	}
>   
>   err_out:
> -	kfree(spec);
> -	kfree(in);
> +	kvfree(spec);
> +	kvfree(in);
>   	return err;
>   }
>   
> 

thanks!

Reviewed-by: Roi Dayan <roid@nvidia.com>