Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1026678pxb; Thu, 4 Mar 2021 01:00:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwuTf4a8vq6rU3k+kmvZzdQ1vLcGu46Wlf/Q6yw7haVD/Rf3jWk5JE9A3TLxIA1+9SvpteX X-Received: by 2002:a17:906:15cc:: with SMTP id l12mr3168730ejd.280.1614848448010; Thu, 04 Mar 2021 01:00:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614848448; cv=none; d=google.com; s=arc-20160816; b=WqharVhJwEc9VUtNSGrORqebsnSzNgulmtUu6FU7adoB2eIxIGXatXLt0urHYYkX4X ON6lDNVqe5aXSh/k9Bya3IAN8cnpOfNHtY0xawyI3kYWVSyHFdasCo0ynPzlr+Hmg9XC yGPtGPdTou4NEFTwltNWlBGPjcuE7OP0emOrHMNg2fZu7A6gq+dX5eU1tC6Z2WqIKRnd 75lgwVi8T5W6TrFzLV4IJ4sYCIK+bY5knQQM1PWtk3gAErFDZS82gwM+oeR3os2llwdL 5vAyV+lcQaot2c+VcNSCQ+055r+WEm72F9oUb0eBQ9K8vtdDuRa9tVRGPdtcLvUJXr1y 06RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:mime-version:references :in-reply-to:subject:cc:to:from:sender:dkim-signature; bh=lk+kiBh9DxelRABaLk2WvTMpFyQOXyjGxViqp+7RPXI=; b=vi2gt+on0h6BHY7PLRH1flEESoIc944w45gij+nC87LPyCS8hdWPthhV11hoEi32bO I+q4OJs9DoGWmXDggkOGZZSgk19CEB8PTp1oYzTZilZjLi2vOYVDT2HhQiWSe1IwO188 pMVorywnjYy8M4KSMh5FVxbHY6VQv5CvCULPBjpwzpxng0aolyKalpM6ofCm8lMr4Pix 3CGNhJyOONrM5iAQ/5Vy+CaYwCDdiKs3oaaiHRnSREhAAHZxmOeCPVlMDMrn2NSwi2uu LPv0nFDcQS4GUDrXxkD8KV2LR3Xg87bMLEYkWZ2dtnmjDkF7PlRQj21fCWPgHZU66BGV Kwig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@vt-edu.20150623.gappssmtp.com header.s=20150623 header.b=Mz9oTuem; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vt.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z13si16341420edc.537.2021.03.04.01.00.25; Thu, 04 Mar 2021 01:00:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@vt-edu.20150623.gappssmtp.com header.s=20150623 header.b=Mz9oTuem; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vt.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbhCCNE1 (ORCPT + 99 others); Wed, 3 Mar 2021 08:04:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349099AbhCCIQT (ORCPT ); Wed, 3 Mar 2021 03:16:19 -0500 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C803C06178B for ; Tue, 2 Mar 2021 23:39:36 -0800 (PST) Received: by mail-qt1-x82c.google.com with SMTP id 18so14197692qty.3 for ; Tue, 02 Mar 2021 23:39:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:in-reply-to:references:mime-version:date :message-id; bh=lk+kiBh9DxelRABaLk2WvTMpFyQOXyjGxViqp+7RPXI=; b=Mz9oTuemrxw7uBR+VcrPGsG6pHB+52KIN6BJeKwUNPx8s84En3Lrhjex+j3/TiQLi+ tVvUXi2/nNQIwg2M0JCg8pkCpO1GgDwJf6wUx95Ifkl7Cuj4peb15EWdLBG0WhOAG8BK FFBvrXYwwiPFjNyUQ5PdiZdOxbfVm6cZJQdCzUPLJXuk11UN8QfVDCtONVa4ZCBV50YP 40xECXvD4r7w+NXArFKtf8bbx2jcpV5+AWXzyiEd1GqnrimJM+l4G/cB1Z++5m/T3JFS d6uw8tIfrpMg1xH5xRVfsUG0EWHlQAU4wkS6nUxr52rpdtyiALtslLS03t/VQz/Sflf/ xDsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:date:message-id; bh=lk+kiBh9DxelRABaLk2WvTMpFyQOXyjGxViqp+7RPXI=; b=kCIaHa69yIrH5CnBwoMKf5U7qLQL0MvKDYR+IaIrzFpUDRb+TX8kwC/FycCdkXHTDf GgprKqv01UMFzIdncOrNyWRfIVSP0Fi7klwYXY6XeFXBPphEbQkzTO+hg/xk+JDwMTRs 9a6TV30JK/xcMHbbdaWdFmPIPHbBJPEZ/DWwHMff2MdxJ08DHehevXOC4W5D6/lCveo2 6L58dhPKlN0gg79ZOPILf0xSurfJ5EjtENsvxK9Z5JXmaS7HNH+Mi2qk5HTOVwzLgLxn HCijuCty8Xb5Br9Wwu81ZpWdykKb5vhCP/IBZu0cORfuFVysqJ0eZIdOcBbfzP8vLDgg aNrQ== X-Gm-Message-State: AOAM5339Fv3JnqHbQzyRat4k5/IN7guNl6rxsY5khi+onrEBFGJPdYuu BdJYleuV6oielSOUCk2GjDDNiQ== X-Received: by 2002:aed:3104:: with SMTP id 4mr15149355qtg.341.1614757175369; Tue, 02 Mar 2021 23:39:35 -0800 (PST) Received: from turing-police ([2601:5c0:c380:d61::359]) by smtp.gmail.com with ESMTPSA id l186sm8591517qke.92.2021.03.02.23.39.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 23:39:34 -0800 (PST) Sender: Valdis Kletnieks From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Heiner Kallweit cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" Subject: Re: next-20210302 - build issue with linux-firmware and rtl_nic/ firmware. In-reply-to: <02b966f5-a056-b799-dd6d-c5dc762d42f3@gmail.com> References: <199898.1614751762@turing-police> <02b966f5-a056-b799-dd6d-c5dc762d42f3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 03 Mar 2021 02:39:34 -0500 Message-ID: <205633.1614757174@turing-police> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 03 Mar 2021 07:51:06 +0100, Heiner Kallweit said: > > # Firmware loader > > CONFIG_EXTRA_FIRMWARE="rtl_nic/rtl8106e-1.fw" > > CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware" > > > This is wrong, simply remove it. > > But then I take a closer look at drivers/net/ethernet/realtek/r8169_main.c > > #define FIRMWARE_8168D_1 "rtl_nic/rtl8168d-1.fw" > > #define FIRMWARE_8168D_2 "rtl_nic/rtl8168d-2.fw" > > #define FIRMWARE_8168E_1 "rtl_nic/rtl8168e-1.fw" Yes, but then how are *these* filenames supposed to work? Is a userspace helper supposed to be smart enough to append the .xz, and the EXTRA_FIRMWARE variant for embedding out-of-tree firmware has to point at an uncompressed version?