Date: Thu, 28 Sep 2006 19:22:38 +0100
To: linux-kernel@vger.kernel.org
Subject: fs/bio.c - Hardcoded sector size ?
Message-ID: <20060928182238.GA4759@julia.computer-surgery.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.13 (2006-08-11)
From: Roger Gammans <roger@computer-surgery.co.uk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 907
Lines: 25

Hi

In bio_endio()  there is the follow line:- 

	bio->bi_sector += (bytes_done >> 9);

and there is a similiar line assuming a 512byte sector in 
__bio_add_page() .

Is this a bug as the the actual  block size  should be available
from bio->bi_bdev->bd_block_size surely - or is some clever code
where all block devices have to translate back to 512 byte sectors
for bio s.

TTFN
-- 
Roger.                          Home| http://www.sandman.uklinux.net/
Master of Peng Shui.      (Ancient oriental art of Penguin Arranging)
Work|Independent Sys Consultant | http://www.computer-surgery.co.uk/
So what are the eigenvalues and eigenvectors of 'The Matrix'? --anon
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/