Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1066080pxb; Thu, 4 Mar 2021 02:17:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJxwsWrAg+jU1z0HS852skADWCULT5yexxumcVsMsDnQM2OdzaCoS/FI2N5/Rw0V5ckW0fq2 X-Received: by 2002:a50:e1c9:: with SMTP id m9mr3630369edl.307.1614853042979; Thu, 04 Mar 2021 02:17:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614853042; cv=none; d=google.com; s=arc-20160816; b=GwB7J99Y+uOwGsijBM9z5WrSINqX5dgjmp7cf6mzOcMJnjPRVKh99QJh501AF0SayG mfm6Y9cGLNFv2pd4rK4s4e2/ZYcQqmmOtv8FfQ1LNaVucy+IHayqpbXfh+6t9fhtDhUV hHqzd7PbH0XJf457b7Buoipf28TvDuP4E4Ns4FtInG17igdUJbdpAhb9kPdCVKXmeM6I 9Sg19huI8E7qA2Q0ckyCzTOoCWWSDQOHA7rWCM5GJzdOnZnr8olPpVaqu+HZIiLEVbbh tD6G2VBb6qlh20nbs9ANdJ4c7k7i50ZmSM/cqz75ROkPULYnPYtY3sgWqZTEeyuqR3c4 DN3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=MgKg+xuFshcWxF/EWFStdvX3IMRA6xhZUH5DmSOHrFs=; b=yIRRkQ6N9cdDzh0vmhAYuG1lOEUIIjx5Ad5nsIeEW4IzibV2BHIA79b3O/Iu8SEKPI 1ZJl0nfhAMHEhbv5zp3aWTK7w3nHKLfVzA2LZaoZKChB61HQA51u8uSP6iS9icdOsZPT EdakKH+HaDphQKjqjRkIM8MIQRCFh2Y/5d4Oh/aa0FU/qCaDQKBlGjGhcAAIMIyj/2/A elXBAesyPWurZ8hiyFUSwivNxuC9LzQFl5djABKobVU+lCcB2t/3SsXVsBW8G3ziziEO F/3Rt0DKTKfS3ag73pV8w73UkdeNI99djLi28Qabe6xqWghekU+QcUQI7zgxdm1nArA2 IPEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cf6si16311762ejb.272.2021.03.04.02.17.00; Thu, 04 Mar 2021 02:17:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347186AbhCCQjV (ORCPT + 99 others); Wed, 3 Mar 2021 11:39:21 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:40132 "EHLO mail-wm1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344703AbhCCMEE (ORCPT ); Wed, 3 Mar 2021 07:04:04 -0500 Received: by mail-wm1-f45.google.com with SMTP id o2so5581510wme.5 for ; Wed, 03 Mar 2021 04:02:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MgKg+xuFshcWxF/EWFStdvX3IMRA6xhZUH5DmSOHrFs=; b=ndQ5HhP9GKxt1nP6KAA/R6M1DU6ObNHUer0W6C2cz+mi/MzdBOZmKCSV3VQ5sXsmdq CHJiQd7o3gwK8BlyKGriSAhfZ5+ZSr0Si7Hw+mADDaEQi+sUNM6ejpPCbAdXH/KH5jiL Nq6IT+NE4y2Gz9HmVdoHBkxT0hZ0WBozTmcn4eSINM4suesKc7jgMjmN90vwShChSq96 xdfvylaTKsxLlOxJg9BfVn7fwm34Xm19F57S0eYJHpdNAs9oGeP15bXE6do3YTkJqnDP 2fBGdIuarCX0cU0B+597KdPlGDImo920n6bLcNKeJKypPD+zcK7kc/0W0Nm4f3ZjqavQ uIQg== X-Gm-Message-State: AOAM5309b2RKe9luxf+x9CMGMwSpscGfE+snrDBMAL5GZ4O//JPZ1MWa 7+H7hCGmGc0OfA2RtbUWL42eXcjU2VA= X-Received: by 2002:a7b:cb90:: with SMTP id m16mr8770689wmi.162.1614772335253; Wed, 03 Mar 2021 03:52:15 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id a75sm5914399wme.10.2021.03.03.03.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 03:52:14 -0800 (PST) Date: Wed, 3 Mar 2021 11:52:13 +0000 From: Wei Liu To: "Andrea Parri (Microsoft)" Cc: linux-kernel@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, linux-hyperv@vger.kernel.org, mikelley@microsoft.com Subject: Re: [PATCH] Drivers: hv: vmbus: Drop error message when 'No request id available' Message-ID: <20210303115213.h355ncqtezsigjxz@liuwe-devbox-debian-v2> References: <20210301191348.196485-1-parri.andrea@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210301191348.196485-1-parri.andrea@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 01, 2021 at 08:13:48PM +0100, Andrea Parri (Microsoft) wrote: > Running out of request IDs on a channel essentially produces the same > effect as running out of space in the ring buffer, in that -EAGAIN is > returned. The error message in hv_ringbuffer_write() should either be > dropped (since we don't output a message when the ring buffer is full) > or be made conditional/debug-only. > > Suggested-by: Michael Kelley > Signed-off-by: Andrea Parri (Microsoft) > Fixes: e8b7db38449ac ("Drivers: hv: vmbus: Add vmbus_requestor data structure for VMBus hardening") Applied to hyperv-fixes. Wei.