Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210222140756.713-1-heiko.thiery@gmail.com> <20210222140756.713-3-heiko.thiery@gmail.com>
 <CAOMZO5C4bL72mksHG4GfikgLOxib-A659rac7VkpjGsm150O_A@mail.gmail.com>
In-Reply-To: <CAOMZO5C4bL72mksHG4GfikgLOxib-A659rac7VkpjGsm150O_A@mail.gmail.com>
From:   Heiko Thiery <heiko.thiery@gmail.com>
Date:   Wed, 3 Mar 2021 13:54:00 +0100
Message-ID: <CAEyMn7akV6G4PkS266pMwi+nro6-Tffc0Zt6LN9sV7Kgi2dKcg@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: fsl: add support for Kontron
 pitx-imx8m board
To:     Fabio Estevam <festevam@gmail.com>
Cc:     "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        Li Yang <leoyang.li@nxp.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Michael Walle <michael@walle.cc>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Fabio,


Am Di., 2. M=C3=A4rz 2021 um 15:43 Uhr schrieb Fabio Estevam <festevam@gmai=
l.com>:
>
> Hi Heiko,
>
> On Mon, Feb 22, 2021 at 11:08 AM Heiko Thiery <heiko.thiery@gmail.com> wr=
ote:
>
> > +       reg_usdhc2_vmmc: regulator-v-3v3-sd {
>
> reg_usdhc2_vmmc: regulator-usdhc2-vmmc {

I used the same name as used on imx8mq-evk. Do you think a better name
is the one you proposed?

> > +       tpm_reset: tpm-reset {
> > +               compatible =3D "gpio-reset";
>
> I don't see this compatible string documented.

This comes from the linux-imx tree [1].  Nethertheless the reset seems
not to be used by the tpm driver for the infineon chip.

[1] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/reset=
/gpio-reset.c?h=3Dimx_5.4.70_2.3.0

So I think I can remove it here.

>
> > +               reset-gpios =3D <&gpio3 2 GPIO_ACTIVE_LOW>;
> > +               reset-delay-us =3D <2>;
> > +               reset-post-delay-ms =3D <60>;
> > +               #reset-cells =3D <0>;
> > +       };
> > +
> > +       usb_hub_reset: usb-hub-reset {
> > +               compatible =3D "gpio-reset";
>
> Same here.

Also the usb-hub-reset can be removed.

>
> > +&fec1 {
> > +       pinctrl-names =3D "default";
> > +       pinctrl-0 =3D <&pinctrl_fec1>;
> > +       phy-mode =3D "rgmii-id";
> > +       phy-handle =3D <&ethphy0>;
> > +       phy-reset-gpios =3D <&gpio1 11 GPIO_ACTIVE_LOW>;
>
> This property is deprecated. Please consider using reset-gpios inside
> ethernet-phy instead.

Done

> > +       /* TODO: configure audio, as of now just put a placeholder */
> > +       wm8904: audio-codec@1a {
> > +               compatible =3D "wlf,wm8904";
> > +               reg =3D <0x1a>;
> > +               clocks =3D <&clk IMX8MQ_CLK_SAI2_ROOT>;
> > +               clock-names =3D "mclk";
> > +               clock-frequency =3D <24000000>;
>
> Not a valid property.

The whole node is removed since v3.

> > +/* M.2 B-key slot */
> > +&pcie0 {
> > +       pinctrl-names =3D "default";
> > +       pinctrl-0 =3D <&pinctrl_pcie0>;
> > +       disable-gpio =3D <&gpio5 29 GPIO_ACTIVE_LOW>;
>
> Not a valid property.

This comes from the linux-imx tree [2]. but in mainline it is not
valid. So I will remove it.

[2] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/pci/c=
ontroller/dwc/pci-imx6.c?h=3Dimx_5.4.70_2.3.0#n2436

> > +       reset-gpio =3D <&gpio1 9 GPIO_ACTIVE_LOW>;
> > +       clocks =3D <&clk IMX8MQ_CLK_PCIE1_ROOT>,
> > +                <&clk IMX8MQ_CLK_PCIE1_AUX>,
> > +                <&clk IMX8MQ_CLK_PCIE1_PHY>,
> > +                <&pcie0_refclk>;
> > +       clock-names =3D "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> > +       ext_osc =3D <1>;
>
> Not a valid property.

This comes from the linux-imx tree [3]. but in mainline it is not
valid. So I will remove it.

[3] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/pci/c=
ontroller/dwc/pci-imx6.c?h=3Dimx_5.4.70_2.3.0#n2422

> > +/* Intel Ethernet Controller I210/I211 */
> > +&pcie1 {
> > +       clocks =3D <&clk IMX8MQ_CLK_PCIE2_ROOT>,
> > +                <&clk IMX8MQ_CLK_PCIE2_AUX>,
> > +                <&clk IMX8MQ_CLK_PCIE2_PHY>,
> > +                <&pcie1_refclk>;
> > +       clock-names =3D "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> > +       ext_osc =3D <1>;
>
> Not a valid property.

same as commented before.

Thank you for the review. I will prepare v4.


--
Heiko