Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH v3 00/14] pinctrl: add BCM63XX pincontrol support
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <CACRpkdbi77SBsssMOnx43fP9RgqnzkUUw=TXaE2_LDexpE2WEg@mail.gmail.com>
Date:   Wed, 3 Mar 2021 17:23:20 +0100
Cc:     Rob Herring <robh+dt@kernel.org>, Michael Walle <michael@walle.cc>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        Jonas Gorski <jonas.gorski@gmail.com>,
        Necip Fazil Yildiran <fazilyildiran@gmail.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <D875EBA4-F881-4F1E-A251-78CEF8E6A40B@gmail.com>
References: <20210303142310.6371-1-noltari@gmail.com>
 <CACRpkdbi77SBsssMOnx43fP9RgqnzkUUw=TXaE2_LDexpE2WEg@mail.gmail.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Precedence: bulk

Hi Linus,

> El 3 mar 2021, a las 16:29, Linus Walleij <linus.walleij@linaro.org> =
escribi=C3=B3:
>=20
> On Wed, Mar 3, 2021 at 3:23 PM =C3=81lvaro Fern=C3=A1ndez Rojas =
<noltari@gmail.com> wrote:
>=20
>> v3: introduce new files for shared code and add more changes =
suggested by
>> Linus Walleij. Also add a new patch needed for properly parsing =
gpio-ranges.
>=20
> This looks very appetizing, I am ready to merge this once we cut some
> slack for DT review (a week or two).
>=20
> I'd like to merge it soon so you can start working on the IRQ add-on.
>=20
> I'd probably drop the IRQ-related selects from Kconfig
> when applying though (no big deal, no need to resend over that).

About that, it seems that GPIO_REGMAP should select GPIOLIB_IRQCHIP, =
since I couldn=E2=80=99t build the kernel due to the following error =
when I removed the IRQ-related selects:
  LD      vmlinux.o
  MODPOST vmlinux.symvers
  MODINFO modules.builtin.modinfo
  GEN     modules.builtin
  LD      .tmp_vmlinux.kallsyms1
mips-linux-gnu-ld: drivers/gpio/gpio-regmap.o: in function =
`gpio_regmap_register':
gpio-regmap.c:(.text+0x704): undefined reference to =
`gpiochip_irqchip_add_domain'
make: *** [Makefile:1197: vmlinux] Error 1

Or maybe we could guard these lines of gpio-regmap.c with #ifdef =
GPIOLIB_IRQCHIP:
=
https://github.com/torvalds/linux/blob/f69d02e37a85645aa90d18cacfff36dba37=
0f797/drivers/gpio/gpio-regmap.c#L282-L286

>=20
> Yours,
> Linus Walleij

Best regards,
=C3=81lvaro.=