Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Mar 2021 20:17:44 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Julien Thierry <jthierry@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
        ardb@kernel.org, masahiroy@kernel.org, jpoimboe@redhat.com,
        ycote@redhat.com
Subject: Re: [RFC PATCH v2 00/13] objtool: add base support for arm64
Message-ID: <YD/g2G3Yi8o99f7H@hirez.programming.kicks-ass.net>
References: <20210303170932.1838634-1-jthierry@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210303170932.1838634-1-jthierry@redhat.com>
Precedence: bulk

On Wed, Mar 03, 2021 at 06:09:19PM +0100, Julien Thierry wrote:
> Hi,
> 
> This series enables objtool to start doing stack validation on arm64
> kernel builds. 

> -->
> 
> Julien Thierry (12):
>   tools: Add some generic functions and headers
>   tools: arm64: Make aarch64 instruction decoder available to tools
>   tools: bug: Remove duplicate definition
>   objtool: arm64: Add base definition for arm64 backend
>   objtool: arm64: Decode add/sub instructions
>   objtool: arm64: Decode jump and call related instructions
>   objtool: arm64: Decode other system instructions
>   objtool: arm64: Decode load/store instructions
>   objtool: arm64: Decode LDR instructions
>   objtool: arm64: Accept padding in code sections
>   objtool: arm64: Handle supported relocations in alternatives
>   objtool: arm64: Ignore replacement section for alternative callback
> 
> Raphael Gault (1):
>   objtool: arm64: Enable stack validation for arm64


These patches look very reasonable to me,

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>


One selfish thing, would it make sense to have a make target that builds
all supported srcarch targets?

This might be useful when hacking on objtool to make sure everything
builds.