Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Mar 2021 20:27:33 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Henning Schild <henning.schild@siemens.com>
Cc:     linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        linux-watchdog@vger.kernel.org,
        Srikanth Krishnakar <skrishnakar@gmail.com>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Gerd Haeussler <gerd.haeussler.ext@siemens.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Mark Gross <mgross@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens
 Industial PCs
Message-ID: <20210303192733.GA8720@amd>
References: <20210302163309.25528-1-henning.schild@siemens.com>
 <20210302163309.25528-3-henning.schild@siemens.com>
 <20210302205452.GA32573@duo.ucw.cz>
 <20210303183714.62c0f06f@md1za8fc.ad001.siemens.net>
 <20210303174040.GA3305@amd>
 <20210303194956.5b36a73c@md1za8fc.ad001.siemens.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd"
Content-Disposition: inline
In-Reply-To: <20210303194956.5b36a73c@md1za8fc.ad001.siemens.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk


--ZPt4rx8FFjLCG7dd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed 2021-03-03 19:49:56, Henning Schild wrote:
> Am Wed, 3 Mar 2021 18:40:40 +0100
> schrieb Pavel Machek <pavel@ucw.cz>:
>=20
> > Hi!
> >=20
> > > > > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
> > > > > index 2a698df9da57..c15e1e3c5958 100644
> > > > > --- a/drivers/leds/Makefile
> > > > > +++ b/drivers/leds/Makefile
> > > > > @@ -93,6 +93,7 @@ obj-$(CONFIG_LEDS_TURRIS_OMNIA)
> > > > > 	+=3D leds-turris-omnia.o
> > > > > obj-$(CONFIG_LEDS_WM831X_STATUS)	+=3D leds-wm831x-status.o
> > > > > obj-$(CONFIG_LEDS_WM8350)		+=3D leds-wm8350.o
> > > > > obj-$(CONFIG_LEDS_WRAP)			+=3D leds-wrap.o
> > > > > +obj-$(CONFIG_LEDS_SIEMENS_SIMATIC_IPC)	+=3D
> > > > > simatic-ipc-leds.o   =20
> > > >=20
> > > > Let's put this into drivers/leds/simple. You'll have to create
> > > > it. =20
> > >=20
> > > Can you please go into detail why? We plan to add more devices in
> > > the future, which might in fact make this a little less simple. But
> > > we can discuss that when the time is right and start with simple. =20
> >=20
> > There's already way too many drivers in the directory, and your driver
> > is very different from drivers for camera flash (for example).
>=20
> Understood, the whole Makefile Kconfig thingy?

You'll need Makefile + Kconfig, yes. No need for CONFIG_LEDS_SIMPLE.

Best regards,
								Pavel

--=20
http://www.livejournal.com/~pavelmachek

--ZPt4rx8FFjLCG7dd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAmA/4yUACgkQMOfwapXb+vK/tgCgqwLKOLfYmIuhh5QZrkHIfSET
FuoAoI5etED7qEWaPIdY61h5hp+n7gXG
=i6mJ
-----END PGP SIGNATURE-----

--ZPt4rx8FFjLCG7dd--