Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1234973pxb;
        Thu, 4 Mar 2021 06:45:44 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwFNQenh1zGHu/0Fe5OVjkOaqTbNBu+/jON0Ec4T6PlWPCxJMfdyoAZXgQEKFwAy9C/S1jY
X-Received: by 2002:a17:906:4c56:: with SMTP id d22mr4832437ejw.426.1614869143974;
        Thu, 04 Mar 2021 06:45:43 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1614869143; cv=none;
        d=google.com; s=arc-20160816;
        b=C1itCFKjWQlrfgZh07GrUxHSuGc8PTjVLMNlOpke228bPVT7gsNZQ/KRumAyzQtKrG
         nFdxMxE2HnS+xAF4/WbvnokX5/FZrULZRk0am1Q6/GwQK8xXn77IuFnC2Fgmqc6Cucws
         qGi8FZDEbZVnWw5BANxwWG89ojOvna238eT+0/Ue162C9nFb65m0RM4+Ucms5DoiYRoR
         syaECLZISyvdo3rWBeEGjW91v6RuuXXdO7E29vT5iBszZFfiTuYOV3QS59OKOzisxw+d
         6+vpEsHZNZggsVst+fEHucSN+ISJUImWmvta0lrhVMizVp7ntmSh/lKsJDZEoBM5/hyR
         r53A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-transfer-encoding
         :mime-version:references:in-reply-to:message-id:date:subject:cc:to
         :from;
        bh=p4JDJbZednwqFrVYpTjMUfEe/DvW0PBtYvVi5ZHIeDg=;
        b=R+J4oC8Kx52+E5lhpnAvGHesEe7U7F6VzAvR7QQS2fxEM1IluLj4C/v9sFFn3HmShn
         4zV6cFMmIKjS2XY155Kezs4tW1iplAupkW+xq5GqVK5vNrq/1LD7qdZfTXTlfc2ymHUv
         QOzRyxg+m8gERCwHKma9ChiROVCB7fjCT0bguSTqMUOkXnfRN2OrlGod91lfGORU/PQK
         ANTBRNeWKHTetr9tRYSrOW7JRsj3zLip53vLkOeKdAXGN+e/OO5BstaZdgkLHLfqASWP
         EhXIuBC68rMp+8RZYiDH+FekEg+JJP0ZBplx1U0xiaSfugeXDHaeFyRtXlYb/4wF8DZy
         15tg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=eK4xtp0L;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id g12si16932873ejd.256.2021.03.04.06.45.21;
        Thu, 04 Mar 2021 06:45:43 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=eK4xtp0L;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233477AbhCDE2Y (ORCPT <rfc822;luzhigang001@gmail.com>
        + 99 others); Wed, 3 Mar 2021 23:28:24 -0500
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:8387 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233483AbhCDE2C (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 3 Mar 2021 23:28:02 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B604061aa0002>; Wed, 03 Mar 2021 20:27:22 -0800
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL105.nvidia.com
 (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Mar
 2021 04:27:21 +0000
Received: from nvdebian.localnet (172.20.145.6) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Mar 2021
 04:27:18 +0000
From:   Alistair Popple <apopple@nvidia.com>
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     <linux-mm@kvack.org>, <nouveau@lists.freedesktop.org>,
        <bskeggs@redhat.com>, <akpm@linux-foundation.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>, <jhubbard@nvidia.com>,
        <rcampbell@nvidia.com>, <jglisse@redhat.com>, <hch@infradead.org>,
        <daniel@ffwll.ch>
Subject: Re: [PATCH v3 3/8] mm/rmap: Split try_to_munlock from try_to_unmap
Date:   Thu, 4 Mar 2021 15:27:16 +1100
Message-ID: <29906974.JcgKRUyaEZ@nvdebian>
In-Reply-To: <20210301161049.GJ4247@nvidia.com>
References: <20210226071832.31547-1-apopple@nvidia.com> <20210226071832.31547-4-apopple@nvidia.com> <20210301161049.GJ4247@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Originating-IP: [172.20.145.6]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1614832042; bh=p4JDJbZednwqFrVYpTjMUfEe/DvW0PBtYvVi5ZHIeDg=;
        h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:
         MIME-Version:Content-Transfer-Encoding:Content-Type:
         X-Originating-IP:X-ClientProxiedBy;
        b=eK4xtp0Lie2rFKeCJiwu9nlyb3pg65al7AaYhe5pFEkjuZypZcZWqWwBhIJF/wcDp
         PeQNy6FGBUd0zDIOEMAmPED2HCpYTvechpwR+GhIoYVRZFKyk01aJKt7ARncP8p8JZ
         ybgZM6eVhq/ekdvvxoHYF4ZUo3i3wFiUVmzFby7JbEpdKu/9FUzqaXW8BGo+t+IT56
         wnlFRZhUlyDxyoFeYFzg2G/DH1DkrOlKSB4Gze98CVtRP0KXBvoV+25QwHqG+JoaMn
         aZRBeoYSfmsvpz2jOgPXwj+ksEe+zXuX4lMEPiIXdghUNttv0RhWvDU/1dJpobBdT8
         cwnG9pSLeDbSQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, 2 March 2021 3:10:49 AM AEDT Jason Gunthorpe wrote:
> > +       while (page_vma_mapped_walk(&pvmw)) {
> > +               /*
> > +                * If the page is mlock()d, we cannot swap it out.
> > +                * If it's recently referenced (perhaps page_referenced
> > +                * skipped over this mm) then we should reactivate it.
> > +                */
> > +               if (vma->vm_flags & VM_LOCKED) {
> 
> And since we write the data without holding the PTLs this looks
> pointless, unless there is some other VM_LOCKED manipulation
> 

Thanks. I couldn't find any other manipulation of VM_LOCKED whilst holding the 
PTL so I'll remove this redundant check.

 - Alistair