Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: WN1wXKPM6AGupd4E2aJ1fd0LnwtAJsFxY6dSK1wHFLXuV90nhu5zzoaHNMSE8I9L5/+aZ+rhDY
 z/zjkE4Eozng==
IronPort-SDR: Q/NHB0Yoz6gyDK7pW0hIBip1/JqAaK9fRe5D3wii0J/9PjfWoCOBJ2+3CYx3rh6Tq30WG8oyIX
 5+QJARIUE+TQ==
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jacob Pan <jacob.jun.pan@linux.intel.com>,
        Vivek Gautam <vivek.gautam@arm.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "will.deacon@arm.com" <will.deacon@arm.com>,
        "mst@redhat.com" <mst@redhat.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "jean-philippe@linaro.org" <jean-philippe@linaro.org>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>
Subject: RE: [PATCH RFC v1 12/15] iommu/virtio: Add support for INVALIDATE
 request
Thread-Topic: [PATCH RFC v1 12/15] iommu/virtio: Add support for INVALIDATE
 request
Thread-Index: AQHW6zgLG401/TrBskO19/88pi8guKpy36oAgAC/ouA=
Date:   Thu, 4 Mar 2021 05:58:26 +0000
Message-ID: <MWHPR11MB1886860008D526446026E7E58C979@MWHPR11MB1886.namprd11.prod.outlook.com>
References: <20210115121342.15093-1-vivek.gautam@arm.com>
        <20210115121342.15093-13-vivek.gautam@arm.com>
 <20210303102848.5d879f0e@jacob-builder>
In-Reply-To: <20210303102848.5d879f0e@jacob-builder>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b10820fc-f437-49c5-a6cd-08d8ded2877c
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2021 05:58:26.9457
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2J0Ei6sfKQXOhSfUcwVfrchx9AQzeosQAweVkvwmTPchdUpnpQot7+IBRaC7L4d4eGckj5Kqtk4b7AtqGOSrkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4865
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Sent: Thursday, March 4, 2021 2:29 AM
>=20
> Hi Vivek,
>=20
> On Fri, 15 Jan 2021 17:43:39 +0530, Vivek Gautam <vivek.gautam@arm.com>
> wrote:
>=20
> > From: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> >
> > Add support for tlb invalidation ops that can send invalidation
> > requests to back-end virtio-iommu when stage-1 page tables are
> > supported.
> >
> Just curious if it possible to reuse the iommu uapi for invalidation and =
others.
> When we started out designing the iommu uapi, the intention was to suppor=
t
> both emulated and virtio iommu.

IIUC this patch is about the protocol between virtio-iommu frontend and bac=
kend.
After the virtio-iommu backend receives invalidation ops, it then needs to
forward the request to the host IOMMU driver through the existing iommu
uapi that you referred to, as a emulated VT-d or SMMU would do.

Thanks
Kevin

>=20
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> > [Vivek: Refactoring the iommu_flush_ops, and adding only one pasid sync
> >         op that's needed with current iommu-pasid-table infrastructure.
> > 	Also updating uapi defines as required by latest changes]
> > Signed-off-by: Vivek Gautam <vivek.gautam@arm.com>
> > Cc: Joerg Roedel <joro@8bytes.org>
> > Cc: Will Deacon <will.deacon@arm.com>
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Cc: Robin Murphy <robin.murphy@arm.com>
> > Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>
> > Cc: Eric Auger <eric.auger@redhat.com>
> > Cc: Alex Williamson <alex.williamson@redhat.com>
> > Cc: Kevin Tian <kevin.tian@intel.com>
> > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Cc: Liu Yi L <yi.l.liu@intel.com>
> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
> > ---
> >  drivers/iommu/virtio-iommu.c | 95
> ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 95 insertions(+)
> >
> > diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.=
c
> > index ae5dfd3f8269..004ea94e3731 100644
> > --- a/drivers/iommu/virtio-iommu.c
> > +++ b/drivers/iommu/virtio-iommu.c
> > @@ -13,6 +13,7 @@
> >  #include <linux/freezer.h>
> >  #include <linux/interval_tree.h>
> >  #include <linux/iommu.h>
> > +#include <linux/io-pgtable.h>
> >  #include <linux/module.h>
> >  #include <linux/of_iommu.h>
> >  #include <linux/of_platform.h>
> > @@ -63,6 +64,8 @@ struct viommu_mapping {
> >  };
> >
> >  struct viommu_mm {
> > +	int				pasid;
> > +	u64				archid;
> >  	struct io_pgtable_ops		*ops;
> >  	struct viommu_domain		*domain;
> >  };
> > @@ -692,6 +695,98 @@ static void viommu_event_handler(struct
> virtqueue
> > *vq) virtqueue_kick(vq);
> >  }
> >
> > +/* PASID and pgtable APIs */
> > +
> > +static void __viommu_flush_pasid_tlb_all(struct viommu_domain
> *vdomain,
> > +					 int pasid, u64 arch_id, int
> > type) +{
> > +	struct virtio_iommu_req_invalidate req =3D {
> > +		.head.type	=3D VIRTIO_IOMMU_T_INVALIDATE,
> > +		.inv_gran	=3D
> > cpu_to_le32(VIRTIO_IOMMU_INVAL_G_PASID),
> > +		.flags		=3D
> > cpu_to_le32(VIRTIO_IOMMU_INVAL_F_PASID),
> > +		.inv_type	=3D cpu_to_le32(type),
> > +
> > +		.domain		=3D cpu_to_le32(vdomain->id),
> > +		.pasid		=3D cpu_to_le32(pasid),
> > +		.archid		=3D cpu_to_le64(arch_id),
> > +	};
> > +
> > +	if (viommu_send_req_sync(vdomain->viommu, &req, sizeof(req)))
> > +		pr_debug("could not send invalidate request\n");
> > +}
> > +
> > +static void viommu_flush_tlb_add(struct iommu_iotlb_gather *gather,
> > +				 unsigned long iova, size_t granule,
> > +				 void *cookie)
> > +{
> > +	struct viommu_mm *viommu_mm =3D cookie;
> > +	struct viommu_domain *vdomain =3D viommu_mm->domain;
> > +	struct iommu_domain *domain =3D &vdomain->domain;
> > +
> > +	iommu_iotlb_gather_add_page(domain, gather, iova, granule);
> > +}
> > +
> > +static void viommu_flush_tlb_walk(unsigned long iova, size_t size,
> > +				  size_t granule, void *cookie)
> > +{
> > +	struct viommu_mm *viommu_mm =3D cookie;
> > +	struct viommu_domain *vdomain =3D viommu_mm->domain;
> > +	struct virtio_iommu_req_invalidate req =3D {
> > +		.head.type	=3D VIRTIO_IOMMU_T_INVALIDATE,
> > +		.inv_gran	=3D cpu_to_le32(VIRTIO_IOMMU_INVAL_G_VA),
> > +		.inv_type	=3D
> cpu_to_le32(VIRTIO_IOMMU_INV_T_IOTLB),
> > +		.flags		=3D
> > cpu_to_le32(VIRTIO_IOMMU_INVAL_F_ARCHID), +
> > +		.domain		=3D cpu_to_le32(vdomain->id),
> > +		.pasid		=3D cpu_to_le32(viommu_mm->pasid),
> > +		.archid		=3D cpu_to_le64(viommu_mm->archid),
> > +		.virt_start	=3D cpu_to_le64(iova),
> > +		.nr_pages	=3D cpu_to_le64(size / granule),
> > +		.granule	=3D ilog2(granule),
> > +	};
> > +
> > +	if (viommu_add_req(vdomain->viommu, &req, sizeof(req)))
> > +		pr_debug("could not add invalidate request\n");
> > +}
> > +
> > +static void viommu_flush_tlb_all(void *cookie)
> > +{
> > +	struct viommu_mm *viommu_mm =3D cookie;
> > +
> > +	if (!viommu_mm->archid)
> > +		return;
> > +
> > +	__viommu_flush_pasid_tlb_all(viommu_mm->domain,
> viommu_mm->pasid,
> > +				     viommu_mm->archid,
> > +				     VIRTIO_IOMMU_INV_T_IOTLB);
> > +}
> > +
> > +static struct iommu_flush_ops viommu_flush_ops =3D {
> > +	.tlb_flush_all		=3D viommu_flush_tlb_all,
> > +	.tlb_flush_walk		=3D viommu_flush_tlb_walk,
> > +	.tlb_add_page		=3D viommu_flush_tlb_add,
> > +};
> > +
> > +static void viommu_flush_pasid(void *cookie, int pasid, bool leaf)
> > +{
> > +	struct viommu_domain *vdomain =3D cookie;
> > +	struct virtio_iommu_req_invalidate req =3D {
> > +		.head.type	=3D VIRTIO_IOMMU_T_INVALIDATE,
> > +		.inv_gran	=3D
> > cpu_to_le32(VIRTIO_IOMMU_INVAL_G_PASID),
> > +		.inv_type	=3D
> cpu_to_le32(VIRTIO_IOMMU_INV_T_PASID),
> > +		.flags		=3D
> > cpu_to_le32(VIRTIO_IOMMU_INVAL_F_PASID), +
> > +		.domain		=3D cpu_to_le32(vdomain->id),
> > +		.pasid		=3D cpu_to_le32(pasid),
> > +	};
> > +
> > +	if (leaf)
> > +		req.flags	|=3D
> > cpu_to_le32(VIRTIO_IOMMU_INVAL_F_LEAF); +
> > +	if (viommu_send_req_sync(vdomain->viommu, &req, sizeof(req)))
> > +		pr_debug("could not send invalidate request\n");
> > +}
> > +
> >  /* IOMMU API */
> >
> >  static struct iommu_domain *viommu_domain_alloc(unsigned type)
>=20
>=20
> Thanks,
>=20
> Jacob