Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1258224pxb; Thu, 4 Mar 2021 07:13:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJxPIf2MZQjplZmQ572RTquQ9qBbrk6yz8+DhStYqK1QHZWrNBlXY5J0VtsZtYKzLeak14Xq X-Received: by 2002:a17:906:f9d8:: with SMTP id lj24mr4790417ejb.200.1614870806311; Thu, 04 Mar 2021 07:13:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614870806; cv=none; d=google.com; s=arc-20160816; b=CqpGRNiKrZW+Es5/61RpJjejwom86QSrit9OYCoEh2f9dbvl3proV0U2OlD0lx2op1 cQ+b5ZeuAt5T78q/P1hKWJ+9U+k3NNBW75F1guGwzuK/Ub1UfKOMHibfHiAGm2YqJD/q 04Z2xJOutDOS7SHL1r+fDfD4vDbyVGkBlL1xjemjW+O8TapJIoOaqd8JLnqy/chGo4eC 9B6rG52bIU9SAs6j+OuJMR4Yjc8RRj/UTkpvBb+1jhMMvrPPJNSzdABPbZYedsS72Xu3 sFDBu8kVmRWRWs0PBtPYg4tiNRq02EmHQ5fm4N0U/9uKdJtHnvy5/49svkGhCdqhpeU3 QbfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=mfsvHB9fDbs1Qdb97UhB6YQLLdl8ZqvKH01Jl/iGVFA=; b=wU0Wv2o6cc/s9V4hthLQlzOgFYwJgknYBDt3cZ3fzRKlQFm239cJDuf1/lNEpoIUEo OqnwoQOPnW05EiTanHwUH5va+637OIVrbzm+JR03fZoHvn14z1InuzOOF7r/ET60tUeF O+w5g3wiaz6eSlyjd2EEQycQT5HXnZHOsnJGWq6ppUEUtaK1pLgheq52c7mjltlxJlzl uXxPydS9dvFDVMew+tjxmVy5omPeAVJGqiIzfIQKdF3n/UXKIvkgu8NLAssJGfGEgpK/ J12FyKHt9arG9BdGxoXOCjGYuMMVoYeaYZw6QIL1BEu+OwEqIh4eguup9GQXxqzeRXha Acxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=eTD42zUr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k16si17481450ejd.246.2021.03.04.07.12.57; Thu, 04 Mar 2021 07:13:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=eTD42zUr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235161AbhCDG0I (ORCPT + 99 others); Thu, 4 Mar 2021 01:26:08 -0500 Received: from z11.mailgun.us ([104.130.96.11]:14160 "EHLO z11.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235160AbhCDG0F (ORCPT ); Thu, 4 Mar 2021 01:26:05 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1614839145; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=mfsvHB9fDbs1Qdb97UhB6YQLLdl8ZqvKH01Jl/iGVFA=; b=eTD42zUrI5H87x5gPQwXPPPJ+P/8rTb/uI1sw5AhLxkIT4ySdLL4WngerkHlLjslJgjW2Paf cE/KqkPuyoAK2gEBaqJc7NTzFovXzafKcnS0BEwsDa3/9aj5Vus1Toke7bgNctqN3+oj1bMo wmgSKNL3zX4USYitMSNJnnXAfyI= X-Mailgun-Sending-Ip: 104.130.96.11 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 60407d4d64e0747df94e11a8 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 04 Mar 2021 06:25:17 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 23CE1C43467; Thu, 4 Mar 2021 06:25:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 895AEC433CA; Thu, 4 Mar 2021 06:25:15 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 04 Mar 2021 14:25:15 +0800 From: Can Guo To: daejun7.park@samsung.com Cc: Greg KH , avri.altman@wdc.com, jejb@linux.ibm.com, martin.petersen@oracle.com, asutoshd@codeaurora.org, stanley.chu@mediatek.com, bvanassche@acm.org, huobean@gmail.com, ALIM AKHTAR , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, JinHwan Park , Javier Gonzalez , SEUNGUK SHIN , Sung-Jun Park , Jinyoung CHOI , BoRam Shin Subject: Re: [PATCH v26 4/4] scsi: ufs: Add HPB 2.0 support In-Reply-To: <20210303062926epcms2p6aa6737e5ed3916eed9ab80011aad3d83@epcms2p6> References: <20210303062633epcms2p252227acd30ad15c1ca821d7e3f547b9e@epcms2p2> <20210303062926epcms2p6aa6737e5ed3916eed9ab80011aad3d83@epcms2p6> Message-ID: <94311b42ef6ee34ba5908fcefefa4010@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > - if (!ufshpb_is_support_chunk(transfer_len)) > - return; > + if (!ufshpb_is_support_chunk(hpb, transfer_len) && > + (ufshpb_is_legacy(hba) && (transfer_len != > HPB_LEGACY_CHUNK_HIGH))) > + return 0; > This is looks awkward, can we put the checks in ufshpb_is_support_chunk()? Thanks, Can Guo.