Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1280517pxb; Thu, 4 Mar 2021 07:40:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzM53Zzh9Z9TonqsE48NaOypdTBbgMuFQco8Ty61tSJsAyHVIo8EcTyHhLgB7+1XnxyxRz/ X-Received: by 2002:a05:6402:31b7:: with SMTP id dj23mr5087225edb.245.1614872410506; Thu, 04 Mar 2021 07:40:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614872410; cv=none; d=google.com; s=arc-20160816; b=NtpQtNKb7wgqDPe/YRqUTtGyfwsaQ4stX5qvO9BYD8cEzhR3Tco7NiS1rqd9FkqcAM d3fXCKWt+Wk/8Ffy7am8Xmo+zyClb/hE2DIuAHCWXkwJp9YPCaQLBtkx3NfeovtH5QFc HDIJmtNccjH9IIjuPMJkLsnf54b4mTApktXpSfYo0sDIneP6q3dxkPmMwolOg7BiEBb5 8FUkQjwRZrIHqQUOmgbfWpVuGN7Wpaiw7t5TwmULB44PDFtD6GIU+2B3imhJj4HBxkHY ZchaWpZ+No8HcEuB5wcBRrOOEfgtfpUP4SmXhBTauWc95YjuITvWGiO2qE1Zf6cN8Ppb HRNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=H2wbxkZ5EFhhbbOmwBTKlvU1xjWHEm3aG6/6XZryrvM=; b=ZazWy+ZvG6T9ggFoEqunmoNEwkhrClsevSQtlMFfSm62L//b2ZPomkLoQSc2NlEMxm TsF69WX7+Lq7Oqtm2ugmelz4Lh0nsjPh4kuITlE8VdcdsgYqlcDmLOoy4/4tIWmGARTl JR2I3r1h2fXiCeP2RdYaMrinMfxiVRivpHNRILWQ3tRp4gSLN2g0sW+qgGeYXisk9Kvl UoqvJca4RfsYkj8EiYl6cvGqaXKtatb2xsCRL5dXK43frXgAxF/W4GPAE7yRbpzbF7yo mFXhw6TUXNKkqPK5QTHJbDAt+18JkrBbPwY3EvtU2b5MzBMiqg8gZ8JHe9a3T3c6svh+ eB4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aP2tQTyL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si6134230edb.393.2021.03.04.07.39.47; Thu, 04 Mar 2021 07:40:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aP2tQTyL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236703AbhCDIte (ORCPT + 99 others); Thu, 4 Mar 2021 03:49:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236654AbhCDItK (ORCPT ); Thu, 4 Mar 2021 03:49:10 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A44CC061760 for ; Thu, 4 Mar 2021 00:48:30 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id v9so24068356lfa.1 for ; Thu, 04 Mar 2021 00:48:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H2wbxkZ5EFhhbbOmwBTKlvU1xjWHEm3aG6/6XZryrvM=; b=aP2tQTyLBKDPBoAnWKTOPwDqLrDfAzvHWjHRByw8Q2HneMAUDwP/6S3cHX5ozzAxSc mr/c++GCpYQcsIn0n4iMZK9iT+3Y7/GTWYLayG5b/NiUHV292Obc1KsdVePmOAGnuFnP dLZ/btA6PpMa1U/KMCHGMNAhub4bmozr5RJZbJ75y+St9LLksdz4HQpeMyyM7q0NGTKb XJDLW/N8DaA3AIdtaanC7CBGLXPw/Uhx+oOn1uJvR86/6/n8c4BOOsXxLikhMEf/1yeJ Ywnj2iLiASEAeh15xadVyP/Dpk+E/MQpIq83p6oFAXLQOHQhWs+U1ByEjbei5Bug16y2 fJyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H2wbxkZ5EFhhbbOmwBTKlvU1xjWHEm3aG6/6XZryrvM=; b=JtmA7yKQKk+jUEA5xFhd0zzz/RPFz8aTZy4e85PRC+OJWachZ4H1AU3COGF+M7RVjx W06G+hOKX5D1Tt3KtZE/kuWVshNQF33a2GgNQpQJf7JeY6nrQIdxliAIigdYZSWTFfu/ MQ7tE29dwGz8jttjZ2OaiUA59NH7fwD3TdyULU1bq1QXgopmXbYPqugVWFsCiufxEujc CJwX8gy6iVAe/kGd4iVfB+s76JrdzEO81gDcYpiimKYnexlG0FTXj1HqnaXu0HaM82R/ AX8PLvGJeZgYFUuj0z4CM4YsWyxDFXpA96ckEvUpq/OhzOG1Vn/nrLiv8BXFaIYZDNsQ duUA== X-Gm-Message-State: AOAM533lYp6nw8hXEDxjqfXx9ODdn2rqBVTvVI1DlwcTW3ioYYONk22H 07Q2+czlk8ZdOtUta5/3UTRp2N5fU7KmxDM6tF76bw== X-Received: by 2002:a05:6512:547:: with SMTP id h7mr1696001lfl.529.1614847708722; Thu, 04 Mar 2021 00:48:28 -0800 (PST) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-4-brad@pensando.io> In-Reply-To: <20210304034141.7062-4-brad@pensando.io> From: Linus Walleij Date: Thu, 4 Mar 2021 09:48:18 +0100 Message-ID: Subject: Re: [PATCH 3/8] spi: dw: Add support for Pensando Elba SoC SPI To: Brad Larson Cc: Linux ARM , Arnd Bergmann , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 4, 2021 at 4:42 AM Brad Larson wrote: > The Pensando Elba SoC uses a GPIO based chip select > for two DW SPI busses with each bus having two > chip selects. > > Signed-off-by: Brad Larson I agree with Serge's comments here: the existing cs callback should work for your SoC, you should only need the new compatible string. I see why you need the special GPIO driver for this now, as that is obviously driven by totally different hardware. Yours, Linus Walleij