Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1328670pxb; Thu, 4 Mar 2021 08:36:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJzamEMHgOkSBtHia18H8aJ5FPds1tu3WOcihZ1bPSXEKDKUqf/TYsf6ay6xX03Erp6GSyZ7 X-Received: by 2002:a50:9dc9:: with SMTP id l9mr5236474edk.377.1614875803283; Thu, 04 Mar 2021 08:36:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614875803; cv=none; d=google.com; s=arc-20160816; b=vIKJhBEP0N10ZqDoDh25WPPaKW3jg6f8gW5+FRj//sGdLuDNVoF496M1zrfNowq0lj 8lDvF8sMmlI9KZZVkoQpMISaEdl8pSNPKYwM9p8jNI8MNjAlif0ey8ZBR8/FnZnqdXFe SGZI0HmwGbNwAPdMOM94eY/WsECrzf0eAL9X2cS5Oodda7M04Sf5NBi1+XngApv9nlyL cvSZAtvX/yBJlFwrGqdRy6PWOKYjrG6WUeH3xHs8Dlos/GB0xq4cS7Zh2HaWYZPMIu/x JheTjfmPn30eRubMP7t30noNlN0dZ40I55fzRcPXd62ez54zVhVT8rSGzEq/g8eyeAxh cuMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=6DI4ds4bPexB/GkLA4WchyBLXa5cTnO4bngUO//xe4o=; b=YY0fy4kNslp12TMKJ5JlhwGvMDPfKlXjOOTrW+VdMpvknNuYfZos9poenobgY6jUnw +SyQ7v/9Lag7ksUivWzkczS2/0sPJwfrnZbGedOpPDTjqCsEqnM3GAnWJLIPrY0r5cCc d9Bd6wm9kBNE4WSCnFX6msKQmeM50nx5sDFLcP2v6+pWFPPM1EWmlmtnD4FYpc74wO0P ofv1DGa5wQ5Woa+T1O9830RLX3/y7/Cw0EJ7tTn+klF0qd3jYdFUbtwJQuSr5ALg+PuC s1kPGK23xVGCB/BTXW6vCbvkZCkklbHWBaFhdrymkVKx/Gug79sNlUZyViV0ECJHN1BH fdBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c5si18014404edk.64.2021.03.04.08.36.19; Thu, 04 Mar 2021 08:36:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235528AbhCDLUG (ORCPT + 99 others); Thu, 4 Mar 2021 06:20:06 -0500 Received: from mga02.intel.com ([134.134.136.20]:24230 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231703AbhCDLUA (ORCPT ); Thu, 4 Mar 2021 06:20:00 -0500 IronPort-SDR: cEXGGmCvqe3XP/p4USSNjHdwiy78GBBso3At+qxBFU9+t8W/plMkTM9z7BCCbIUJe/48WUX1Rg 6XT9wGo7Ivhw== X-IronPort-AV: E=McAfee;i="6000,8403,9912"; a="174510230" X-IronPort-AV: E=Sophos;i="5.81,222,1610438400"; d="scan'208";a="174510230" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 03:18:14 -0800 IronPort-SDR: 0IexT2k7f9Mxr2A/jkO4XKOGEFm3Lw2y/Aosl2JEJ1Qnf0m0jAkq2AkqgzqmgV7urv9LyLtNXA lg/U0arftNzA== X-IronPort-AV: E=Sophos;i="5.81,222,1610438400"; d="scan'208";a="384406967" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 03:18:12 -0800 Received: by lahna (sSMTP sendmail emulation); Thu, 04 Mar 2021 13:18:09 +0200 Date: Thu, 4 Mar 2021 13:18:09 +0200 From: Mika Westerberg To: Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Linus Walleij Subject: Re: [PATCH v1 1/1] pinctrl: intel: No need to disable IRQs in the handler Message-ID: <20210304111809.GO2542@lahna.fi.intel.com> References: <20210304105432.36544-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304105432.36544-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 04, 2021 at 12:54:32PM +0200, Andy Shevchenko wrote: > In IRQ handler interrupts are already disabled, hence no need > to repeat it. Even in the threaded case, which is disabled here, > it is not a problem because IRQ framework serializes descriptor > handling. Remove disabling IRQ part in the handler. > > Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg