Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH v4 03/15] pinctrl: bcm: add bcm63xx base code
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <CAHp75Vc_v5M9XjWei09KzXo_oo95b2WQSamMjdQvxkCzNXrSXg@mail.gmail.com>
Date:   Thu, 4 Mar 2021 12:17:22 +0100
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Michael Walle <michael@walle.cc>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        Jonas Gorski <jonas.gorski@gmail.com>,
        Necip Fazil Yildiran <fazilyildiran@gmail.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <667E0AEF-B453-4CC7-9514-5E72BEF4B0E3@gmail.com>
References: <20210304085710.7128-1-noltari@gmail.com>
 <20210304085710.7128-4-noltari@gmail.com>
 <CAHp75Vc_v5M9XjWei09KzXo_oo95b2WQSamMjdQvxkCzNXrSXg@mail.gmail.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Precedence: bulk

Hi Andy

> El 4 mar 2021, a las 11:43, Andy Shevchenko =
<andy.shevchenko@gmail.com> escribi=C3=B3:
>=20
> On Thu, Mar 4, 2021 at 10:57 AM =C3=81lvaro Fern=C3=A1ndez Rojas
> <noltari@gmail.com> wrote:
>>=20
>> Add a helper for registering BCM63XX pin controllers.
>>=20
>> Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas <noltari@gmail.com>
>> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
>=20
> This SoB is in a strange place.

Why?
Can=E2=80=99t we both sign the patches?

>=20
> The order is wrong taking into account the =46rom header (committer). =
So,
> it's not clear who is the author, who is a co-developer, and who is
> the committer (one person may utilize few roles).
> Check for the rest of the series as well (basically this is the rule
> of thumb to recheck entire code for the comment you have got at any
> single place of it).

Jonas was the original author of this patches (sent back in 2016) and =
I=E2=80=99m just continuing his work and trying to get those patches =
upstreamed.
I don=E2=80=99t know how to do it correctly, so a little hint would be =
appreciated.

>=20
> ...
>=20
>> +static const struct of_device_id bcm63xx_gpio_of_match[] =3D {
>> +       { .compatible =3D "brcm,bcm6318-gpio", },
>> +       { .compatible =3D "brcm,bcm6328-gpio", },
>> +       { .compatible =3D "brcm,bcm6358-gpio", },
>> +       { .compatible =3D "brcm,bcm6362-gpio", },
>> +       { .compatible =3D "brcm,bcm6368-gpio", },
>> +       { .compatible =3D "brcm,bcm63268-gpio", },
>=20
>> +       { /* sentinel */ },
>=20
> Comma is not needed in terminator line

Ok, I will remove it.

>=20
>> +};
>=20
> ...
>=20
>> +       dev_info(dev, "registered\n");
>=20
> Unneeded noise.

Ok, I will remove it.

>=20
> ...
>=20
>> +#include <linux/pinctrl/pinctrl.h>
>> +#include <linux/regmap.h>
>=20
> The rule of thumb is to include only the headers that the below code
> is direct user of.

Ok, so I will move them to pinctrl-bcm63xx.c.
I added them because they were needed for pinctrl_desc.

>=20
> The above are not used anyhow, while missed types.h and several
> forward declarations.

=E2=80=A6 so I should include linux/types.h and I don=E2=80=99t know =
what you mean by =E2=80=9Cseveral forward declarations=E2=80=9D=E2=80=A6

>=20
>> +#include "../core.h"
>=20
> Seems the same.

Ok, I will move it to pinctrl-bcm63xx.c.

>=20
>> +#define BCM63XX_BANK_GPIOS 32
>> +
>> +struct bcm63xx_pinctrl_soc {
>> +       struct pinctrl_ops *pctl_ops;
>> +       struct pinmux_ops *pmx_ops;
>> +
>> +       const struct pinctrl_pin_desc *pins;
>> +       unsigned npins;
>> +
>> +       unsigned int ngpios;
>> +};
>> +
>> +struct bcm63xx_pinctrl {
>> +       struct device *dev;
>> +       struct regmap *regs;
>> +
>> +       struct pinctrl_desc pctl_desc;
>> +       struct pinctrl_dev *pctl_dev;
>> +
>> +       void *driver_data;
>> +};
>=20
>=20
> --
> With Best Regards,
> Andy Shevchenko

Best regards,
=C3=81lvaro.