Received: by 2002:a05:6520:3645:b029:c0:f950:43e0 with SMTP id l5csp6270406lki; Thu, 4 Mar 2021 08:55:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxlDAJxpe+LUeXpWP1tUQ67YExOUqQwPzSNm/GAXhu/Y3jI6B47O09Z69VXbveLcJF/T2Xh X-Received: by 2002:a17:906:af84:: with SMTP id mj4mr5369920ejb.84.1614876903945; Thu, 04 Mar 2021 08:55:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614876903; cv=none; d=google.com; s=arc-20160816; b=R/BaeYoq6QjfE9/QxOs7Qo6tfJ+NA1aEB9uQbgVwtDc+hgsRxllDEKcxiVYDUj/5No +243dW/7NbsJQ9iNeHbOW+9KmH1NJkf1AT5MRAVUjTRstriWsCAEvjyS8xj3wNSbmJAr y1ESnU34RXYp8KOf3+L/fUF1FulJGwFI7RdH1sQOYu7x1kHsCLBWK09nyz0d7VItk+SI h0Lu6sh1irf+N7kHKG84SkLinPwklVqjB6ZTyxp/8vPYalQiDIhzugibDWNM7iqR8WiH o3Yw+7pdHBO5WPbDtnCkTn1J/dJmqxfzyj8cnASK6ENwO1JHfBFHsTo33hFe9ymADNES Rj3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=XiYssDwn8aWrUUPIZ0bSaYBRfxID6/TO2DA4DbU08gw=; b=W92WFvf9hMz7X0sN8ogGdj6/5IUZ/yKcEfknLOogRGujSHrahvT9m/ritiEloSPNp0 eGyh4NWc3Z8cSzM9O3gUW3G6gMbk5PyY5gEefcTNShh7rgJBMyc0m+OXUVA/wB6qpYRY ANr7CUMus0avTa/hVRqndeP4ZQsTZggHyHGpd8JhPpooKTjcNJfKK5B856drkjuPmsDk C0oUQ67puMBKPik7ZE4j1m7hFWprgABBIMLrYCBzluVZFw2HzGaF30QFbTqcN912wbhq a4kCcfr/Xxs43lUypaAfoWZysiZQqwWzA4KUYCUA9mefIve70GRWGqIYJsnSCYFOcUPb OLvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Cp6p/NsI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jg13si18325741ejc.661.2021.03.04.08.54.40; Thu, 04 Mar 2021 08:55:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Cp6p/NsI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240321AbhCDMNh (ORCPT + 99 others); Thu, 4 Mar 2021 07:13:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240314AbhCDMNN (ORCPT ); Thu, 4 Mar 2021 07:13:13 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B8B5C061756; Thu, 4 Mar 2021 04:12:33 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id d8so5609116plg.10; Thu, 04 Mar 2021 04:12:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XiYssDwn8aWrUUPIZ0bSaYBRfxID6/TO2DA4DbU08gw=; b=Cp6p/NsItZt7stLd/mzS/+xf5wYb4MkM7EV/fHzz1DwPr6Bu3dUmmcazULu1liqRYk Q7clx12lHzMR/irFaWFLoeTfARoa6W+A5Z3BjPwhvqQpUm511ujvGM1VB0RufoP1B5e/ 811P8LGtlEJjBrwmx1fa56IXlmBznn8Vlcs2mXuiwteIizFmh15HFCTy0J9E+CbbeEe8 e1FvW6clLErvKs3dozck8Zt53xIMDwc260wTnL6go7jUsP4VQmj0u8S3QllMm/wnJiEL XIWPzIhCKpPkMrqmq0OF4owS5/RUms50V0L9hZ+Wj9lS7U1KAtxZ54yQDqpxz67aLHXZ nfQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XiYssDwn8aWrUUPIZ0bSaYBRfxID6/TO2DA4DbU08gw=; b=pOCWk8R+NjLMMdwiimKvTmFLcpd4s3aNI1rOrjWDotn7wNI6MZdfcRH2UGYfzNV38M K8EryyOmeSj/VK5lRHz/hrDYUqMwpLkpwafCJy0Bp3U4CNmdxclgDTQ1ewG58Uhq/tD4 Vr9OEq4m8ZXPXce461z3TklBfXgLt79M71QftGMoQ/mmVENoRb5I1+v1nQ8GXYkdUKM0 8d6zyVFhxLBedYaSTbks7l4cAoFf6JAueZqPv6TQjzG+yFtBAPqqv7NFqd2bhukt923g RT9gKJyS5aqgq2nFVwincwO7c/QflfBJLQfWAcA7hPhjozBR6hLKwIPnT8wNO1GUEQ2k X49g== X-Gm-Message-State: AOAM530LaZzxYJ3HHJzPxsiPlou2aOjUJ+ymXl3jdZi9XJXt6lYg3i7k 2XNnrcbfVGG7NeC0oTDYhZmL/V6GSeGAA6us7DY= X-Received: by 2002:a17:90a:db49:: with SMTP id u9mr4363678pjx.181.1614859952809; Thu, 04 Mar 2021 04:12:32 -0800 (PST) MIME-Version: 1.0 References: <20210304085710.7128-1-noltari@gmail.com> <20210304085710.7128-6-noltari@gmail.com> In-Reply-To: From: Andy Shevchenko Date: Thu, 4 Mar 2021 14:12:16 +0200 Message-ID: Subject: Re: [PATCH v4 05/15] pinctrl: add a pincontrol driver for BCM6328 To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= Cc: Linus Walleij , Rob Herring , Michael Walle , Bartosz Golaszewski , Florian Fainelli , bcm-kernel-feedback-list , Jonas Gorski , Necip Fazil Yildiran , "open list:GPIO SUBSYSTEM" , devicetree , Linux Kernel Mailing List , linux-arm Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 4, 2021 at 1:13 PM =C3=81lvaro Fern=C3=A1ndez Rojas wrote: > > El 4 mar 2021, a las 11:49, Andy Shevchenko = escribi=C3=B3: > > On Thu, Mar 4, 2021 at 10:57 AM =C3=81lvaro Fern=C3=A1ndez Rojas > > wrote: ... > >> + static const unsigned int bcm6328_mux[] =3D { > >> + BCM6328_MUX_LO_REG, > >> + BCM6328_MUX_HI_REG, > > > >> + BCM6328_MUX_OTHER_REG > > > > When it's not terminator add a comma, otherwise remove a comma. > =E2=80=A6 so you want me to add a comma or not? Hmm... you tell me! If this is a list which covers all possible cases _and_ the last one is the kinda maximum value (aka terminator), then comma is not needed, otherwise add it (to me feels like the latter should be done here). > > Also, why is it inside a function? It's anyway global and constant. > > Because this is only used by this function and I=E2=80=99m used to doing = this to comply with MISRA C 2004 at work :) It makes code a bit harder to read. > >> + }; --=20 With Best Regards, Andy Shevchenko