Received: by 2002:a05:6520:3645:b029:c0:f950:43e0 with SMTP id l5csp6283408lki; Thu, 4 Mar 2021 09:12:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJylMB0DOviWj9GcCxiOEj8PRbExaO+/C3jTILAGYqrJLIzfz9xb9yWwi0i7hC79wOuHrD+l X-Received: by 2002:a17:906:aada:: with SMTP id kt26mr5248210ejb.137.1614877922070; Thu, 04 Mar 2021 09:12:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614877922; cv=none; d=google.com; s=arc-20160816; b=HvoJdLAJPRguoDJZkHTN949rBv/YajJvTaDX+j8y10MFUTkkC3z7VvQSILFKv5ScQA jyBBNQ+4ta9/gYVvxgvePt9njtVCpJg/oI/6n2xygLfl4MJqSfV58vtFOc6iz8OhAINr oTABOw2iSCB2lXhYLcNozNqnlq5imo87WiZ8VoYpB8lnDrglIXwJN2ETkyiRWy9KsIKw W4U1r7cw/oOnWxcbc5WU6pFqF4GuBriYvrLsylS7nRhx/fyyytbl1bA/FpayiKDu4Atv EBbT+gR5jlSvDV7e9S5K+h/UQAVEHbSOvM4ue8RijP/1oQNzz9CQrrhTi2Ejz1hQ9sZY vlXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=yE+Ssmpimz7dmCKEO/vyCATVmd+XfMQ28oWf0PkpBuo=; b=z99/MEm6JxLPUmpe8wo3R4Edz8F53oxq92XeGikZI9wloObSRc5GtT1DG2fraUqWxe 5N+eOK42xwNoX++9TqKhDSF4D3vY9iLvXfLvOOdao3MT7BJzwnsp39VbOaat/LWVldyj NURyLuc6djn99CBtcd5MZ2b/8m1CJA9OcpZnh1SUVqpv4VBGT0RWNxlCZJr4IFZqHEHh GBkez45iv800Nezc+gxlSbBHsaEAdbnS13V5vKVezPqVDLJdkd+S9C58JjJhxQrckTqC YE09XlwvH//nTV6khuwEaqI3j69y5VOqSjyY6RtSeY3I/FBwUNaANb9sdc20TR+6EhhU KW8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jg13si18325741ejc.661.2021.03.04.09.11.36; Thu, 04 Mar 2021 09:12:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240792AbhCDMdX (ORCPT + 99 others); Thu, 4 Mar 2021 07:33:23 -0500 Received: from 8bytes.org ([81.169.241.247]:57642 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240602AbhCDMdO (ORCPT ); Thu, 4 Mar 2021 07:33:14 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id 603EB321; Thu, 4 Mar 2021 13:32:33 +0100 (CET) Date: Thu, 4 Mar 2021 13:32:31 +0100 From: Joerg Roedel To: Zenghui Yu Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, dwmw2@infradead.org, baolu.lu@linux.intel.com, will@kernel.org, jacob.jun.pan@linux.intel.com, eric.auger@redhat.com, yi.l.liu@intel.com, kevin.tian@intel.com, wanghaibin.wang@huawei.com Subject: Re: [PATCH] iommu/vt-d: Fix status code for Allocate/Free PASID command Message-ID: <20210304123231.GE26414@8bytes.org> References: <20210227073909.432-1-yuzenghui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210227073909.432-1-yuzenghui@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 27, 2021 at 03:39:09PM +0800, Zenghui Yu wrote: > As per Intel vt-d spec, Rev 3.0 (section 10.4.45 "Virtual Command Response > Register"), the status code of "No PASID available" error in response to > the Allocate PASID command is 2, not 1. The same for "Invalid PASID" error > in response to the Free PASID command. > > We will otherwise see confusing kernel log under the command failure from > guest side. Fix it. > > Fixes: 24f27d32ab6b ("iommu/vt-d: Enlightened PASID allocation") > Signed-off-by: Zenghui Yu Applied for v5.12, thanks.