Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Mar 2021 10:22:59 -0500 (EST)
From:   Bob Peterson <rpeterso@redhat.com>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     agruenba@redhat.com, cluster-devel@redhat.com,
        linux-kernel@vger.kernel.org
Message-ID: <669736422.59715790.1614871379550.JavaMail.zimbra@redhat.com>
In-Reply-To: <1614850640-63803-1-git-send-email-yang.lee@linux.alibaba.com>
References: <1614850640-63803-1-git-send-email-yang.lee@linux.alibaba.com>
Subject: Re: [PATCH] gfs2: make function gfs2_make_fs_ro() to void type
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: gfs2: make function gfs2_make_fs_ro() to void type
Thread-Index: tP8ZFycLfqsXQRyPZDKwsUS7L7wEUg==
Precedence: bulk

----- Original Message -----
> It fixes the following warning detected by coccinelle:
> ./fs/gfs2/super.c:592:5-10: Unneeded variable: "error". Return "0" on
> line 628
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  fs/gfs2/ops_fstype.c | 4 +---
>  fs/gfs2/super.c      | 9 +++------
>  fs/gfs2/super.h      | 2 +-
>  fs/gfs2/util.c       | 2 +-
>  4 files changed, 6 insertions(+), 11 deletions(-)

Thanks. Your patch is now pushed to linux-gfs2/for-next.
I did one minor cleanup: Function gfs2_put_super in super.c no longer
needed the variable "error" so I removed it to avoid warnings.

https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=0e787a0bfabb8be323f575d5cdda48e607840eb5

Regards,

Bob Peterson