Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1440091pxb; Thu, 4 Mar 2021 11:17:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5Fuffd8jtxuV/GzSepIFi8bYKYCLMznAEjMmyCeNRRkbf52dirQoVUmQfOX0pU+vUDyf9 X-Received: by 2002:a17:906:cc89:: with SMTP id oq9mr5956524ejb.258.1614885471495; Thu, 04 Mar 2021 11:17:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614885471; cv=none; d=google.com; s=arc-20160816; b=cFgF67iiE6x14u8oMQ6JgzJm/urzXJ8XOngH7A7ELmnPW3eZMpqA9NgORknvObjzZk Ok1wI/5/ih8p7hqGp6Pd45YzBfOFcq1A1+df+41PJqj6UKuh61uaVKsF9hy9wI0CEq2M MRwQENi06UxWnOc+KMrzOvm1VN5nMwFfstw1SYBUU3rUCtbnQN2O6jh7ZSsaQL7tPCTV xTGBym7XZjbcVXMtY++SQFNJpv7OZPI0UMAfl6d/0RKMFgzOQTvchmjGA8XJ9um2xaj7 uMpDlbLKmElCZJ4+v3REK0FvCr02xce5Lm2x8moGMtXMHNsWTS2w9uI80tKs4WbFKaCz bQRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=rhbazE44Fq5VfyWjKwf9zuQsAn8On7g+SsZ62Ovv5F8=; b=Bve4umkOVgLDMp1M69VdxOLqlgg5Jlz3K7mzTAcu7ziZshVr/CMmGr3TBOLWqGzatw u1C+5vQXQyU3M8l7ICODclWwnnPX1qXTPXtQkAJMUGses610/jn2h0guOqlbs0UCoCZK Yw6dKhKEQshi+xZucj4kwrlJm/k12TcFKuFHXQ6wTTz0BoRbWS57Q+UdCPyiY9RfAIYJ GR9bMIoy7dk4kK9hrOnNRQk2bJOPrYZc2bVR/Y5/dIjoH3czBgxNcmZ8h0Qbq6fvt+kO UqfXlA7uyAsEerbPTa1eEwQvJsxZidjF2Xy5S1X8sk4upfnI0ibjHts655yEP3R09pNq V6fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="C+c/9+vw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r26si252116edc.478.2021.03.04.11.17.27; Thu, 04 Mar 2021 11:17:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="C+c/9+vw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231138AbhCDTLr (ORCPT + 99 others); Thu, 4 Mar 2021 14:11:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231544AbhCDTLV (ORCPT ); Thu, 4 Mar 2021 14:11:21 -0500 Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4BDBC06175F for ; Thu, 4 Mar 2021 11:10:40 -0800 (PST) Received: by mail-vs1-xe29.google.com with SMTP id t23so15193283vsk.2 for ; Thu, 04 Mar 2021 11:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rhbazE44Fq5VfyWjKwf9zuQsAn8On7g+SsZ62Ovv5F8=; b=C+c/9+vwbzsfKbij8AjOmUq58ukoKryzZ43Oi4y+MSpEXBwS2iKiuF+8DoMQ+gzvEP J4mgYFdtljDghVEszECgjhT1F+i0bS/c/Jz8FGOfU9RvZcFXCjjeVCiYP5J440IBAC+Q ztcBQwtSlOe8xzxT8QjD/N7PtwkjqCCJ37ZG4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rhbazE44Fq5VfyWjKwf9zuQsAn8On7g+SsZ62Ovv5F8=; b=Z+/w5TVPBM6bti0T2pkfgAZFG69IPJWeIFqlge3CGEAoPFxufcxgcpDHdi/8MnhfWA YZKyMMlAeSzG2Wf/mcM9+fL1b9JeNeM9V/Q3Bh07QI6w9TzDJJXH4NYexhOimni6mADk lklkQ37F6mIYbtrpIqFOwSQkiuyDWi2mztCsbEvLTyReU6exVqQaYXk3DHuaswVSqrXs tPDZbk8XV9o/DMhoS4+2wbDxmbBVOczQ0eXloNLcIH75j11amw5oio8BOYiBBmCbL3Oj Y4dpKOWsjWuNxLEJBkxTMPBYKGsxO7IuhhUNPZE19QxgQJOa8vroRBXNdF62WIoUovTI 7Mow== X-Gm-Message-State: AOAM533RTgagR9YCOMGj3Ut8KLXFz6ftNUMAqkZEPl9cFZIz8gsb4lqn p8ON+UZKCeJfKBegsP/RyxokgVZ/qJK8rtoKlH53Bw== X-Received: by 2002:a05:6102:ac2:: with SMTP id m2mr3757112vsh.52.1614885039545; Thu, 04 Mar 2021 11:10:39 -0800 (PST) MIME-Version: 1.0 References: <20210120011208.3768105-1-grundler@chromium.org> <0a5e1dad04494f16869b44b8457f0980@realtek.com> <20210120090438.0f5bba6e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210120090438.0f5bba6e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Grant Grundler Date: Thu, 4 Mar 2021 19:10:28 +0000 Message-ID: Subject: Re: [PATCH net] net: usb: cdc_ncm: don't spew notifications To: Jakub Kicinski Cc: Hayes Wang , Grant Grundler , Oliver Neukum , "David S. Miller" , nic_swsd , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 5:04 PM Jakub Kicinski wrote: > > On Wed, 20 Jan 2021 03:38:32 +0000 Hayes Wang wrote: > > Grant Grundler > > > Sent: Wednesday, January 20, 2021 9:12 AM > > > Subject: [PATCH net] net: usb: cdc_ncm: don't spew notifications > > > > > > RTL8156 sends notifications about every 32ms. > > > Only display/log notifications when something changes. > > > > > > This issue has been reported by others: > > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1832472 > > > https://lkml.org/lkml/2020/8/27/1083 > > > > > > Chrome OS cannot support RTL8156 until this is fixed. > > > > > > Signed-off-by: Grant Grundler > > > > Reviewed-by: Hayes Wang > > Applied, thanks! > > net should be merged back into net-next by the end of the day, so > if the other patches depend on this one to apply cleanly please keep > an eye and post after that happens. If there is no conflict you can > just post them with [PATCH net-next] now. Jakub, sorry, I "dropped the ball" on this one. I'll repost with "net-next" a bit later today. cheers, grant