Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1480122pxb; Thu, 4 Mar 2021 12:25:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJygJ4SvKYvupqrY9PL3/ulkxAhYtvDZ+eSi2kK9OneDb4/6ZbxvxLwIyY5+ayIXm9x8rYBl X-Received: by 2002:a17:906:1b41:: with SMTP id p1mr681035ejg.174.1614889513510; Thu, 04 Mar 2021 12:25:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614889513; cv=none; d=google.com; s=arc-20160816; b=KrNQ0JlbSdE/wRm3etDCQybW9/21dwCaRMpfQUb5xnWn8FTMIwikh5h8VzrueYTLWA lMjbgs6z5gTD3WvnWXHs+9Te+rRIR4tMwyh22ltibvrs1gvpKDS55A8+VPkaV6hmlMjX kxam3MWTE3sPGsXJLfMbffobLCthtKHO28jXb5KJHE0E4Reu0EJNrugvM2rynqZ6+kzj 2+FH5JbOmCn89VHATIjz0F04dWyY45iJ8uv9KU9K4GqcAy00yt/SWopsb+7l4b4GEdpv FSsFseNsO5KOmeZA/rL2ffFTqpTovdeYoZdZHPHe7RIvLOdQ35Eq5BrquFG+Vdt23ITz A2OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=QpFfixSfI0IXTUKVxxfkDvRqFlpfOA0zwhqqY5WVyhU=; b=vQoEJ3IWGQNMpoK1urwP6x1oGu0pI9MDH/waPJCikjnpeSThvUzOiT1imUNZ9E3qrt S5XJX5a+hUiyej2wpslGuHB8AeoOTOBiSeu8iCb06Pp7Q3Op+9hzempqAWsJ3aunYlKK eFdCHUzrJcaeuakQ2BThvKXek0cBZZ2hwut52CghMCgBNCxcxHL6yAsBXZJa2PY4XFYy hiXmjrq5F0zcVI5XBWWBrYJVIGSK/acoypLHjBCH3KsrQWorjBLTVd+QflaB7MqOPLy7 oGufc/GVJFfxQh+HkErS6UXoRo9fq/r07TkdO5lksiExUntUJbmPj0sPIomnTuxyiUEk msUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j10si131924eje.450.2021.03.04.12.24.50; Thu, 04 Mar 2021 12:25:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1837062AbhCBUam (ORCPT + 99 others); Tue, 2 Mar 2021 15:30:42 -0500 Received: from mslow2.mail.gandi.net ([217.70.178.242]:42755 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350063AbhCBRtA (ORCPT ); Tue, 2 Mar 2021 12:49:00 -0500 Received: from relay9-d.mail.gandi.net (unknown [217.70.183.199]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 902CE3A88B0; Tue, 2 Mar 2021 16:35:58 +0000 (UTC) X-Originating-IP: 86.206.8.148 Received: from xps13.stephanxp.local (lfbn-tou-1-491-148.w86-206.abo.wanadoo.fr [86.206.8.148]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id E999CFF80E; Tue, 2 Mar 2021 16:32:42 +0000 (UTC) From: Miquel Raynal To: Dan Carpenter , Miquel Raynal , Vipin Kumar Cc: Fenghua Yu , Tony Luck , Vignesh Raghavendra , Richard Weinberger , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Boris Brezillon , linux-mtd@lists.infradead.org Subject: Re: [PATCH] mtd: rawnand: fsmc: Fix error code in fsmc_nand_probe() Date: Tue, 2 Mar 2021 17:32:42 +0100 Message-Id: <20210302163242.23393-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: d49ecd70c82d89c7448f5623ae08d0a4a488dc72 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-02-15 at 15:58:49 UTC, Dan Carpenter wrote: > If dma_request_channel() fails then the probe fails and it should > return a negative error code, but currently it returns success. > > fixes: 4774fb0a48aa ("mtd: nand/fsmc: Add DMA support") > Signed-off-by: Dan Carpenter Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel