Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros
To:     Vinod Koul <vkoul@kernel.org>
Cc:     rafael@kernel.org, andriy.shevchenko@linux.intel.com,
        linux-kernel@vger.kernel.org,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Amelie Delaunay <amelie.delaunay@st.com>,
        Etienne Carriere <etienne.carriere@st.com>,
        Chunfeng Yun <chunfeng.yun@mediatek.com>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>
References: <20210224144222.23762-1-daniel.lezcano@linaro.org>
 <20210224144222.23762-9-daniel.lezcano@linaro.org>
 <YD5olWDZ50sLVn7w@vkoul-mobl>
 <e44809f1-63a6-8c8b-a05f-52516fb2141f@linaro.org>
 <YD8hNs98g172DiF8@vkoul-mobl>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
Message-ID: <207d37f7-f99f-03ab-7914-d2b82977a95f@linaro.org>
Date:   Wed, 3 Mar 2021 07:09:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YD8hNs98g172DiF8@vkoul-mobl>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 03/03/2021 06:40, Vinod Koul wrote:
> On 02-03-21, 18:03, Daniel Lezcano wrote:
>> On 02/03/2021 17:32, Vinod Koul wrote:
>>> On 24-02-21, 15:42, Daniel Lezcano wrote:
>>>> HZ unit conversion macros are available in units.h, use them and
>>>> remove the duplicate definition.
>>>>
>>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>>> ---
>>>>  drivers/phy/st/phy-stm32-usbphyc.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
>>>> index a54317e96c41..02dd12bb4692 100644
>>>> --- a/drivers/phy/st/phy-stm32-usbphyc.c
>>>> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
>>>> @@ -14,6 +14,7 @@
>>>>  #include <linux/of_platform.h>
>>>>  #include <linux/phy/phy.h>
>>>>  #include <linux/reset.h>
>>>> +#include <linux/units.h>
>>>>  
>>>>  #define STM32_USBPHYC_PLL	0x0
>>>>  #define STM32_USBPHYC_MISC	0x8
>>>> @@ -48,7 +49,6 @@ static const char * const supplies_names[] = {
>>>>  #define PLL_FVCO_MHZ		2880
>>>>  #define PLL_INFF_MIN_RATE_HZ	19200000
>>>>  #define PLL_INFF_MAX_RATE_HZ	38400000
>>>> -#define HZ_PER_MHZ		1000000L
>>>
>>> I dont see this in units.h, can you send this once it is merged upstream
>>
>> Actually, it is the first patch of the series.
>>
>> I asked Rafael if he can merge the entire series.
> 
> Pls cc folks on cover at least so that they are aware.

Yeah, sorry for that. I tend to rely too much on the default 'cccmd'.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog