Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: G74SV63rezumexV4OVufwISfMpOeHqABQUq+tclndUzXBQnWqsxAlg4YAwIA6kMJsNhrN+jT3r
 3JHPzLjXCy5Pcyn4xf4zdT1VJNPozuqi4S+NGe7XQ1tRahP201bIK8NPq3+x4DEfhKQBg+70R5
 dKY8XxIjlBgcllz2smmtqywfYF9tLcap/ps9l07R0HM6lUQx2v8Esd2kxgsMLrMPA8wmhXiIY3
 Uz44pciWhfR8/nh/c+dC8h/o1nvNs6r5jXz5z7C8cHZae/vOO2e1CsOXXcJzd5BMk7I6A3ks1R
 PmI=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <cang@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
        "hongwus@codeaurora.org" <hongwus@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>
CC:     Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        Jaegeuk Kim <jaegeuk@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 3/3] scsi: ufs: Remove redundant checks of !hba in
 suspend/resume callbacks
Thread-Topic: [PATCH v2 3/3] scsi: ufs: Remove redundant checks of !hba in
 suspend/resume callbacks
Thread-Index: AQHXCm9gO8v0f6H3g0amtwRrqOzM0qpx5goQ
Date:   Wed, 3 Mar 2021 07:19:22 +0000
Message-ID: <DM6PR04MB657592719F6C029BA23B49E3FC989@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <1614145010-36079-1-git-send-email-cang@codeaurora.org>
 <1614145010-36079-4-git-send-email-cang@codeaurora.org>
In-Reply-To: <1614145010-36079-4-git-send-email-cang@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 76c5b6dd-fa2e-4b73-9fd5-08d8de14aaf2
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2021 07:19:22.0410
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oJQKiiqlNztkBGjll19wpyRmMFTSNOexFIVM+WOXaBH1bTujypUvZd8B2t3CkkDT30rZmCJ4aXTpQUpZMXDQuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB0970
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> Runtime and system suspend/resume can only come after hba probe invokes
> platform_set_drvdata(pdev, hba), meaning hba cannot be NULL in these PM
> callbacks, so remove the checks of !hba.
>=20
> Signed-off-by: Can Guo <cang@codeaurora.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>


> ---
>  drivers/scsi/ufs/ufshcd.c | 21 ---------------------
>  1 file changed, 21 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 013eb73..2517ef1 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -95,8 +95,6 @@
>                        16, 4, buf, __len, false);                        =
\
>  } while (0)
>=20
> -static bool early_suspend;
> -
>  int ufshcd_dump_regs(struct ufs_hba *hba, size_t offset, size_t len,
>                      const char *prefix)
>  {
> @@ -8978,11 +8976,6 @@ int ufshcd_system_suspend(struct ufs_hba *hba)
>         int ret =3D 0;
>         ktime_t start =3D ktime_get();
>=20
> -       if (!hba) {
> -               early_suspend =3D true;
> -               return 0;
> -       }
> -
>         down(&hba->host_sem);
>=20
>         if (!hba->is_powered)
> @@ -9034,14 +9027,6 @@ int ufshcd_system_resume(struct ufs_hba *hba)
>         int ret =3D 0;
>         ktime_t start =3D ktime_get();
>=20
> -       if (!hba)
> -               return -EINVAL;
> -
> -       if (unlikely(early_suspend)) {
> -               early_suspend =3D false;
> -               down(&hba->host_sem);
> -       }
> -
>         if (!hba->is_powered || pm_runtime_suspended(hba->dev))
>                 /*
>                  * Let the runtime resume take care of resuming
> @@ -9074,9 +9059,6 @@ int ufshcd_runtime_suspend(struct ufs_hba *hba)
>         int ret =3D 0;
>         ktime_t start =3D ktime_get();
>=20
> -       if (!hba)
> -               return -EINVAL;
> -
>         if (!hba->is_powered)
>                 goto out;
>         else
> @@ -9115,9 +9097,6 @@ int ufshcd_runtime_resume(struct ufs_hba *hba)
>         int ret =3D 0;
>         ktime_t start =3D ktime_get();
>=20
> -       if (!hba)
> -               return -EINVAL;
> -
>         if (!hba->is_powered)
>                 goto out;
>         else
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linu=
x
> Foundation Collaborative Project.