Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1525864pxb; Thu, 4 Mar 2021 13:45:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJyGT5QFYeMYxIXrd4utaPX2Jb1c3m+XZ0K0IlTfXaMfcIgnvPRSrltFh1Ibtzpr64J622Se X-Received: by 2002:a05:6402:34d:: with SMTP id r13mr6717641edw.64.1614894336433; Thu, 04 Mar 2021 13:45:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614894336; cv=none; d=google.com; s=arc-20160816; b=Dq6BiWLdFTEDxohV/G9lZTX+Rs1QzYZFOg3/G3ex6hfzO63UAyAkknBsuvXXoYVyR5 R7iODCiQ9hH+IRFkdQqrFtwapGtMTgwp1R23qQNSQLItNFLDFhqWCsAYSuUWPtYoCiPa 2C7cUImJV3fzzn83Imj5RzJo3XXf0nro8DARps00R0HcB3TC4Kyz2u0WTcm5A5fpxSf2 TvvaOJX2YpjaaVOKmphMhPng2DiPo+dojH9VLkxVQKk4hMQlrzX7Qh8audYOjRZdrAPy pE1zNKvHFwYQcw5CcwbRPvCTPWdLQh7DRY/t7rUYqRZ21W1HaOWqOnqBDKwoShxqVKR4 C94g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=VgVOuS1QdOahuh5eYdd3kUCTER6wTGX5ASCqQ/qR98c=; b=CCEMyAjqgbiuKlbZJIiwu5pcUqi3CZSvj24HkBoBo6AUPZEVD5aqAOl8ZGSPsN0TeX sNYUOk7EqC671ylUDwe0AIUaH9IKpfLZn1GILHy+sE+Y1oAHu02sMYs1iKA4p54SddRp 7hoVL+MqWBdgm8vD5ZfxD7FTk2Oa9+cb6LiLyuLCXrdlNgBWteoS6Lgd+u7LrhJpoe9N vDVBSHsoX80SbMkgHt5vPeJvK9jZGnTp6O/jN5RI9J4aC9Xdlx1cNzjIP48QmrILQBxE zeZTegkAEOurRvfZAPaWsBDlUH7UzfQjD/pV6s1vFQSgfLjYhRfk/+rskoD97ZvNOE3v Q3KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PV84WwDH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kf1si275600ejc.262.2021.03.04.13.45.13; Thu, 04 Mar 2021 13:45:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PV84WwDH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383498AbhCCOjD (ORCPT + 99 others); Wed, 3 Mar 2021 09:39:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1842999AbhCCKXf (ORCPT ); Wed, 3 Mar 2021 05:23:35 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61624C0698CA for ; Wed, 3 Mar 2021 01:08:15 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id p15so18735276ljc.13 for ; Wed, 03 Mar 2021 01:08:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VgVOuS1QdOahuh5eYdd3kUCTER6wTGX5ASCqQ/qR98c=; b=PV84WwDH6AoIAOjPzcHF9gE4Neg+FF/n1iEVa9iM65O+VfmQa9SUJspvze3Ds0xmtY VNut1Zk3DzlViqxwSvsvuf2JVU9tvSiu8Jd7xGnmvLBgUU3puYPJhikl0UX+4XXieKWa 0rBqqTyvMMomXbLELCv8FgnG/eoUUWmsOtdry2CoDH+WMqGh6PqtEV4hXY+zKsXY4MnH jlaX4DJR0JZO3wuG0cuLJAjfoZFo9/JgjIpSy3d5HhWgLztRgRmdt/Tf3ka3ih1qDVBg 0Lfnm/rCtgSa17A7JRAqFsZsNDEhZYxVttvZ2/NEaXX+V2IObPQuwhqk1B/N3edNREZt vxRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VgVOuS1QdOahuh5eYdd3kUCTER6wTGX5ASCqQ/qR98c=; b=fYZt8EdcSrAame2OebLCRuxtblgIkVCd4GZESPPcL9jPoqylelRu08oLPNQNanNKAG TZJr6jXWqPOIyDMPuc0nsmH0XmsDceQxvZNB9arhmOSlNz6cPe9k8BloEO/zuPv9VPFy SKCotn+z9XLVK7RIJU4b/GA/vEXSPHjzXknqirfRCS1LIMhR1COBTNIuPvKD9ITAbvLN zOLBgaCcWq858XbRjP2Lmfe8jAACHPpJony1lB+uN0h8NLMP41lVPZzO1Bh6v9egri1H O/YaNlQyHgpkp2IxWhcYa7zgNOPg2am9b4Y9A4/KkMgHqrTtREjfzas1PvLbtcb43iV/ Ej7w== X-Gm-Message-State: AOAM531vfOSd3kIBgbEiaW6lZ/h02IjG0j4CJUKNCrqwUZdNVJBss+hF liKqSdvKoY0nLMnzgDGlTZG949e/GyZN1mHco3qilw== X-Received: by 2002:a2e:7001:: with SMTP id l1mr1351194ljc.200.1614762493875; Wed, 03 Mar 2021 01:08:13 -0800 (PST) MIME-Version: 1.0 References: <1614303297-24178-1-git-send-email-yang.lee@linux.alibaba.com> In-Reply-To: <1614303297-24178-1-git-send-email-yang.lee@linux.alibaba.com> From: Linus Walleij Date: Wed, 3 Mar 2021 10:08:03 +0100 Message-ID: Subject: Re: [PATCH v2] pinctrl: ingenic: add missing call to of_node_put() To: Yang Li Cc: Paul Cercueil , linux-mips@vger.kernel.org, "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2021 at 2:35 AM Yang Li wrote: > In one of the error paths of the for_each_child_of_node() loop in > ingenic_gpio_probe, add missing call to of_node_put(). > > Fix the following coccicheck warning: > ./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function > "for_each_child_of_node" should have of_node_put() before return around > line 2489. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Oops applied this rather than v1. Yours, Linus Walleij