Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1527507pxb; Thu, 4 Mar 2021 13:48:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJyKZiNG2BH2TyKT2ffMX2wzWwG7cgtrJf5q9GvGX9PtPKPgX0SWrpuTPJJmcHxeXtqOp/Xd X-Received: by 2002:a17:906:1f42:: with SMTP id d2mr6460201ejk.297.1614894528835; Thu, 04 Mar 2021 13:48:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614894528; cv=none; d=google.com; s=arc-20160816; b=hcYLCdyTgnxlMBq8fleBQlAVPRnzRixJ57W9MW7nQj6a8bmeYC9AOfpjCM/svPFKPR kFguvTlYHWncpMdFpjWBEuPJzGtv9mMpBcsmg3jTXn8tdldmG9ydOZbiCRtXPSMtx3rI jd7Pa6VaLRqaWByR5cHy2TUxLea4uIohxi0HQ+n+j64OyFvPzW9UIU9aqg7Ur4sU5DFR mNtW1ubBoDdlFIGFaKhvttDMByjmgn+veeWeigbuyVH/pDAlRP0rthcR15Qu7jgfZT3p kIy+4l5/CH0gGmBw4z/TUM3pxhgSzB/RUJVzo8XXq7mZYiHy5C9MMrNvGytBkQQQgjEU Wb/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=CV3tkp8merYe5w3jgDlwc9oNvGcc86ob13BJ0IDLoJA=; b=EWfmN7+3HTEA421kqRbKHVkIpredw33xAMbx9vcTP5SrJWznTr8kD/G8tPksC56aaw aEE9ZCVNsaPcycYaPAEYq+mRK6LXrFFe1+8cTvgLW3qPMFdsXJaojZC93VsYECDJz5yf 48LoJm+dRaG0uwB3U2OsjGnKQjd3n+Clm7sZtgbbRDFxtDjy15k0L9khWjh8GDy50oIa 3VvxZPwU35Kpj613AywT8JJwinFercFVwN1v/qTDmpezPcN4aHZnJWFWf1I2s+L97s1t Jbn8vh0hEGfeeSygjpSnpIC/fsq5tdpGljrTwsY5Q+z2C2zfKgZlq+j1BUa6lhSQQeQV 9N6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DufhUQrd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l12si487513edn.84.2021.03.04.13.48.25; Thu, 04 Mar 2021 13:48:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DufhUQrd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1572966AbhCCPEy (ORCPT + 99 others); Wed, 3 Mar 2021 10:04:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:40681 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232694AbhCCK0d (ORCPT ); Wed, 3 Mar 2021 05:26:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614767107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CV3tkp8merYe5w3jgDlwc9oNvGcc86ob13BJ0IDLoJA=; b=DufhUQrd91o3yvpW6ozd46tjY/uLdDgLfmvYm+QYN+nSniehJdjar5o1Rznm/Hs4c31lWQ 8vqKe5VKxgntGf3S2YqSWBBsUtqRYmxaUJ1ybTNzb3Hps79vOsLNeyn/gFaCGzmzmtnni8 RH7wT0f/x4GSZb4/Wve+z5eA6ZqQGsw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-45-_nJ8wJuPNCmgdVZduZEvbQ-1; Wed, 03 Mar 2021 03:23:25 -0500 X-MC-Unique: _nJ8wJuPNCmgdVZduZEvbQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7E991100962A; Wed, 3 Mar 2021 08:23:24 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-119-68.rdu2.redhat.com [10.10.119.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 356AE60BFA; Wed, 3 Mar 2021 08:23:23 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210303064028.895953-1-weiyongjun1@huawei.com> References: <20210303064028.895953-1-weiyongjun1@huawei.com> To: Wei Yongjun Cc: dhowells@redhat.com, Hulk Robot , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] afs: Remove unused variable in afs_req_issue_op() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2025007.1614759802.1@warthog.procyon.org.uk> Date: Wed, 03 Mar 2021 08:23:22 +0000 Message-ID: <2025008.1614759802@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wei Yongjun wrote: > GCC reports the following warning with W=1: > > fs/afs/file.c:291:6: warning: > unused variable 'ret' [-Wunused-variable] > 291 | int ret; > | ^~~ > > After commit 799fbdf96cd51, this variable is not used in function > afs_req_issue_op(), so this commit remove it to fix the warning. > > Fixes: 799fbdf96cd51 ("afs: Use new fscache read helper API") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun I've already fixed that and updated my branch, thanks. linux-next should pick it up on the next merging. David