Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: next-20210302 - build issue with linux-firmware and rtl_nic/
 firmware.
To:     =?UTF-8?Q?Valdis_Kl=c4=93tnieks?= <valdis.kletnieks@vt.edu>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>
References: <199898.1614751762@turing-police>
 <02b966f5-a056-b799-dd6d-c5dc762d42f3@gmail.com>
 <205633.1614757174@turing-police>
From:   Heiner Kallweit <hkallweit1@gmail.com>
Message-ID: <c0a272c2-1e7d-022a-88b6-29fca298e7d7@gmail.com>
Date:   Wed, 3 Mar 2021 11:26:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <205633.1614757174@turing-police>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 03.03.2021 08:39, Valdis Klētnieks wrote:
> On Wed, 03 Mar 2021 07:51:06 +0100, Heiner Kallweit said:
>>> # Firmware loader
>>> CONFIG_EXTRA_FIRMWARE="rtl_nic/rtl8106e-1.fw"
>>> CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware"
>>>
>> This is wrong, simply remove it.
> 
>>> But then I take a closer look at  drivers/net/ethernet/realtek/r8169_main.c
>>> #define FIRMWARE_8168D_1	"rtl_nic/rtl8168d-1.fw"
>>> #define FIRMWARE_8168D_2	"rtl_nic/rtl8168d-2.fw"
>>> #define FIRMWARE_8168E_1	"rtl_nic/rtl8168e-1.fw"
> 
> Yes, but then how are *these* filenames supposed to work? Is a userspace helper
> supposed to be smart enough to append the .xz, and the EXTRA_FIRMWARE variant
> for embedding out-of-tree firmware has to point at an uncompressed version? 
> 
There is no such thing as compressed firmware files, see here:
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/rtl_nic

Your issue may be distro-specific, so you should check in a support forum of
your respective distro.