Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1578741pxb; Thu, 4 Mar 2021 15:20:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJyrTr2L4w5a82kDsN8B3BrL6/bfNQd+edO3Ts0MctXC35vnhbbKD0FFUP9xu8i6f9GbsPi5 X-Received: by 2002:a17:906:d18e:: with SMTP id c14mr6437256ejz.62.1614900045349; Thu, 04 Mar 2021 15:20:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614900045; cv=none; d=google.com; s=arc-20160816; b=Yd0seBY+YCV9qDc3IHsh+abVw6D6F6oDxpw0O7sGSjok5o78eMthPXjX298n95fz2J wV1Ts7c76Z2BFtOuQwvVhbMG107ws45miYc+jIn7x4FR6imdxYnwNLisbaFMT5/R5qqy h+LI+j0sUnpMqn5CBc/fAnvxQnu11Oe79+y9JKd04s2rirTm4N5NsXC0jNyxMyndJKZI NlFnIymhH5Qj9kAaRFMBePRLk/+5Kq4ImMfGgDohouKIeBthmkpsPcn9vZPsKJt9Kepz 40VVHs5XAQBqgEPJHXdUgzQqajdrNDLCTRrLOWqREEst8oMzJeDI7nUCED9MLKIo4c6k wGeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=40rMkjxWXVqNvj5udKCXGKEGtGQzZwRj2q8fY5x7CYk=; b=nltlJrXwEpD4cjqt8aS96SSIQ0kMnIxh4n/dccAWy+hcdTKQ8aMZwIt8JZvm4dVYns JdmuOt9Kpoyy02gA6RSPxQNrL+/WN4SccOnq1iG8TmauYlt6BFM7MkxmnyaTAXHfyNt7 B+OoMNvkNRCgHQjD0cZwppmu98CEBIeaT7hWMTHSnrkrfLMbZ/l5+b77jo7+2sRTOz2e PI6nd1Z2Q3fKkU+fZh308dznaYsVqlZGWlr8ospfzj+YDGWydnUNyVghGNnJoZvqLCDh aizvPMJiNTvAFc7rZnhrljxKJpUC233FczA/jHXQFNPBVbTx/nOGuhenfTyjEH7SBS2K 7F1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gwL9DeMn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n22si342330eju.124.2021.03.04.15.20.22; Thu, 04 Mar 2021 15:20:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gwL9DeMn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242367AbhCCRaD (ORCPT + 99 others); Wed, 3 Mar 2021 12:30:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1444842AbhCCNrF (ORCPT ); Wed, 3 Mar 2021 08:47:05 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E567C061A32 for ; Wed, 3 Mar 2021 05:44:03 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id e10so23495950wro.12 for ; Wed, 03 Mar 2021 05:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=40rMkjxWXVqNvj5udKCXGKEGtGQzZwRj2q8fY5x7CYk=; b=gwL9DeMnKXuT9d0yT8cDU0ip7wM4OSKTBI33zHiN5YgYPTQKSZoL8U48t0HgUWgPsy B92nExhX6Y/6Fi+iwlWRIe/IfTCwMKNaURr1k9mdlklZZX6MdJM5ZPi3UgaZZVpOm66l vo+u1h7vsrL50rG6qMxSqy6U/HKLaF0xUyvN4YZXAGOLLV6zNCUUPNY5eYQkJ/zmCBXw d8qk0/sfFHzoh5SLVrKDrolCgP2iZhufccuQszm+wbti42BRfknoJAl1zxUsMgQDCDE6 KLAJXM2tas5wfsHbvuLV4UOT5dVJT0KaRQXdma6pRJEieYc47vUKVnrweEPudfuH5kiy Pyzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=40rMkjxWXVqNvj5udKCXGKEGtGQzZwRj2q8fY5x7CYk=; b=cIRA/R0ecORdtdjWVHysjec3nyPQl1Nf8eLJyyT0shFTrMnfMcYAoAk6v/mip/GMB7 3bOFWWxifin6TeWmTIqq7cp8hwJVksQwdySDK6uLP3WBz9iKIrE+xmSEWBTYs6NrLctO YjVUhcT5IMmaw7URYvRm7Jw5vPRgzwto7pHisLIwsXHKQaYKo0GWLKSlhKyK2lAGzAqz myaNMtT8sirg9Htjji1uO8OKBRkmIajYU/B+z/Hsa7XVfyTZBP8pUopY+hGxloSC9DYG FW1IVxWN2kUktmft0BLt9qm7VAJuB3kkuis/LYZxZmkRV1Or18bJCBcw86z2vlTGW2TT TcPw== X-Gm-Message-State: AOAM532NNHxK5+YU4sWyuUrYJ8OU3xs+01NHhfCVthWy6bRoVL6zZiTv eAGr6+dHL4rmQZKKoquQ+lJpSg== X-Received: by 2002:adf:fec5:: with SMTP id q5mr16914657wrs.43.1614779042019; Wed, 03 Mar 2021 05:44:02 -0800 (PST) Received: from dell.default ([91.110.221.155]) by smtp.gmail.com with ESMTPSA id w18sm6109524wrr.7.2021.03.03.05.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 05:44:01 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Zack Rusin Subject: [PATCH 28/53] drm/vmwgfx/vmwgfx_resource: Fix worthy function headers demote some others Date: Wed, 3 Mar 2021 13:42:54 +0000 Message-Id: <20210303134319.3160762-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210303134319.3160762-1-lee.jones@linaro.org> References: <20210303134319.3160762-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:215: warning: Excess function parameter 'obj_type' description in 'vmw_resource_init' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:303: warning: Excess function parameter 'p_res' description in 'vmw_user_resource_noref_lookup_handle' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'dev_priv' not described in 'vmw_user_lookup_handle' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'tfile' not described in 'vmw_user_lookup_handle' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'handle' not described in 'vmw_user_lookup_handle' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'out_surf' not described in 'vmw_user_lookup_handle' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'out_buf' not described in 'vmw_user_lookup_handle' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:398: warning: Function parameter or member 'dirtying' not described in 'vmw_resource_do_validate' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:601: warning: Function parameter or member 'interruptible' not described in 'vmw_resource_reserve' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:601: warning: Function parameter or member 'no_backup' not described in 'vmw_resource_reserve' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:987: warning: Function parameter or member 'interruptible' not described in 'vmw_resource_pin' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Signed-off-by: Zack Rusin Link: https://patchwork.freedesktop.org/patch/msgid/20210115181313.3431493-11-lee.jones@linaro.org --- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c index d1e7b9608145b..c4df51a2a9262 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c @@ -202,7 +202,6 @@ int vmw_resource_alloc_id(struct vmw_resource *res) * * @dev_priv: Pointer to a device private struct. * @res: The struct vmw_resource to initialize. - * @obj_type: Resource object type. * @delay_id: Boolean whether to defer device id allocation until * the first validation. * @res_free: Resource destructor. @@ -288,8 +287,6 @@ int vmw_user_resource_lookup_handle(struct vmw_private *dev_priv, * @tfile: Pointer to a struct ttm_object_file identifying the caller * @handle: The TTM user-space handle * @converter: Pointer to an object describing the resource type - * @p_res: On successful return the location pointed to will contain - * a pointer to a refcounted struct vmw_resource. * * If the handle can't be found or is associated with an incorrect resource * type, -EINVAL will be returned. @@ -315,7 +312,7 @@ vmw_user_resource_noref_lookup_handle(struct vmw_private *dev_priv, return converter->base_obj_to_res(base); } -/** +/* * Helper function that looks either a surface or bo. * * The pointer this pointed at by out_surf and out_buf needs to be null. @@ -388,6 +385,7 @@ static int vmw_resource_buf_alloc(struct vmw_resource *res, * @res: The resource to make visible to the device. * @val_buf: Information about a buffer possibly * containing backup data if a bind operation is needed. + * @dirtying: Transfer dirty regions. * * On hardware resource shortage, this function returns -EBUSY and * should be retried once resources have been freed up. @@ -586,7 +584,7 @@ vmw_resource_check_buffer(struct ww_acquire_ctx *ticket, return ret; } -/** +/* * vmw_resource_reserve - Reserve a resource for command submission * * @res: The resource to reserve. @@ -973,7 +971,7 @@ void vmw_resource_evict_all(struct vmw_private *dev_priv) mutex_unlock(&dev_priv->cmdbuf_mutex); } -/** +/* * vmw_resource_pin - Add a pin reference on a resource * * @res: The resource to add a pin reference on -- 2.27.0