Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1580540pxb; Thu, 4 Mar 2021 15:23:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJxzW6a8QITmf4tw3F/15a5j7XcN/xgECWPHS50vao7czTykmHF6r4H8OAdJnr0VitPcsxeS X-Received: by 2002:a17:906:a896:: with SMTP id ha22mr6554868ejb.503.1614900213641; Thu, 04 Mar 2021 15:23:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614900213; cv=none; d=google.com; s=arc-20160816; b=GBk8wgDzLybzoON1ne+eyPwYzB0ah3MuDPSDo8V7eBe49aINlqICraH/HEZtTWlfcO jqv0H8n7NeBr7nDyzP1zSz6cWfBVBqry4hHNE8pHAMo3fomJZbMea/wGTUnMxEjz2nQR wTcRXLQlXfw/CGCDq/ykOQeB98kByE/sl61q0awZaQwWIozhCoNcSh3RxKldjoI77Fez W/jGCSGiVq5rXFwMlZLvmV5YMKlxVhD3t9IVZsx9/KQluZwhYxSWvVV4vnVp4uRcnlMO +2FL4Zsr34x9QcwGbipciZuas2Ed0NqgGnaopjovpvfMhH2lOo1oo9WbDVh/9o8YiEHC TtCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=02fu5WYb4zB8afDuZziisDwQ8OoOWP0B0v4Rl6iTFJY=; b=RysOhb81y1KVQyRUfb364i7Rd9OfKhlk7ER/g34sssj6o9l2LWvhy9RuGG0RSqfpkY JT1HlwTAU9cIZLzJMMkJ7qYNJ0uJI2UZVsFB0TvFMHhasvX+++TCj5rg563FemNm92l3 VwXHHIzFXqYMkXhrPKr3a3LIWPlbnKh2bZUg8C99AYQ2dPdXWl8jA0B/oKDyBe6qxdGp OBm8bvRn6Q+rh0iwNbwkMyfEaCY5VPUKCQ8pBrFtjKG9x66mKbapxYwpGSKvH0QKQP80 9i28P6RqgLoLAMsyf5J3oQeb2Lo90y0/5JkbUJU1tlz/jVFwb+yCi9ko6gQrsZFSGP4D aZjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IqUr1tr6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o13si349582ejn.226.2021.03.04.15.23.11; Thu, 04 Mar 2021 15:23:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IqUr1tr6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1835391AbhCCSDT (ORCPT + 99 others); Wed, 3 Mar 2021 13:03:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359865AbhCCPPd (ORCPT ); Wed, 3 Mar 2021 10:15:33 -0500 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B112C061763 for ; Wed, 3 Mar 2021 07:14:53 -0800 (PST) Received: by mail-qt1-x835.google.com with SMTP id s15so17762313qtq.0 for ; Wed, 03 Mar 2021 07:14:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=02fu5WYb4zB8afDuZziisDwQ8OoOWP0B0v4Rl6iTFJY=; b=IqUr1tr6XVDEkkhNF54HYhb5qpKF79GGDSvxIkcDDqzw0sUuYq2YdnlvAFxbjvcM/Z KaaMML7XI29GvXAQSwj65qAJobsyf45FOKs6BSaQMS8Dbw833jKNUcEJCwJhSfclfIqD V7rofKELfQDdgO9NFSI9fgPby9fqOXX4UHoRhYdY2dq251QoZ2Spnv+HC55iNfpohj8Y EhZyntXP2pSM8hXeMfEm5b5+eEc9WNIKsH+P++cFgoSaktsaYkHcfrliBmIvAZK2+BrJ /7OnO7WC/Y9HPDZBnMLnmhY+SEBiPieyT9mkW68sHJq4o6lBHERLUxqeydWh7TpMo7xA l0UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=02fu5WYb4zB8afDuZziisDwQ8OoOWP0B0v4Rl6iTFJY=; b=axR46SgRoVrSdugGNyLO1MqL8lt/4JH59ybNaH+eUf6u8b/z4reV+Bo5fPSG2kjslb 4cwcy2aJzBlfAWNp6syLuVHp1/MVttJtijjanlZSzqxics0hbKbl0MgY8xsKlx0reXgx xK8RWgJIz2WQMWACBu/0it51UvivQPAYHu1OltJCcynCR6rPcrKG2ZHap5ZJfwG0HacB 0rYKDWTMKYGe8CkBvjMfVnxff9BJnc1H35icETZA9+d4GEq76XzGsTiLFVhZJ1PoYNyc GfoXUkXAgzAPpxqTtfQEXjCU5gY4rWAD+5DAhsnTUI0npivYAa+OYITNqrNa7U/dAj6F MFpw== X-Gm-Message-State: AOAM530ZfUExLarr3o1H8PaeL8fYkRZPempLRVJQ4qaCRquvF9HJlf22 gs2gu/PTnquk4py7sG7Sd2w= X-Received: by 2002:a05:622a:210:: with SMTP id b16mr7052088qtx.69.1614784492703; Wed, 03 Mar 2021 07:14:52 -0800 (PST) Received: from localhost (2603-7000-9602-8233-06d4-c4ff-fe48-9d05.res6.spectrum.com. [2603:7000:9602:8233:6d4:c4ff:fe48:9d05]) by smtp.gmail.com with ESMTPSA id n5sm11629167qkp.133.2021.03.03.07.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 07:14:51 -0800 (PST) Sender: Tejun Heo Date: Wed, 3 Mar 2021 10:14:50 -0500 From: Tejun Heo To: qiang.zhang@windriver.com Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] workqueue: Move the position of debug_work_activate() in __queue_work() Message-ID: References: <20210218031649.151638-1-qiang.zhang@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210218031649.151638-1-qiang.zhang@windriver.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 11:16:49AM +0800, qiang.zhang@windriver.com wrote: > From: Zqiang > > The debug_work_activate() is called on the premise that > the work can be inserted, because if wq be in WQ_DRAINING > status, insert work may be failed. > > Fixes: e41e704bc4f4 ("workqueue: improve destroy_workqueue() debuggability") > Signed-off-by: Zqiang > Reviewed-by: Lai Jiangshan Applied to wq/for-5.12-fixes. Thanks. -- tejun