Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH v3 01/14] gpio: regmap: set gpio_chip of_node
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <40403445ae34e822474e5f39be75fd0b@walle.cc>
Date:   Wed, 3 Mar 2021 17:12:35 +0100
Cc:     Rob Herring <robh+dt@kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list@broadcom.com,
        Jonas Gorski <jonas.gorski@gmail.com>,
        Necip Fazil Yildiran <fazilyildiran@gmail.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <E341768B-BF42-4749-8D43-8C5CB24D64C3@gmail.com>
References: <20210303142310.6371-1-noltari@gmail.com>
 <20210303142310.6371-2-noltari@gmail.com>
 <40403445ae34e822474e5f39be75fd0b@walle.cc>
To:     Michael Walle <michael@walle.cc>,
        Linus Walleij <linus.walleij@linaro.org>
Precedence: bulk

Hi Linus,

Do you want me to send v4 with these changes?
Or maybe just this single patch?

Best regards,
=C3=81lvaro.

> El 3 mar 2021, a las 17:08, Michael Walle <michael@walle.cc> =
escribi=C3=B3:
>=20
> Am 2021-03-03 15:22, schrieb =C3=81lvaro Fern=C3=A1ndez Rojas:
>> This is needed for properly registering gpio regmap as a child of a =
regmap
>> pin controller.
>> Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas <noltari@gmail.com>
>> ---
>> v3: introduce patch needed for properly parsing gpio-ranges.
>> drivers/gpio/gpio-regmap.c  | 1 +
>> include/linux/gpio/regmap.h | 3 +++
>> 2 files changed, 4 insertions(+)
>> diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c
>> index 5412cb3b0b2a..752ccd780b7d 100644
>> --- a/drivers/gpio/gpio-regmap.c
>> +++ b/drivers/gpio/gpio-regmap.c
>> @@ -249,6 +249,7 @@ struct gpio_regmap *gpio_regmap_register(const
>> struct gpio_regmap_config *config
>> 	chip =3D &gpio->gpio_chip;
>> 	chip->parent =3D config->parent;
>> +	chip->of_node =3D config->of_node;
>=20
> chip->of_node =3D config->of_node ?: dev_of_node(config->parent);
>=20
> As mentioned in my previous reply in this thread, for clarity
> reasons.
>=20
>> 	chip->base =3D -1;
>> 	chip->ngpio =3D config->ngpio;
>> 	chip->names =3D config->names;
>> diff --git a/include/linux/gpio/regmap.h =
b/include/linux/gpio/regmap.h
>> index ad76f3d0a6ba..f6e638e32d2a 100644
>> --- a/include/linux/gpio/regmap.h
>> +++ b/include/linux/gpio/regmap.h
>> @@ -4,6 +4,7 @@
>> #define _LINUX_GPIO_REGMAP_H
>> struct device;
>> +struct device_node;
>> struct gpio_regmap;
>> struct irq_domain;
>> struct regmap;
>> @@ -14,6 +15,7 @@ struct regmap;
>> /**
>>  * struct gpio_regmap_config - Description of a generic regmap =
gpio_chip.
>>  * @parent:		The parent device
>> + * @of_node:		The device node
>=20
> Please add "(Optional)" and move it below @regmap. This should also
> mention that if not supplied parent->of_node is used.
>=20
>>  * @regmap:		The regmap used to access the registers
>>  *			given, the name of the device is used
>>  * @label:		(Optional) Descriptive name for GPIO controller.
>> @@ -56,6 +58,7 @@ struct regmap;
>>  */
>> struct gpio_regmap_config {
>> 	struct device *parent;
>> +	struct device_node *of_node;
>> 	struct regmap *regmap;
>> 	const char *label;
>=20
> With these changes:
> Reviewed-by: Michael Walle <michael@walle.cc>
>=20
> -michael