Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1582753pxb; Thu, 4 Mar 2021 15:26:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJweHaQzP1YnJgH8ow0Hzc4dT0IpCFVduHkiclkywLFQ+tSo12cwsXbMqpOeTLw2DPwirEyT X-Received: by 2002:aa7:d0c2:: with SMTP id u2mr4822638edo.158.1614900416640; Thu, 04 Mar 2021 15:26:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614900416; cv=none; d=google.com; s=arc-20160816; b=Iqm7m2v/oT5CFRnhGE19xqFKPuzuEXDDIiWT4JMfMLKU1KhdvxPcBwJRpwAnIDHWoZ QMRqAnabH9N/ARJKM78mfHgctMpeqs2O7wKyO/03yKknuEfOVTLjCKuYBtlG82HtxLIt Llcy1faqYPVzbVYPFVb1112FJHFoMkKCeSxlX+KoYR9gq4JLrATLlTdxMXBIl5TQ+VUw UUKPThhfx+k05KkhGFC885xV6V/r2wTQG3TeL7qvnyv5Kqeziv4Vv9ueNHw6oorgRkkE YKFRytAiDmTAC5lWT0P6wkkc9Q9Ifa3eiUqc7RyeQQaOs+ZArKjg9YHC10JsaTq5U8bn s+og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=Y0Tp0Ej5DKuMTRZQgaG3nUUFIbseez4IjkzWslTJ2bI=; b=S2nL1aPuO0/badh81IqoOXWcFSX/Gzv2VPqtMt1uxiaVRx3BfV3rN0fb1JnUEKlqX0 3gkCc4UglfkDRm1nLbUeP/iPEdTqhSlwMAf10bZjEdBReWtbqugJJJhrF3HVA4lIe5uO /9MbJ09fD4LJbhC190j2WbxsJSHW870nk4ZEwEYEBjoAU7bQL65i7zh1jat2j0v/FDly KnvI7XelVJK98zB9q8umVBRtgmpeB7SoY/jjnCTVa5otypYTm1ObCK/2mFuxE1MVoN6N aWkNNpbxtspXskem+9KNi5pVFciLs+lgU0H8kdIb/GNXBfLD+PT9GaiCi6VJUaw9hIBe iUAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t14si349742ejr.191.2021.03.04.15.26.33; Thu, 04 Mar 2021 15:26:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1837210AbhCCSsn (ORCPT + 99 others); Wed, 3 Mar 2021 13:48:43 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:31744 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237847AbhCCSIl (ORCPT ); Wed, 3 Mar 2021 13:08:41 -0500 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4DrMRT2KJHz9twsP; Wed, 3 Mar 2021 19:07:49 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id Oezy_9lCxP9I; Wed, 3 Mar 2021 19:07:49 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4DrMRT1Nrpz9twsB; Wed, 3 Mar 2021 19:07:49 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 6D9A88B7E6; Wed, 3 Mar 2021 19:07:49 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id mppgCCIWAOu2; Wed, 3 Mar 2021 19:07:49 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id A8E2F8B7DB; Wed, 3 Mar 2021 19:07:48 +0100 (CET) Subject: Re: [PATCH v2 0/7] Improve boot command line handling To: Daniel Walker , Rob Herring Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Daniel Gimpelevich , "linux-kernel@vger.kernel.org" , linuxppc-dev , "open list:GENERIC INCLUDE/ASM HEADER FILES" , devicetree@vger.kernel.org, Will Deacon References: <20210302173523.GE109100@zorba> <20210303173908.GG109100@zorba> From: Christophe Leroy Message-ID: <59b054e8-d85b-fd87-c94d-691af748a2f5@csgroup.eu> Date: Wed, 3 Mar 2021 19:07:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210303173908.GG109100@zorba> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 03/03/2021 à 18:39, Daniel Walker a écrit : > On Tue, Mar 02, 2021 at 08:01:01PM -0600, Rob Herring wrote: >> +Will D >> >> On Tue, Mar 2, 2021 at 11:36 AM Daniel Walker wrote: >>> >>> On Tue, Mar 02, 2021 at 05:25:16PM +0000, Christophe Leroy wrote: >>>> The purpose of this series is to improve and enhance the >>>> handling of kernel boot arguments. >>>> >>>> It is first focussed on powerpc but also extends the capability >>>> for other arches. >>>> >>>> This is based on suggestion from Daniel Walker >>>> >>> >>> >>> I don't see a point in your changes at this time. My changes are much more >>> mature, and you changes don't really make improvements. >> >> Not really a helpful comment. What we merge here will be from whomever >> is persistent and timely in their efforts. But please, work together >> on a common solution. >> >> This one meets my requirements of moving the kconfig and code out of >> the arches, supports prepend/append, and is up to date. > > > Maintainers are capable of merging whatever they want to merge. However, I > wouldn't make hasty choices. The changes I've been submitting have been deployed > on millions of router instances and are more feature rich. > > I believe I worked with you on this change, or something like it, > > https://lkml.org/lkml/2019/3/19/970 > > I don't think Christophe has even addressed this. I thing I have, see https://patchwork.ozlabs.org/project/linuxppc-dev/patch/3b4291271ce4af4941a771e5af5cbba3c8fa1b2a.1614705851.git.christophe.leroy@csgroup.eu/ If you see something missing in that patch, can you tell me. > I've converted many > architectures, and Cisco uses my changes on at least 4 different > architecture. With products deployed and tested. As far as we know, only powerpc was converted in the last series you submitted, see https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=98106&state=* > > I will resubmit my changes as soon as I can. > Christophe