Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 03 Mar 2021 18:26:32 -0800 (PST)
Subject:     Re: [PATCH] Documentation/admin-guide: kernel-parameters: correct the architectures for numa_balancing
In-Reply-To: <20210302084159.33688-1-song.bao.hua@hisilicon.com>
CC:     corbet@lwn.net, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
        song.bao.hua@hisilicon.com, mgorman@suse.de,
        Paul Walmsley <paul.walmsley@sifive.com>,
        aou@eecs.berkeley.edu, paulmck@kernel.org, rdunlap@infradead.org,
        akpm@linux-foundation.org, tglx@linutronix.de,
        mchehab+huawei@kernel.org, viresh.kumar@linaro.org,
        mike.kravetz@oracle.com, peterz@infradead.org
From:   Palmer Dabbelt <palmer@dabbelt.com>
To:     song.bao.hua@hisilicon.com
Message-ID: <mhng-a06d1543-65b7-49fa-87c7-f437ec1d85ea@penguin>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 02 Mar 2021 00:41:59 PST (-0800), song.bao.hua@hisilicon.com wrote:
> X86 isn't the only architecture supporting NUMA_BALANCING. ARM64, PPC,
> S390 and RISCV also support it:
>
> arch$ git grep NUMA_BALANCING
> arm64/Kconfig:  select ARCH_SUPPORTS_NUMA_BALANCING
> arm64/configs/defconfig:CONFIG_NUMA_BALANCING=y
> arm64/include/asm/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> powerpc/configs/powernv_defconfig:CONFIG_NUMA_BALANCING=y
> powerpc/configs/ppc64_defconfig:CONFIG_NUMA_BALANCING=y
> powerpc/configs/pseries_defconfig:CONFIG_NUMA_BALANCING=y
> powerpc/include/asm/book3s/64/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> powerpc/include/asm/book3s/64/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> powerpc/include/asm/book3s/64/pgtable.h:#endif /* CONFIG_NUMA_BALANCING */
> powerpc/include/asm/book3s/64/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> powerpc/include/asm/book3s/64/pgtable.h:#endif /* CONFIG_NUMA_BALANCING */
> powerpc/include/asm/nohash/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> powerpc/include/asm/nohash/pgtable.h:#endif /* CONFIG_NUMA_BALANCING */
> powerpc/platforms/Kconfig.cputype:      select ARCH_SUPPORTS_NUMA_BALANCING
> riscv/Kconfig:  select ARCH_SUPPORTS_NUMA_BALANCING
> riscv/include/asm/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> s390/Kconfig:   select ARCH_SUPPORTS_NUMA_BALANCING
> s390/configs/debug_defconfig:CONFIG_NUMA_BALANCING=y
> s390/configs/defconfig:CONFIG_NUMA_BALANCING=y
> s390/include/asm/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> x86/Kconfig:    select ARCH_SUPPORTS_NUMA_BALANCING     if X86_64
> x86/include/asm/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> x86/include/asm/pgtable.h:#endif /* CONFIG_NUMA_BALANCING */
>
> On the other hand, setup_numabalancing() is implemented in mm/mempolicy.c
> which doesn't depend on architectures.
>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: "Paul E. McKenney" <paulmck@kernel.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> ---
>  Documentation/admin-guide/kernel-parameters.rst | 1 +
>  Documentation/admin-guide/kernel-parameters.txt | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.rst b/Documentation/admin-guide/kernel-parameters.rst
> index 1132796a8d96..24302cad174a 100644
> --- a/Documentation/admin-guide/kernel-parameters.rst
> +++ b/Documentation/admin-guide/kernel-parameters.rst
> @@ -140,6 +140,7 @@ parameter is applicable::
>  	PPT	Parallel port support is enabled.
>  	PS2	Appropriate PS/2 support is enabled.
>  	RAM	RAM disk support is enabled.
> +	RISCV	RISCV architecture is enabled.
>  	RDT	Intel Resource Director Technology.
>  	S390	S390 architecture is enabled.
>  	SCSI	Appropriate SCSI support is enabled.
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 04545725f187..371a02ae1e21 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -3472,7 +3472,8 @@
>
>  	nr_uarts=	[SERIAL] maximum number of UARTs to be registered.
>
> -	numa_balancing=	[KNL,X86] Enable or disable automatic NUMA balancing.
> +	numa_balancing=	[KNL,ARM64,PPC,RISCV,S390,X86] Enable or disable automatic
> +			NUMA balancing.
>  			Allowed values are enable and disable
>
>  	numa_zonelist_order= [KNL, BOOT] Select zonelist order for NUMA.

Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>