Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: cang=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 04 Mar 2021 16:37:21 +0800
From:   Can Guo <cang@codeaurora.org>
To:     Bean Huo <huobean@gmail.com>
Cc:     daejun7.park@samsung.com, Greg KH <gregkh@linuxfoundation.org>,
        avri.altman@wdc.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, asutoshd@codeaurora.org,
        stanley.chu@mediatek.com, bvanassche@acm.org,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
Subject: Re: [PATCH v26 4/4] scsi: ufs: Add HPB 2.0 support
In-Reply-To: <2f1b8ff5aec540ef731bf5b2c3691dd23ea2e6b0.camel@gmail.com>
References: <20210303062633epcms2p252227acd30ad15c1ca821d7e3f547b9e@epcms2p2>
 <CGME20210303062633epcms2p252227acd30ad15c1ca821d7e3f547b9e@epcms2p6>
 <20210303062926epcms2p6aa6737e5ed3916eed9ab80011aad3d83@epcms2p6>
 <2f1b8ff5aec540ef731bf5b2c3691dd23ea2e6b0.camel@gmail.com>
Message-ID: <bffa984b28a4b3a8af3eefba39de6b18@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-03-03 22:50, Bean Huo wrote:
> On Wed, 2021-03-03 at 15:29 +0900, Daejun Park wrote:
>> +
>> +static inline void ufshpb_put_pre_req(struct ufshpb_lu *hpb,
>> +                                     struct ufshpb_req *pre_req)
>> +{
>> +       pre_req->req = NULL;
>> +       pre_req->bio = NULL;
>> +       list_add_tail(&pre_req->list_req, &hpb->lh_pre_req_free);
>> +       hpb->num_inflight_pre_req--;
>> +}
>> +
>> +static void ufshpb_pre_req_compl_fn(struct request *req,
>> blk_status_t error)
>> +{
>> +       struct ufshpb_req *pre_req = (struct ufshpb_req *)req-
>> >end_io_data;
>> +       struct ufshpb_lu *hpb = pre_req->hpb;
>> +       unsigned long flags;
>> +       struct scsi_sense_hdr sshdr;
>> +
>> +       if (error) {
>> +               dev_err(&hpb->sdev_ufs_lu->sdev_dev, "block status
>> %d", error);
>> +               scsi_normalize_sense(pre_req->sense,
>> SCSI_SENSE_BUFFERSIZE,
>> +                                    &sshdr);
>> +               dev_err(&hpb->sdev_ufs_lu->sdev_dev,
>> +                       "code %x sense_key %x asc %x ascq %x",
>> +                       sshdr.response_code,
>> +                       sshdr.sense_key, sshdr.asc, sshdr.ascq);
>> +               dev_err(&hpb->sdev_ufs_lu->sdev_dev,
>> +                       "byte4 %x byte5 %x byte6 %x additional_len
>> %x",
>> +                       sshdr.byte4, sshdr.byte5,
>> +                       sshdr.byte6, sshdr.additional_length);
>> +       }
> 
> 
> How can you print out sense_key and sense code here? sense code will
> not be copied to pre_req->sense. you should directly use
> scsi_request->sense or let pre_req->sense point to scsi_request->sense.
> 
> You update the new version patch so quickly. In another word, I am
> wondering if you tested your patch before submitting?
> 
> Bean

Bean is right about the sense buffer...