Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210304082837.22262-1-heikki.krogerus@linux.intel.com>
In-Reply-To: <20210304082837.22262-1-heikki.krogerus@linux.intel.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Thu, 4 Mar 2021 09:30:00 +0100
Message-ID: <CAMj1kXHXOGidWqueyxmxSQOQ6+1DW4trTg600roLF20Zh0_Z2g@mail.gmail.com>
Subject: Re: [PATCH] efi/apple-properties: Handle device properties with
 software node API
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Lukas Wunner <lukas@wunner.de>
Cc:     linux-efi <linux-efi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

(+ Lukas)

On Thu, 4 Mar 2021 at 09:28, Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> The old device property API is going to be removed.
> Replacing the device_add_properties() call with the software
> node API equivalent, device_create_managed_software_node().
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>  drivers/firmware/efi/apple-properties.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/apple-properties.c b/drivers/firmware/efi/apple-properties.c
> index e1926483ae2fd..4c3201e290e29 100644
> --- a/drivers/firmware/efi/apple-properties.c
> +++ b/drivers/firmware/efi/apple-properties.c
> @@ -157,7 +157,7 @@ static int __init unmarshal_devices(struct properties_header *properties)
>                 if (!entry[0].name)
>                         goto skip_device;
>
> -               ret = device_add_properties(dev, entry); /* makes deep copy */
> +               ret = device_create_managed_software_node(dev, entry, NULL);
>                 if (ret)
>                         dev_err(dev, "error %d assigning properties\n", ret);
>
> --
> 2.30.1
>